T245482: Remove core fallbacks to global $wgUser [1.35] || T262707: Remove core fallbacks to global $wgUser [1.37]
See T242935: Deprecate core fallbacks to $wgUser for deprecations
Following hard deprecations in 1.35, some fallbacks should be removed.
Subtasks are for each fallback that should be removed. All deployed callers have already been updated, but ideally calls from non-deployed extensions will still be updated.
@Pchelolo @daniel I'd like to do the first batch of removals all together around the start of 1.36. Would that be okay, or should the removals be done separately? I just think it'll be easier to make progress on the remaining uses of $wgUser if the deprecated uses that have no remaining uses are removed first. Thoughts?
I'm not entirely sure what you mean. Do you mean remove all fallbacks in core with a single patch? I don't really care, whatever is more convenient. Given that the fallbacks you'd be removing were already hard-deprecated, it seems safe to do.
Other than beginning to remove the Revision related code, this looks mostly done?
Haven't sent patches for the revisions pending resolution of the -2 on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/614027
Recent discussions on wikitech-l suggest that waiting 2 versions is not required. @Legoktm can you reconsider your -2?
Nothing more to remove before 1.36 is tagged, new work is at T262707: Remove core fallbacks to global $wgUser [1.37]