Page MenuHomePhabricator

Remove core fallbacks to global $wgUser [1.36]
Open, MediumPublic

Description

T245482: Remove core fallbacks to global $wgUser [1.35] || NOTYETCREATED

See T242935: Deprecate core fallbacks to $wgUser for deprecations

Following hard deprecations in 1.35, some fallbacks should be removed.

Subtasks are for each fallback that should be removed. All deployed callers have already been updated, but ideally calls from non-deployed extensions will still be updated.

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenDannyS712
OpenDannyS712
OpenDannyS712
StalledDannyS712
ResolvedDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
ResolvedDannyS712
StalledDannyS712
StalledDannyS712
ResolvedDannyS712
StalledDannyS712
ResolvedDannyS712
StalledDannyS712
ResolvedDannyS712
ResolvedYaron_Koren
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
StalledDannyS712
ResolvedDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
ResolvedDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
OpenDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712
StalledDannyS712

Event Timeline

DannyS712 moved this task from Blocker to Deprecate/Remove on the MW-1.36-release board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 changed the status of subtask T245355: Remove ApiTestCase::doLogin from Open to Stalled.Feb 16 2020, 7:49 AM
DannyS712 triaged this task as Medium priority.Feb 19 2020, 1:22 AM
DannyS712 changed the status of subtask T245703: Remove Revision::newNullRevision from Open to Stalled.Feb 20 2020, 2:15 AM
DannyS712 changed the status of subtask T245777: Remove WebRequest::getLimitOffset from Open to Stalled.Feb 20 2020, 8:47 PM
DannyS712 changed the status of subtask T246141: Remove old SpecialPageFactory from Open to Stalled.Feb 25 2020, 6:29 PM
DannyS712 changed the status of subtask T246411: Remove Revision::userCanBitfield from Open to Stalled.Feb 28 2020, 6:37 AM
DannyS712 changed the status of subtask T247143: Remove deprecated revision methods [1.36] from Open to Stalled.Mar 6 2020, 11:24 PM
DannyS712 changed the status of subtask T248022: Remove deprecated api token hooks from Open to Stalled.Mar 18 2020, 8:21 PM
DannyS712 changed the status of subtask T248036: Remove Revision::getParentLengths from Open to Stalled.Mar 18 2020, 10:56 PM
DannyS712 changed the status of subtask T248192: Remove PageArchive::undelete from Open to Stalled.Mar 20 2020, 6:40 PM
DannyS712 added subscribers: Pchelolo, daniel.EditedMar 24 2020, 9:37 PM

@Pchelolo @daniel I'd like to do the first batch of removals all together around the start of 1.36. Would that be okay, or should the removals be done separately? I just think it'll be easier to make progress on the remaining uses of $wgUser if the deprecated uses that have no remaining uses are removed first. Thoughts?

I'm not entirely sure what you mean. Do you mean remove all fallbacks in core with a single patch? I don't really care, whatever is more convenient. Given that the fallbacks you'd be removing were already hard-deprecated, it seems safe to do.

I'm not entirely sure what you mean. Do you mean remove all fallbacks in core with a single patch? I don't really care, whatever is more convenient. Given that the fallbacks you'd be removing were already hard-deprecated, it seems safe to do.

Yes, I mean doing as much as possible in one patch

DannyS712 changed the status of subtask T248549: Remove Revision::getRevisionText from Open to Stalled.Mar 26 2020, 4:33 AM