Page MenuHomePhabricator

Ensure all calls to FileDeleteForm::doDelete pass a user
Closed, ResolvedPublic

Description

Not passing a user was hard deprecated in 1.35 (T245682: Deprecate calling FileDeleteForm::doDelete without passing a user) and will be removed in 1.36 (see parent task)

Codesearch:
https://codesearch.wmflabs.org/search/?q=FileDeleteForm%3A%3AdoDelete&i=nope&files=&repos=

  • Core (already done)
  • Block and nuke
  • BlueSpiceAvatars
  • nuke (WMF deployed, already done)

Event Timeline

DannyS712 created this task.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

Change 573870 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlockAndNuke@master] Pass a user to FileDeleteForm::doDelete (though deletePage(s) calls)

https://gerrit.wikimedia.org/r/573870

Change 573871 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceAvatars@master] BSApiAvatarsTasksTest: Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573871

Change 573871 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceAvatars@master] BSApiAvatarsTasksTest: Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573871

Change 573870 merged by jenkins-bot:
[mediawiki/extensions/BlockAndNuke@master] Pass a user to FileDeleteForm::doDelete (though deletePage(s) calls)

https://gerrit.wikimedia.org/r/573870

DannyS712 removed a project: Patch-For-Review.
DannyS712 updated the task description. (Show Details)