Page MenuHomePhabricator
Create Task
Maniphest T242935

Deprecate core fallbacks to $wgUser
Closed, ResolvedPublic
Actions

Description

Subtasks exist where there are more callers or other complications for specific methods

Details

SubjectRepoBranchLines +/-
Add missing File::recordUpload2, hard deprecate File::recordUploadmediawiki/coremaster+51 -0
Deprecate falling back to $wgUser in some functionsmediawiki/coremaster+39 -15
Add a user parameter to RecentChange::markPatrolledmediawiki/coremaster+12 -4
Tests: pass a $user to Revision::newNullRevision & Wikipage::getContentmediawiki/coremaster+8 -4
Pass a $user to Revision::newNullRevisionmediawiki/extensions/FlaggedRevsmaster+1 -1
Pass a $user to WikiPage::insertProtectNullRevisionmediawiki/extensions/Translatemaster+2 -1
Pass a $user to WikiPage::insertProtectNullRevisionmediawiki/extensions/ArticleFeedbackv5master+2 -1
Pass a $user to Revision::newNullRevisionmediawiki/extensions/Duplicatormaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT11968 Reduce use of global and public variables
 OpenNoneT159283 Deprecate non-configuration globals
 OpenDannyS712T159299 Deprecate and remove $wgUser
 ResolvedDannyS712T267861 [GOAL] Emit deprecation warnings reading from $wgUser
 OpenDannyS712T243708 Mediawiki core needs uses of global $wgUser removed
 ResolvedDannyS712T242935 Deprecate core fallbacks to $wgUser
 ResolvedDannyS712T243652 Calls to LogPage::addEntry should pass a user
 ResolvedDannyS712T243805 WebRequest::getLimitOffset should accept a user
 ResolvedDannyS712T244039 Api tests: Hard deprecate ApiTestCase::doLogin, remove calls in favor of passing a user where needed
 ResolvedDannyS712T244922 Hard deprecate Title user permission methods
 ResolvedDannyS712T244923 Hard deprecate Title::userCan
 ResolvedDannyS712T244927 Hard deprecate Title::quickUserCan
 ResolvedDannyS712T244929 Hard deprecate Title::getUserPermissionsErrors
 ResolvedDannyS712T245195 Hard deprecate RecentChange::markPatrolled
 ResolvedDannyS712T245233 FileDeleteForm uses $wgUser
 ResolvedDannyS712T245682 Deprecate calling FileDeleteForm::doDelete without passing a user
 ResolvedDannyS712T245686 Hard deprecate old SpecialPageFactory
 ResolvedDannyS712T245710 LocalFileDeleteBatch accepts an optional user, falls back to $wgUser
 ResolvedDannyS712T247491 Audit all ->delete calls
 ResolvedDannyS712T245958 Revision::userCanBitfield falls back to $wgUser
 ResolvedDannyS712T246189 Follow up: Hard deprecate not passing a user to ::userCan methods
 ResolvedDannyS712T247259 Remove remaining calls and hard deprecate Revision::userCan
 ResolvedDannyS712T246414 Audit all userCan calls
 ResolvedDannyS712T251357 Logs: Use of ArchivedFile::userCan without passing a $user parameter was deprecated in MediaWiki 1.35
 ResolvedDannyS712T246409 Deprecate LogEventsList::getExcludeClause fallback to $wgUser
 ResolvedDannyS712T246410 Deprecate LogEventsList::typeAction use of $wgUser
 ResolvedDannyS712T246735 UploadStash accepts an optional user parameter and defaults to $wgUser
 ResolvedDannyS712T246738 WikiPage::doDeleteArticleReal falls back to $wgUser
 ResolvedDannyS712T247869 Hard deprecate old signature in WikiPage::doDeleteArticleReal
 ResolvedDannyS712T247871 Audit all ->doDeleteArticleReal calls
 ResolvedDannyS712T248000 Hard deprecate Article::doDeleteArticle and WikiPage::doDeleteArticle
 ResolvedDannyS712T246861 Deprecate not passing a user to ParserOptions::__construct and ::newCanonical
 ResolvedDannyS712T246862 Language::dateFormat and ::userAdjust use $wgUser
 ResolvedDannyS712T247188 PageArchive::undelete falls back to $wgUser
 ResolvedDannyS712T248813 File::recordUpload* falls back to $wgUser
 ResolvedDannyS712T263811 LocalFile::upload without a user fails in ::recordUpload3
 Declined• PcheloloT250638 Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus
 ResolvedDannyS712T252179 Edits saved via PageUpdater need autopatrol status set
 ResolvedDannyS712T254702 GenderCache::getGenderOf uses $wgUser
 ResolvedDannyS712T255507 WikiPage::doEditContent falls back to $wgUser
 ResolvedDannyS712T256007 AddWiki.php wrongly uses 127.0.0.1 instead of a system account
 ResolvedDannyS712T285447 Deprecate WikiPage::prepareContentForEdit() fallback to $wgUser

Event Timeline

DannyS712 created this task.Jan 16 2020, 1:13 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 16 2020, 1:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jan 16 2020, 1:14 AM

Change 563759 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Deprecate not passing a user to Title::getNotificationTimestamp

https://gerrit.wikimedia.org/r/563759

gerritbot added a project: Patch-For-Review.Jan 16 2020, 1:14 AM
DannyS712 added a comment.Jan 16 2020, 1:15 AM

Looking through the codesearch[1], most calls to getNotificationTimestamp relate to a WatchedItem (ie call WatchedItem::getNotificationTimestamp rather than Title::getNotificationTimestamp. I see no remaining uses of the title method that do not provide a user. Are there any objections to hard deprecating not providing a user without soft-deprecation first?

[1] https://codesearch.wmflabs.org/search/?q=getNotificationTimestamp%5C(&i=nope&files=&repos=

Calls to doDeleteArticleReal do not all include a user:
https://codesearch.wmflabs.org/search/?q=doDeleteArticleReal%5C(&i=nope&files=&repos=

Aklapper added a project: MediaWiki-General.Jan 16 2020, 9:15 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Jan 17 2020, 5:11 AM
DannyS712 added a comment.Jan 17 2020, 10:51 PM

Other core fallbacks to $wgUser:

FileDeleteForm::doDelete
Callers that don't pass a user:

Revision::newNullRevision
Calls that don't pass a user:

RecentChange::markPatrolled
Only 1 caller, can be easily dealt with (SpecialPatroller in MediaWiki-extensions-Patroller)

PatrolLog::record - all callers already include a user

DannyS712 updated the task description. (Show Details)Jan 17 2020, 11:59 PM
gerritbot added a comment.Jan 18 2020, 12:02 AM

Change 565702 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add a user parameter to RecentChange::markPatrolled

https://gerrit.wikimedia.org/r/565702

gerritbot added a comment.Jan 18 2020, 12:06 AM

Change 565704 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Patroller@master] Pass a user to RecentChange::markPatrolled

https://gerrit.wikimedia.org/r/565704

gerritbot added a comment.Jan 18 2020, 12:12 AM

Change 565705 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Tests: pass a $user to Revision::newNullRevision in RevisionDbTestBase

https://gerrit.wikimedia.org/r/565705

gerritbot added a comment.Jan 18 2020, 12:15 AM

Change 565706 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Duplicator@master] Pass a $user to Revision::newNullRevision

https://gerrit.wikimedia.org/r/565706

gerritbot added a comment.Jan 18 2020, 12:16 AM

Change 565707 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Pass a $user to Revision::newNullRevision

https://gerrit.wikimedia.org/r/565707

DannyS712 moved this task from Next to In progress on the User-DannyS712 board.Jan 18 2020, 12:24 AM
gerritbot added a comment.Jan 22 2020, 1:55 PM

Change 565706 merged by jenkins-bot:
[mediawiki/extensions/Duplicator@master] Pass a $user to Revision::newNullRevision

https://gerrit.wikimedia.org/r/565706

DannyS712 added a comment.Jan 23 2020, 6:50 PM

Revision::getContent has a fallback; only used for a test, see https://codesearch.wmflabs.org/search/?q=getContent%5C(%20Revision%3A%3AFOR_THIS_USER&i=nope&files=&repos=

gerritbot added a comment.Jan 24 2020, 4:20 AM

Change 566922 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ArticleFeedbackv5@master] Pass a $user to WikiPage::insertProtectNullRevision

https://gerrit.wikimedia.org/r/566922

gerritbot added a comment.Jan 24 2020, 4:21 AM

Change 566924 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Pass a $user to WikiPage::insertProtectNullRevision

https://gerrit.wikimedia.org/r/566924

gerritbot added a comment.Jan 24 2020, 4:46 AM

Change 566922 merged by jenkins-bot:
[mediawiki/extensions/ArticleFeedbackv5@master] Pass a $user to WikiPage::insertProtectNullRevision

https://gerrit.wikimedia.org/r/566922

gerritbot added a comment.Jan 24 2020, 4:09 PM

Change 566924 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Pass a $user to WikiPage::insertProtectNullRevision

https://gerrit.wikimedia.org/r/566924

DannyS712 updated the task description. (Show Details)Jan 25 2020, 1:19 AM
Jdforrester-WMF added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 26 2020, 1:15 AM
DannyS712 added a subtask: T155696: Replace Article::doEditContent() with WikiPage::doEditContent().Jan 26 2020, 8:48 AM
DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.Jan 26 2020, 9:57 AM
DannyS712 added a parent task: T243708: Mediawiki core needs uses of global $wgUser removed.
gerritbot added a comment.Feb 5 2020, 1:47 PM

Change 565707 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Pass a $user to Revision::newNullRevision

https://gerrit.wikimedia.org/r/565707

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.19; 2020-02-11); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 5 2020, 2:00 PM
gerritbot added a comment.Feb 13 2020, 1:26 AM

Change 565705 merged by jenkins-bot:
[mediawiki/core@master] Tests: pass a $user to Revision::newNullRevision & Wikipage::getContent

https://gerrit.wikimedia.org/r/565705

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.20; 2020-02-18); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 13 2020, 2:00 AM
gerritbot added a comment.Feb 13 2020, 5:28 AM

Change 565702 abandoned by DannyS712:
Add a user parameter to RecentChange::markPatrolled

Reason:
Replacing all callers instead

https://gerrit.wikimedia.org/r/565702

DannyS712 triaged this task as Medium priority.Feb 13 2020, 9:10 PM
DannyS712 mentioned this in T245331: Remove core fallbacks to global $wgUser [1.36].Feb 15 2020, 2:37 AM
DannyS712 mentioned this in T245482: Remove core fallbacks to global $wgUser [1.35].Feb 18 2020, 3:17 AM
DannyS712 closed subtask T244039: Api tests: Hard deprecate ApiTestCase::doLogin, remove calls in favor of passing a user where needed as Resolved.Feb 18 2020, 8:33 PM
DannyS712 removed a subtask: T155696: Replace Article::doEditContent() with WikiPage::doEditContent().Feb 19 2020, 1:10 AM
DannyS712 closed subtask T245233: FileDeleteForm uses $wgUser as Resolved.Feb 19 2020, 1:36 AM
DannyS712 added a subscriber: • Pchelolo.Feb 19 2020, 4:13 AM

@Pchelolo do you think you could take a look at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/563759/ please?

gerritbot added a comment.Feb 20 2020, 2:04 AM

Change 563759 merged by jenkins-bot:
[mediawiki/core@master] Deprecate falling back to $wgUser in some functions

https://gerrit.wikimedia.org/r/563759

DannyS712 closed subtask T243652: Calls to LogPage::addEntry should pass a user as Resolved.Feb 20 2020, 2:04 AM
gerritbot added a comment.Feb 20 2020, 4:48 AM

Change 573434 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate File::recordUpload (and LocalFile, ForeignDBFile)

https://gerrit.wikimedia.org/r/573434

DannyS712 closed subtask T243805: WebRequest::getLimitOffset should accept a user as Resolved.Feb 20 2020, 8:45 PM
DannyS712 closed subtask T245682: Deprecate calling FileDeleteForm::doDelete without passing a user as Resolved.Feb 21 2020, 4:54 AM
• Pchelolo closed subtask T245958: Revision::userCanBitfield falls back to $wgUser as Resolved.Feb 25 2020, 4:50 PM
DannyS712 closed subtask T245686: Hard deprecate old SpecialPageFactory as Resolved.Feb 25 2020, 6:19 PM
DannyS712 closed subtask T245195: Hard deprecate RecentChange::markPatrolled as Resolved.Feb 26 2020, 4:59 AM
DannyS712 closed subtask T244922: Hard deprecate Title user permission methods as Resolved.Feb 26 2020, 6:30 AM
• 1sollo25 added commits: rSVN34373: Also move the old files to the new hash path., rEWBA1f8242081535: Merge "Using the new Ruby Hash API", rMWb61dbaaf43ea: Also move the old files to the new hash path., rMW05abc5783865: Also move the old files to the new hash path., rEWBA85b38a78c24e: Merge "Use new Snak hash options in ResultBuilder", rEWBA49d6dd44a34f: Using the new Ruby Hash API, rEWBAa0d58a99c75f: Using the new Ruby Hash API, rWDQBa08a01f7a36f: BLZG-1304: new concept for pipelined hash index op, rODFM4e57dbdc26dc: Make GKE test firewalls work with new short-hash node names., rODCA8d1fbe4586c9: Code smell: Avoid explicit returns, rWBSERJS9e4bb6b42eac: Add support for serialization of snak hashes, rEMFRb699967ada66: limit hash changes by using replaceState (bug 36848), rEBHAc739616a2314: Added Table to store email-hash mappings ( EXPERIMENTAL ), rGSVTde8e41ba5d28: Update ToolforgeBundle and add version to footer, rMW284867638558: Create patch set 2, rMW16d4d37bb36d: Create patch set 3, rEWBAc180074b352e: Create patch set 4, rGVED0199103b6f28: Create patch set 2, rWEPDea1268f2c71f: - In order to be more stable, deletes one of the arguments that we were passing…, rEBHA024cfac93bd2: Added Table to store email-hash mappings ( EXPERIMENTAL ), rEWBA47e7d43e20bb: Create patch set 2, rODCA30f49bb28fd0: Resolving conflicts with ???, rMW6473c1569d4f: Update patch set 3, rGERRITf43d0c289baf: Reset location hash before file navigation, rMW6380cadedc57: Do not return invalid hash from ApiStashEdit, rMW139474af2c13: Do not return invalid hash from ApiStashEdit, rEWBA0270c7eca5b9: Add UnDeserializableValue to DataModelSerializationRoundtripTest, rEMMV3fab3120cbbf: Do not set up the overlay on irrelevant hash changes, rGERRIT26841bafe252: Reset location hash before file navigation, rEMMV572929049bb8: Do not set up the overlay on irrelevant hash changes, rGERRITe31f83d9eeeb: Reset location hash before file navigation, rGERRIT7ac7a55d5672: Reset location hash before file navigation, rEMMV6dddb2f7dbf5: Do not set up the overlay on irrelevant hash changes, rGERRITe4ff89a83b4e: Reset location hash before file navigation, rMW8b664986335c: Do not return invalid hash from ApiStashEdit, rGVEDae5c6a59aef9: Update notes for submitted changes, rEVED9fb6977e5205: Update VE core submodule to master (363adf2), rOSVV1b0acfb5a3d6: Use LRU hash for logline cache to avoid memory leak, rEVEDb8f6c3682aca: Update VE core submodule to master (363adf2), rEWBA2ed6ef1e0c2e: Update notes for submitted changes, rOSHD878ceb348c0e: Update Pear hash, rEWBAcc4982282cbd: Update notes for submitted changes, rWBDMJS97b8f3ba48dc: Add hash to Snak, rGERRIT6efa2b86396d: Introduce accountId field which is a new id (SHA-1 hash) for an Account., rGERRIT09bc4e3ff08f: Introduce accountId field which is a new id (SHA-1 hash) for an Account., rOPUP1c6ff43f1aa8: phabricator: don't assign a new hash key, rOSKU0c19b58df2f8: Make GKE test firewalls work with new short-hash node names., rWBDMJSd17091deb3ab: Add hash to Snak, rODFM0c19b58df2f8: Make GKE test firewalls work with new short-hash node names., rECITfc4788d51b93: Move originalDomElements to IV store and use new hash, rODCVd7f66f43f8f9: Add a new HSH_Insert() function which does that. Clean up the hash generation…, rMW1163c53226ad: API: new hash system, rODVRd7f66f43f8f9: Add a new HSH_Insert() function which does that. Clean up the hash generation…, rMW4e1fdde24737: API: new hash system, rMW7f0985b497a6: API: new hash system, rOPUP0ea2d6432627: phabricator: don't assign a new hash key, rOPUP23b24f3071ac: phabricator: don't assign a new hash key, rOPUPa8ab8d54a85b: phabricator: don't assign a new hash key, rWORGc11a23e115a1: + cool new library for hash change events * fix some more bugs with options…, rOSKUc3d905776eb7: Avoid comparing pod-template-hash when getting a deployment's new/old RSes, rODCV59caf963dce0: Exploit the new and cleaner director interface and add a "hash" director by…, rODVRcb5fa8b7cd34: Add a new paramter "purge_hash" which defaults to "off"., rOSKU6aaed13b2083: Avoid comparing pod-template-hash when getting a deployment's new/old RSes, rWEPD17cb13e18f84: - Adds new method that creates a hash with last_update and average_delay so…, rODVR59caf963dce0: Exploit the new and cleaner director interface and add a "hash" director by…, rODCVcb5fa8b7cd34: Add a new paramter "purge_hash" which defaults to "off"., rGVEDc13ca8c56d0d: GeneractedContentNode: Introduce new hash for rendering, rEWBA4e772ffdb0b4: Use new Snak hash options in ResultBuilder, rEWBAb15c73a2b522: Use new Snak hash options in ResultBuilder, rGVED7d3b35c1915f: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering, rEWBA9c1517c52d95: Use new Snak hash options in ResultBuilder, rEWBA0435760dabe3: Use new Snak hash options in ResultBuilder, rEWBAe46ca23a1cd3: Use new Snak hash options in ResultBuilder, rECIT20f6dd698f56: Move originalDomElements to IV store and use new hash, rEWBAff9b9996d9fd: Use new Snak hash options in ResultBuilder, rWDQB90d9d9412923: BLZG-1304: new concept for pipelined hash index op, rGVEDd156dd70297c: GeneractedContentNode: Introduce new hash for rendering, rODCV735793511568: Add a new HSH_Insert() function which does that. Clean up the hash generation…, rODVR735793511568: Add a new HSH_Insert() function which does that. Clean up the hash generation…, rODVR67022a338b0f: Exploit the new and cleaner director interface and add a "hash" director by…, rODVR8ed169727074: Add a new paramter "purge_hash" which defaults to "off"., rODCV67022a338b0f: Exploit the new and cleaner director interface and add a "hash" director by…, rODCV8ed169727074: Add a new paramter "purge_hash" which defaults to "off"., rOPUP3d78d4aef2fd: Switch dns ldap config to use new ldap hash, rSVN30353: * Changed from direct DB query to get password hash to creating a new User…, rGVEDb9c77879600b: GeneractedContentNode: Introduce new hash for rendering, rOSHD512ecad7cbda: Convert ext_hash function/methods to use new HNI bindings, rGVEDda4be99a2c03: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering, rEWBA20f0c236ee17: Using the new Ruby Hash API, rGVED63c5f67fc3b8: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering, rEWBAfad1847a9126: Using the new Ruby Hash API, rOSKU4e57dbdc26dc: Make GKE test firewalls work with new short-hash node names., rGSVT9ea74bf1c40d: Update ToolforgeBundle and add version to footer, rESMWf6956778b09e: Use md5() instead of hash_init() et al., rMEXTebaf36748708: Update git submodules, rMW64f5383796aa: Update patch set 1, rMWc26818a5fcaa: Use standard exceptions in ObjectCache and always handle CACHE_NONE/"hash", rEMFRaf44992d7e73: limit hash changes by using replaceState (bug 36848), rGSVT79b7a5abb0a6: Update ToolforgeBundle and add version to footer, rGVED363adf28cdc2: Merge "[BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering".Feb 26 2020, 6:43 AM
DannyS712 removed commits: rGVED363adf28cdc2: Merge "[BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering", rGSVT79b7a5abb0a6: Update ToolforgeBundle and add version to footer, rEMFRaf44992d7e73: limit hash changes by using replaceState (bug 36848), rMWc26818a5fcaa: Use standard exceptions in ObjectCache and always handle CACHE_NONE/"hash", rMW64f5383796aa: Update patch set 1, rMEXTebaf36748708: Update git submodules, rESMWf6956778b09e: Use md5() instead of hash_init() et al., rGSVT9ea74bf1c40d: Update ToolforgeBundle and add version to footer, rOSKU4e57dbdc26dc: Make GKE test firewalls work with new short-hash node names., rEWBAfad1847a9126: Using the new Ruby Hash API, rGVED63c5f67fc3b8: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering, rEWBA20f0c236ee17: Using the new Ruby Hash API, rGVEDda4be99a2c03: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering, rOSHD512ecad7cbda: Convert ext_hash function/methods to use new HNI bindings, rGVEDb9c77879600b: GeneractedContentNode: Introduce new hash for rendering, rSVN30353: * Changed from direct DB query to get password hash to creating a new User…, rOPUP3d78d4aef2fd: Switch dns ldap config to use new ldap hash, rODCV8ed169727074: Add a new paramter "purge_hash" which defaults to "off"., rODCV67022a338b0f: Exploit the new and cleaner director interface and add a "hash" director by…, rODVR8ed169727074: Add a new paramter "purge_hash" which defaults to "off"., rODVR67022a338b0f: Exploit the new and cleaner director interface and add a "hash" director by…, rODVR735793511568: Add a new HSH_Insert() function which does that. Clean up the hash generation…, rODCV735793511568: Add a new HSH_Insert() function which does that. Clean up the hash generation…, rGVEDd156dd70297c: GeneractedContentNode: Introduce new hash for rendering, rWDQB90d9d9412923: BLZG-1304: new concept for pipelined hash index op, rEWBAff9b9996d9fd: Use new Snak hash options in ResultBuilder, rECIT20f6dd698f56: Move originalDomElements to IV store and use new hash, rEWBAe46ca23a1cd3: Use new Snak hash options in ResultBuilder, rEWBA0435760dabe3: Use new Snak hash options in ResultBuilder, rEWBA9c1517c52d95: Use new Snak hash options in ResultBuilder, rGVED7d3b35c1915f: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering, rEWBAb15c73a2b522: Use new Snak hash options in ResultBuilder, rEWBA4e772ffdb0b4: Use new Snak hash options in ResultBuilder, rGVEDc13ca8c56d0d: GeneractedContentNode: Introduce new hash for rendering, rODCVcb5fa8b7cd34: Add a new paramter "purge_hash" which defaults to "off"., rODVR59caf963dce0: Exploit the new and cleaner director interface and add a "hash" director by…, rWEPD17cb13e18f84: - Adds new method that creates a hash with last_update and average_delay so…, rOSKU6aaed13b2083: Avoid comparing pod-template-hash when getting a deployment's new/old RSes, rODVRcb5fa8b7cd34: Add a new paramter "purge_hash" which defaults to "off"., rODCV59caf963dce0: Exploit the new and cleaner director interface and add a "hash" director by…, rOSKUc3d905776eb7: Avoid comparing pod-template-hash when getting a deployment's new/old RSes, rWORGc11a23e115a1: + cool new library for hash change events * fix some more bugs with options…, rOPUPa8ab8d54a85b: phabricator: don't assign a new hash key, rOPUP23b24f3071ac: phabricator: don't assign a new hash key, rOPUP0ea2d6432627: phabricator: don't assign a new hash key, rMW7f0985b497a6: API: new hash system, rMW4e1fdde24737: API: new hash system, rODVRd7f66f43f8f9: Add a new HSH_Insert() function which does that. Clean up the hash generation…, rMW1163c53226ad: API: new hash system, rODCVd7f66f43f8f9: Add a new HSH_Insert() function which does that. Clean up the hash generation…, rECITfc4788d51b93: Move originalDomElements to IV store and use new hash, rODFM0c19b58df2f8: Make GKE test firewalls work with new short-hash node names., rWBDMJSd17091deb3ab: Add hash to Snak, rOSKU0c19b58df2f8: Make GKE test firewalls work with new short-hash node names., rOPUP1c6ff43f1aa8: phabricator: don't assign a new hash key, rGERRIT09bc4e3ff08f: Introduce accountId field which is a new id (SHA-1 hash) for an Account., rGERRIT6efa2b86396d: Introduce accountId field which is a new id (SHA-1 hash) for an Account., rWBDMJS97b8f3ba48dc: Add hash to Snak, rEWBAcc4982282cbd: Update notes for submitted changes, rOSHD878ceb348c0e: Update Pear hash, rEWBA2ed6ef1e0c2e: Update notes for submitted changes, rEVEDb8f6c3682aca: Update VE core submodule to master (363adf2), rOSVV1b0acfb5a3d6: Use LRU hash for logline cache to avoid memory leak, rEVED9fb6977e5205: Update VE core submodule to master (363adf2), rGVEDae5c6a59aef9: Update notes for submitted changes, rMW8b664986335c: Do not return invalid hash from ApiStashEdit, rGERRITe4ff89a83b4e: Reset location hash before file navigation, rEMMV6dddb2f7dbf5: Do not set up the overlay on irrelevant hash changes, rGERRIT7ac7a55d5672: Reset location hash before file navigation, rGERRITe31f83d9eeeb: Reset location hash before file navigation, rEMMV572929049bb8: Do not set up the overlay on irrelevant hash changes, rGERRIT26841bafe252: Reset location hash before file navigation, rEMMV3fab3120cbbf: Do not set up the overlay on irrelevant hash changes, rEWBA0270c7eca5b9: Add UnDeserializableValue to DataModelSerializationRoundtripTest, rMW139474af2c13: Do not return invalid hash from ApiStashEdit, rMW6380cadedc57: Do not return invalid hash from ApiStashEdit, rGERRITf43d0c289baf: Reset location hash before file navigation, rMW6473c1569d4f: Update patch set 3, rODCA30f49bb28fd0: Resolving conflicts with ???, rEWBA47e7d43e20bb: Create patch set 2, rEBHA024cfac93bd2: Added Table to store email-hash mappings ( EXPERIMENTAL ), rWEPDea1268f2c71f: - In order to be more stable, deletes one of the arguments that we were passing…, rGVED0199103b6f28: Create patch set 2, rEWBAc180074b352e: Create patch set 4, rMW16d4d37bb36d: Create patch set 3, rMW284867638558: Create patch set 2, rGSVTde8e41ba5d28: Update ToolforgeBundle and add version to footer, rEBHAc739616a2314: Added Table to store email-hash mappings ( EXPERIMENTAL ), rEMFRb699967ada66: limit hash changes by using replaceState (bug 36848), rWBSERJS9e4bb6b42eac: Add support for serialization of snak hashes, rODCA8d1fbe4586c9: Code smell: Avoid explicit returns, rODFM4e57dbdc26dc: Make GKE test firewalls work with new short-hash node names., rWDQBa08a01f7a36f: BLZG-1304: new concept for pipelined hash index op, rEWBAa0d58a99c75f: Using the new Ruby Hash API, rEWBA49d6dd44a34f: Using the new Ruby Hash API, rEWBA85b38a78c24e: Merge "Use new Snak hash options in ResultBuilder", rMW05abc5783865: Also move the old files to the new hash path., rMWb61dbaaf43ea: Also move the old files to the new hash path., rEWBA1f8242081535: Merge "Using the new Ruby Hash API", rSVN34373: Also move the old files to the new hash path..Feb 26 2020, 7:16 PM
DannyS712 updated the task description. (Show Details)Feb 28 2020, 6:43 AM
DannyS712 closed subtask T246410: Deprecate LogEventsList::typeAction use of $wgUser as Resolved.Feb 28 2020, 6:48 AM
DannyS712 closed subtask T246409: Deprecate LogEventsList::getExcludeClause fallback to $wgUser as Resolved.Feb 28 2020, 6:50 AM
DannyS712 added a subtask: T247188: PageArchive::undelete falls back to $wgUser.Mar 8 2020, 7:44 AM
DannyS712 closed subtask T246189: Follow up: Hard deprecate not passing a user to ::userCan methods as Resolved.Mar 17 2020, 12:18 AM
DannyS712 closed subtask T247188: PageArchive::undelete falls back to $wgUser as Resolved.Mar 20 2020, 6:39 PM
DannyS712 closed subtask T245710: LocalFileDeleteBatch accepts an optional user, falls back to $wgUser as Resolved.Mar 23 2020, 5:04 PM
DannyS712 closed subtask T246738: WikiPage::doDeleteArticleReal falls back to $wgUser as Resolved.Mar 31 2020, 4:12 AM
DannyS712 added a subtask: T250638: Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus.Apr 20 2020, 12:11 AM
Huji closed subtask T246861: Deprecate not passing a user to ParserOptions::__construct and ::newCanonical as Resolved.May 11 2020, 2:44 PM
DannyS712 reopened subtask T246861: Deprecate not passing a user to ParserOptions::__construct and ::newCanonical as Open.May 11 2020, 2:45 PM
DannyS712 closed subtask T250638: Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus as Declined.Jun 9 2020, 9:49 PM
DannyS712 closed subtask T248813: File::recordUpload* falls back to $wgUser as Resolved.Sep 11 2020, 6:14 PM
DannyS712 mentioned this in T262707: Remove core fallbacks to global $wgUser [1.37].Sep 11 2020, 6:20 PM
gerritbot added a comment.Sep 15 2020, 12:46 AM

Change 573434 abandoned by DannyS712:
[mediawiki/core@master] Add missing File::recordUpload2, hard deprecate File::recordUpload

Reason:
done separately already

https://gerrit.wikimedia.org/r/573434

DannyS712 closed subtask T246862: Language::dateFormat and ::userAdjust use $wgUser as Resolved.Sep 15 2020, 1:39 AM
DannyS712 reopened subtask T248813: File::recordUpload* falls back to $wgUser as Open.Sep 24 2020, 11:39 PM
DannyS712 closed subtask T248813: File::recordUpload* falls back to $wgUser as Resolved.Sep 27 2020, 1:33 AM
DannyS712 closed subtask T254702: GenderCache::getGenderOf uses $wgUser as Resolved.Sep 29 2020, 8:00 PM
DannyS712 closed subtask T246861: Deprecate not passing a user to ParserOptions::__construct and ::newCanonical as Resolved.Dec 16 2020, 4:28 PM
DannyS712 closed subtask T246735: UploadStash accepts an optional user parameter and defaults to $wgUser as Resolved.Dec 18 2020, 7:36 PM
DannyS712 mentioned this in T285731: Remove core fallbacks to global $wgUser [1.39].Jun 29 2021, 1:42 AM
DannyS712 closed subtask T285447: Deprecate WikiPage::prepareContentForEdit() fallback to $wgUser as Resolved.Jun 29 2021, 1:45 AM
DannyS712 closed subtask T255507: WikiPage::doEditContent falls back to $wgUser as Resolved.Jul 4 2021, 12:08 AM
DannyS712 reopened subtask T285447: Deprecate WikiPage::prepareContentForEdit() fallback to $wgUser as Open.Jul 4 2021, 6:03 AM
DannyS712 closed subtask T285447: Deprecate WikiPage::prepareContentForEdit() fallback to $wgUser as Resolved.Jul 4 2021, 6:13 AM
DannyS712 closed this task as Resolved.May 26 2022, 1:50 AM
DannyS712 removed projects: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review.

Forgot to resolve this back in 1.37, all core uses of $wgUser were deprecated, and the default value was a StubGlobalObject so that deprecation warnings would be emitted from trying to use it

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL