Page MenuHomePhabricator
Create Task
Maniphest T247259

Remove remaining calls and hard deprecate Revision::userCan
Closed, ResolvedPublic
Actions

Description

Current calls to replace:

Details

SubjectRepoBranchLines +/-
Stop using Revision::userCanmediawiki/extensions/Videomaster+15 -3
Hard deprecate Revision::userCanmediawiki/coremaster+174 -43
Stop using Revision::userCanmediawiki/extensions/RevisionCommentSupplementmaster+7 -1
Stop using Revision::userCanmediawiki/extensions/MobileFrontendmaster+44 -11
Stop using Revision::userCanmediawiki/extensions/Wikibasemaster+5 -1
Stop using Revision::userCanmediawiki/extensions/MassMessagemaster+6 -1
Stop using Revision::userCanmediawiki/extensions/GlobalContribsmaster+13 -2
Stop using Revision::userCanmediawiki/extensions/ChangeAuthormaster+7 -1
Stop using Revision::userCanmediawiki/extensions/CheckUsermaster+12 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Mar 9 2020, 5:52 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 9 2020, 5:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 added projects: MobileFrontend, MediaWiki-extensions-WikibaseRepository, CheckUser, MassMessage, Video extension, MediaWiki-extensions-Other, GlobalContribs, MediaWiki-extensions-RevisionCommentSupplement.Mar 9 2020, 5:53 PM
DannyS712 moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.
Restricted Application added projects: Social-Tools, Wikidata. · View Herald TranscriptMar 9 2020, 5:53 PM
DannyS712 moved this task from Backlog to team:other on the MobileFrontend board.Mar 9 2020, 5:53 PM
DannyS712 moved this task from Backlog to Doing (In progress) on the MassMessage board.
DannyS712 moved this task from Backlog to Video on the Social-Tools board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 added parent tasks: T246189: Follow up: Hard deprecate not passing a user to ::userCan methods, T246284: Hard deprecate the Revision class.
DannyS712 added a comment.Mar 10 2020, 9:36 PM

https://codesearch.wmflabs.org/search/?q=-%3EuserCan%5C(&i=nope&files=%5C.php%24&repos=Extension:ChangeAuthor,Extension:CheckUser,Extension:GlobalContribs,Extension:MassMessage,Extension:MobileFrontend,Extension:RevisionCommentSupplement,Extension:Video,Extension:Wikibase

gerritbot added a comment.Mar 10 2020, 9:37 PM

Change 578610 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578610

gerritbot added a project: Patch-For-Review.Mar 10 2020, 9:37 PM
gerritbot added a comment.Mar 10 2020, 9:47 PM

Change 578612 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578612

gerritbot added a comment.Mar 10 2020, 9:48 PM

Change 578615 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CheckUser@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578615

gerritbot added a comment.Mar 10 2020, 9:52 PM

Change 578616 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578616

gerritbot added a comment.Mar 10 2020, 9:54 PM

Change 578618 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalContribs@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578618

gerritbot added a comment.Mar 10 2020, 9:57 PM

Change 578619 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ChangeAuthor@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578619

gerritbot added a comment.Mar 11 2020, 1:25 AM

Change 578662 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/RevisionCommentSupplement@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578662

gerritbot added a comment.Mar 11 2020, 1:25 AM

Change 578663 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Video@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578663

gerritbot added a comment.Mar 11 2020, 1:29 AM

Change 578615 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578615

DannyS712 renamed this task from Hard deprecate Revision::userCan to Remove remaining calls and hard deprecate Revision::userCan.Mar 11 2020, 1:38 AM
gerritbot added a comment.Mar 11 2020, 1:38 AM

Change 578612 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578612

gerritbot added a comment.Mar 11 2020, 1:38 AM

Change 578616 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578616

gerritbot added a comment.Mar 11 2020, 1:38 AM

Change 578619 merged by jenkins-bot:
[mediawiki/extensions/ChangeAuthor@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578619

gerritbot added a comment.Mar 11 2020, 1:38 AM

Change 578618 merged by jenkins-bot:
[mediawiki/extensions/GlobalContribs@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578618

gerritbot added a comment.Mar 11 2020, 1:38 AM

Change 578610 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578610

DannyS712 updated the task description. (Show Details)Mar 11 2020, 1:39 AM

Given that neither of the 2 extensions that haven't been updated are deployed, sending a patch to hard deprecate

gerritbot added a comment.Mar 11 2020, 1:41 AM

Change 578664 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::userCan

https://gerrit.wikimedia.org/r/578664

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 11 2020, 2:01 AM
DannyS712 mentioned this in rEGCN9011667f2f65: Stop using Revision::userCan.Mar 11 2020, 2:03 AM
DannyS712 triaged this task as Medium priority.Mar 11 2020, 2:09 AM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Mar 11 2020, 2:45 AM

Change 578662 merged by jenkins-bot:
[mediawiki/extensions/RevisionCommentSupplement@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578662

DannyS712 updated the task description. (Show Details)Mar 11 2020, 2:49 AM
gerritbot added a comment.Mar 11 2020, 2:58 AM

Change 578664 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::userCan

https://gerrit.wikimedia.org/r/578664

gerritbot added a comment.Mar 12 2020, 11:44 AM

Change 578663 merged by Jack Phoenix:
[mediawiki/extensions/Video@master] Stop using Revision::userCan

https://gerrit.wikimedia.org/r/578663

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2020, 12:10 PM
DannyS712 closed this task as Resolved.Mar 12 2020, 3:44 PM
DannyS712 mentioned this in T247143: Remove the Revision class [1.37].
DannyS712 updated the task description. (Show Details)Mar 13 2020, 6:14 AM
DannyS712 added a subtask: T246414: Audit all userCan calls.Mar 16 2020, 11:58 PM
DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].Apr 26 2020, 11:37 PM
DannyS712 removed a parent task: T246284: Hard deprecate the Revision class.Apr 26 2020, 11:39 PM
DannyS712 added a parent task: T251067: Hard deprecate individual Revision class methods [tracking].
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL