File::recordUpload* falls back to $wgUser
Closed, ResolvedPublic
Actions

Description

Currently

LocalFile::recordUpload falls back to $wgUser, and is a wrapper for ::recordUpload2
LocalFile::recordUpload2 falls back to $wgUser

Proposal:

Since ::recordUpload is unused, hard deprecate it
Add ::recordUpload3 requiring a user to be passed, and convert 2 into a soft deprecated wrapper for 3
Replace deployed uses of 2 with 3, ensuring a user is always passed
Hard deprecate 2

Details

	Subject	Repo	Branch	Lines +/-
	Use recordUpload3, hard deprecate recordUpload2	mediawiki/core	master	+135 -82
	Files: Hard deprecate recordUpload, soft deprecate 2, add recordUpload3	mediawiki/core	master	+44 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T242935 Deprecate core fallbacks to $wgUser
Resolved	DannyS712	T248813 File::recordUpload* falls back to $wgUser
Resolved	DannyS712	T263811 LocalFile::upload without a user fails in ::recordUpload3

Event Timeline

DannyS712 created this task.Mar 30 2020, 5:04 AM

Restricted Application added a project: Commons. · View Herald TranscriptMar 30 2020, 5:04 AM

DannyS712 triaged this task as Medium priority.Mar 30 2020, 5:04 AM

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 584287 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Files: Hard deprecate recordUpload, add recordUpload3

https://gerrit.wikimedia.org/r/584287

gerritbot added a project: Patch-For-Review.Mar 30 2020, 5:05 AM

Change 584287 merged by jenkins-bot:
[mediawiki/core@master] Files: Hard deprecate recordUpload, soft deprecate 2, add recordUpload3

https://gerrit.wikimedia.org/r/584287

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 16 2020, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 16 2020, 1:11 AM

Change 605715 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Use recordUpload3, hard deprecate recordUpload2

https://gerrit.wikimedia.org/r/605715

gerritbot added a project: Patch-For-Review.Jun 16 2020, 1:45 AM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Jun 16 2020, 1:55 AM

Change 605715 merged by jenkins-bot:
[mediawiki/core@master] Use recordUpload3, hard deprecate recordUpload2

https://gerrit.wikimedia.org/r/605715

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 11 2020, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2020, 6:10 PM

DannyS712 closed this task as Resolved.Sep 11 2020, 6:14 PM

DannyS712 mentioned this in T262706: Remove File::recordUpload.

DannyS712 mentioned this in T262708: Remove LocalFile::recordUpload2.Sep 11 2020, 6:22 PM

DannyS712 reopened this task as Open.Sep 24 2020, 11:39 PM

DannyS712 added a subtask: T263811: LocalFile::upload without a user fails in ::recordUpload3.