Page MenuHomePhabricator
Create Task
Maniphest T262708

Remove LocalFile::recordUpload2
Closed, ResolvedPublic
Actions

Description

Hard deprecated in 1.36 (T248813: File::recordUpload* falls back to $wgUser), no deployed uses, see https://codesearch.wmcloud.org/deployed/?q=recordUpload2%5C(&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Remove LocalFile::recordUpload2mediawiki/coremaster+1 -31
Replace deprecated LocalFile::recordUpload2mediawiki/extensions/PageExchangemaster+19 -8
Replace deprecated LocalFile::recordUpload2mediawiki/extensions/BlueSpiceFoundationmaster+3 -1
Replace deprecated LocalFile::recordUpload2mediawiki/extensions/BlueSpiceContextMenumaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 changed the task status from Open to Stalled.Sep 11 2020, 6:22 PM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 moved this task from Untriaged to Not yet on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to Later on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)

Cannot be actioned until 1.37

DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Sep 11 2020, 7:13 PM
gerritbot added a comment.Dec 7 2020, 4:12 PM

Change 646748 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/PageExchange@master] Replace deprecated LocalFile::recordUpload2

https://gerrit.wikimedia.org/r/646748

gerritbot added a project: Patch-For-Review.Dec 7 2020, 4:12 PM
gerritbot added a comment.Dec 7 2020, 4:15 PM

Change 646749 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/BlueSpiceContextMenu@master] Replace deprecated LocalFile::recordUpload2

https://gerrit.wikimedia.org/r/646749

gerritbot added a comment.Dec 7 2020, 4:18 PM

Change 646750 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated LocalFile::recordUpload2

https://gerrit.wikimedia.org/r/646750

gerritbot added a comment.Dec 8 2020, 3:20 AM

Change 646749 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceContextMenu@master] Replace deprecated LocalFile::recordUpload2

https://gerrit.wikimedia.org/r/646749

Umherirrender mentioned this in rEBTBe8c67141b772: Replace deprecated LocalFile::recordUpload2.Dec 8 2020, 3:28 AM
gerritbot added a comment.Dec 10 2020, 6:53 AM

Change 646750 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated LocalFile::recordUpload2

https://gerrit.wikimedia.org/r/646750

gerritbot added a comment.Dec 12 2020, 4:11 AM

Change 646748 merged by jenkins-bot:
[mediawiki/extensions/PageExchange@master] Replace deprecated LocalFile::recordUpload2

https://gerrit.wikimedia.org/r/646748

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2020, 5:10 AM
DannyS712 changed the task status from Stalled to Open.Jun 15 2021, 7:03 AM
DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Jun 15 2021, 7:03 AM

Change 699849 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Remove LocalFile::recordUpload2

https://gerrit.wikimedia.org/r/699849

gerritbot added a project: Patch-For-Review.Jun 15 2021, 7:03 AM
DannyS712 moved this task from Not yet to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.Jun 15 2021, 7:04 AM
DannyS712 added a project: Platform Team Workboards (External Code Reviews).
gerritbot added a comment.Jun 15 2021, 6:19 PM

Change 699849 merged by jenkins-bot:

[mediawiki/core@master] Remove LocalFile::recordUpload2

https://gerrit.wikimedia.org/r/699849

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 15 2021, 7:00 PM
DannyS712 closed this task as Resolved.Jun 16 2021, 1:07 AM
DannyS712 removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits