Page MenuHomePhabricator

Hard deprecate Article::doDeleteArticle and WikiPage::doDeleteArticle
Closed, ResolvedPublic

Description

I failed to realize it when updating WikiPage::doDeleteArticleReal, but the ::doDeleteArticle methods simply proxy ::doDeleteArticleReal and return whether the status isOk().

The documentation says Same as doDeleteArticleReal(), but returns a simple boolean. This is kept around for backwards compatibility, if you care about error reporting you should use doDeleteArticleReal() instead.

Any objections to deprecating the method entirely in favor of the caller checking isOK on the result of doDeleteArticleReal?

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+13 -5
mediawiki/coremaster+39 -21
mediawiki/coremaster+31 -15
mediawiki/extensions/PhpTagsStoragemaster+21 -3
mediawiki/extensions/WikimediaMaintenancemaster+3 -3
mediawiki/extensions/CreatedPagesListmaster+13 -2
mediawiki/extensions/DeleteBatchmaster+7 -3
mediawiki/extensions/MintyDocsmaster+5 -1
mediawiki/extensions/LiquidThreadsmaster+4 -4
mediawiki/extensions/PictureGamemaster+18 -4
mediawiki/extensions/PollNYmaster+10 -2
mediawiki/extensions/TranslateSvgmaster+3 -2
mediawiki/extensions/UserMergemaster+32 -21
mediawiki/extensions/PageTriagemaster+8 -1
mediawiki/extensions/Cognatemaster+12 -2
mediawiki/extensions/Jademaster+5 -2
mediawiki/extensions/Wikibasemaster+7 -5
mediawiki/extensions/BlueSpiceGroupManagermaster+1 -6
mediawiki/extensions/BlueSpiceFoundationmaster+14 -2
mediawiki/extensions/ActiveAbstractmaster+9 -1
mediawiki/extensions/CentralNoticemaster+1 -1
mediawiki/extensions/Nukemaster+5 -5
mediawiki/extensions/BlueSpiceAvatarsmaster+3 -2
mediawiki/extensions/BlueSpiceBookshelfUImaster+6 -6
Show related patches Customize query in gerrit

Event Timeline

DannyS712 created this task.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
Pchelolo added a subscriber: Pchelolo.

Any objections to deprecating the method entirely in favor of the caller checking isOK on the result of doDeleteArticleReal?

No objections.

Moving it to 'review needed' cause I guess there will be patches popping up soon.

Article: Use $article->getPage()->doDeleteArticleReal( ---new signature--- )->isOK()
WikiPage: Use $page->doDeleteArticleReal( ---new signature--- )->isOK()
Code search: https://codesearch.wmflabs.org/search/?q=-%3EdoDeleteArticle%5C(&i=nope&files=&repos=

Change 581045 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ActiveAbstract@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581045

Change 581050 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceAvatars@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581050

Change 581051 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceBookshelfUI@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581051

Change 581051 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceBookshelfUI@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581051

Change 581050 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceAvatars@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581050

Change 581619 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581619

Change 581620 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Nuke@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581620

Change 581619 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581619

Change 581620 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581620

Change 581045 merged by jenkins-bot:
[mediawiki/extensions/ActiveAbstract@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/581045

Change 582596 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceFoundation@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582596

Change 582597 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceGroupManager@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582597

Change 582598 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582598

Change 582596 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582596

Change 582597 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceGroupManager@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582597

Change 582598 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582598

Change 582902 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMaintenance@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582902

Change 582903 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582903

Change 582904 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582904

Change 582905 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Cognate@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582905

Change 582906 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UserMerge@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582906

Change 582904 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582904

Change 582903 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582903

Change 582905 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582905

Change 582911 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TranslateSvg@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582911

Change 582906 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582906

Change 582911 merged by Ppchelko:
[mediawiki/extensions/TranslateSvg@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582911

Change 583195 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PollNY@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583195

Change 583196 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PictureGame@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583196

Change 583197 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583197

Change 583198 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PhpTagsStorage@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583198

Change 583200 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MintyDocs@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583200

Change 583201 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/DeleteBatch@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583201

Change 583202 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CreatedPagesList@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583202

Change 583195 merged by jenkins-bot:
[mediawiki/extensions/PollNY@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583195

Change 583196 merged by jenkins-bot:
[mediawiki/extensions/PictureGame@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583196

Change 583197 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583197

Change 583200 merged by jenkins-bot:
[mediawiki/extensions/MintyDocs@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583200

Change 583201 merged by jenkins-bot:
[mediawiki/extensions/DeleteBatch@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583201

Change 583202 merged by jenkins-bot:
[mediawiki/extensions/CreatedPagesList@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583202

Change 583388 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Tests: Replace ::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583388

Change 583390 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Maintenance: Change ::doDeleteArticle to WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583390

Change 582902 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582902

Change 583198 merged by Ppchelko:
[mediawiki/extensions/PhpTagsStorage@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583198

Change 583390 merged by jenkins-bot:
[mediawiki/core@master] Maintenance: Change ::doDeleteArticle to WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583390

Change 583388 merged by jenkins-bot:
[mediawiki/core@master] Tests: Replace ::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583388

Change 583419 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article:doDeleteArticle and WikiPage::doDeleteArticle

https://gerrit.wikimedia.org/r/583419

Change 583419 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article:doDeleteArticle and WikiPage::doDeleteArticle

https://gerrit.wikimedia.org/r/583419

Zabe renamed this task from Hard deprecate Article:doDeleteArticle and WikiPage::doDeleteArticle to Hard deprecate Article::doDeleteArticle and WikiPage::doDeleteArticle.Mar 7 2021, 12:50 PM