Page MenuHomePhabricator
Create Task
Maniphest T248000

Hard deprecate Article::doDeleteArticle and WikiPage::doDeleteArticle
Closed, ResolvedPublic
Actions

Description

I failed to realize it when updating WikiPage::doDeleteArticleReal, but the ::doDeleteArticle methods simply proxy ::doDeleteArticleReal and return whether the status isOk().

The documentation says Same as doDeleteArticleReal(), but returns a simple boolean. This is kept around for backwards compatibility, if you care about error reporting you should use doDeleteArticleReal() instead.

Any objections to deprecating the method entirely in favor of the caller checking isOK on the result of doDeleteArticleReal?

Details

SubjectRepoBranchLines +/-
Hard deprecate Article:doDeleteArticle and WikiPage::doDeleteArticlemediawiki/coremaster+13 -5
Tests: Replace ::doDeleteArticle with WikiPage::doDeleteArticleRealmediawiki/coremaster+39 -21
Maintenance: Change ::doDeleteArticle to WikiPage::doDeleteArticleRealmediawiki/coremaster+31 -15
Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+mediawiki/extensions/PhpTagsStoragemaster+21 -3
Replace WikiPage::doDeleteArticle with ::doDeleteArticleRealmediawiki/extensions/WikimediaMaintenancemaster+3 -3
Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+mediawiki/extensions/CreatedPagesListmaster+13 -2
Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+mediawiki/extensions/DeleteBatchmaster+7 -3
Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+mediawiki/extensions/MintyDocsmaster+5 -1
Replace Article::doDeleteArticle with WikiPage::doDeleteArticleRealmediawiki/extensions/LiquidThreadsmaster+4 -4
Replace Article::doDeleteArticle with WikiPage::doDeleteArticleRealmediawiki/extensions/PictureGamemaster+18 -4
Replace Article::doDeleteArticle with WikiPage::doDeleteArticleRealmediawiki/extensions/PollNYmaster+10 -2
Replace WikiPage::doDeleteArticle with ::doDeleteArticleRealmediawiki/extensions/TranslateSvgmaster+3 -2
Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+mediawiki/extensions/UserMergemaster+32 -21
Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+mediawiki/extensions/PageTriagemaster+8 -1
Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+mediawiki/extensions/Cognatemaster+12 -2
Replace WikiPage::doDeleteArticle with ::doDeleteArticleRealmediawiki/extensions/Jademaster+5 -2
Replace WikiPage::doDeleteArticle with ::doDeleteArticleRealmediawiki/extensions/Wikibasemaster+7 -5
Replace WikiPage::doDeleteArticle with ::doDeleteArticleRealmediawiki/extensions/BlueSpiceGroupManagermaster+1 -6
Replace Article::doDeleteArticle with WikiPage::doDeleteArticleRealmediawiki/extensions/BlueSpiceFoundationmaster+14 -2
Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+mediawiki/extensions/ActiveAbstractmaster+9 -1
Replace WikiPage::doDeleteArticle with ::doDeleteArticleRealmediawiki/extensions/CentralNoticemaster+1 -1
Replace WikiPage::doDeleteArticle with ::doDeleteArticleRealmediawiki/extensions/Nukemaster+5 -5
Replace WikiPage::doDeleteArticle with ::doDeleteArticleRealmediawiki/extensions/BlueSpiceAvatarsmaster+3 -2
Replace Article::doDeleteArticle with WikiPage::doDeleteArticleRealmediawiki/extensions/BlueSpiceBookshelfUImaster+6 -6
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as High priority.Mar 18 2020, 4:22 PM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
• Pchelolo edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Mar 18 2020, 5:22 PM
• Pchelolo subscribed.

Any objections to deprecating the method entirely in favor of the caller checking isOK on the result of doDeleteArticleReal?

No objections.

• Pchelolo added a comment.Mar 18 2020, 5:22 PM

Moving it to 'review needed' cause I guess there will be patches popping up soon.

• Pchelolo moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Mar 18 2020, 5:22 PM
DannyS712 added a parent task: T239975: Complete WikiPage/Article split and deprecate Page interface.Mar 18 2020, 5:36 PM

Article: Use $article->getPage()->doDeleteArticleReal( ---new signature--- )->isOK()
WikiPage: Use $page->doDeleteArticleReal( ---new signature--- )->isOK()
Code search: https://codesearch.wmflabs.org/search/?q=-%3EdoDeleteArticle%5C(&i=nope&files=&repos=

gerritbot added a comment.Mar 18 2020, 6:43 PM

Change 581045 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ActiveAbstract@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581045

gerritbot added a project: Patch-For-Review.Mar 18 2020, 6:43 PM
gerritbot added a comment.Mar 18 2020, 6:47 PM

Change 581050 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceAvatars@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581050

gerritbot added a comment.Mar 18 2020, 6:48 PM

Change 581051 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceBookshelfUI@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581051

gerritbot added a comment.Mar 19 2020, 2:42 PM

Change 581051 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceBookshelfUI@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581051

gerritbot added a comment.Mar 19 2020, 2:49 PM

Change 581050 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceAvatars@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581050

DannyS712 mentioned this in T247869: Hard deprecate old signature in WikiPage::doDeleteArticleReal.Mar 19 2020, 3:24 PM
gerritbot added a comment.Mar 19 2020, 3:27 PM

Change 581619 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581619

gerritbot added a comment.Mar 19 2020, 3:31 PM

Change 581620 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Nuke@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581620

gerritbot added a comment.Mar 19 2020, 5:29 PM

Change 581619 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581619

gerritbot added a comment.Mar 19 2020, 5:29 PM

Change 581620 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/581620

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 19 2020, 8:49 PM
gerritbot added a comment.Mar 20 2020, 1:54 AM

Change 581045 merged by jenkins-bot:
[mediawiki/extensions/ActiveAbstract@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/581045

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2020, 2:10 AM
gerritbot added a comment.Mar 22 2020, 10:15 PM

Change 582596 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceFoundation@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582596

gerritbot added a project: Patch-For-Review.Mar 22 2020, 10:15 PM
gerritbot added a comment.Mar 22 2020, 10:19 PM

Change 582597 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceGroupManager@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582597

gerritbot added a comment.Mar 22 2020, 10:30 PM

Change 582598 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582598

gerritbot added a comment.Mar 23 2020, 5:22 PM

Change 582596 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582596

gerritbot added a comment.Mar 23 2020, 5:22 PM

Change 582597 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceGroupManager@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582597

gerritbot added a comment.Mar 23 2020, 7:13 PM

Change 582598 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582598

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2020, 8:10 PM
gerritbot added a comment.Mar 23 2020, 8:32 PM

Change 582902 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMaintenance@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582902

gerritbot added a project: Patch-For-Review.Mar 23 2020, 8:32 PM
gerritbot added a comment.Mar 23 2020, 8:35 PM

Change 582903 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582903

gerritbot added a comment.Mar 23 2020, 8:37 PM

Change 582904 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582904

gerritbot added a comment.Mar 23 2020, 8:46 PM

Change 582905 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Cognate@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582905

gerritbot added a comment.Mar 23 2020, 8:50 PM

Change 582906 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UserMerge@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582906

gerritbot added a comment.Mar 23 2020, 8:53 PM

Change 582904 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582904

gerritbot added a comment.Mar 23 2020, 8:53 PM

Change 582903 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582903

gerritbot added a comment.Mar 23 2020, 8:55 PM

Change 582905 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582905

gerritbot added a comment.Mar 23 2020, 9:07 PM

Change 582911 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TranslateSvg@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582911

gerritbot added a comment.Mar 23 2020, 9:09 PM

Change 582906 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/582906

gerritbot added a comment.Mar 23 2020, 9:37 PM

Change 582911 merged by Ppchelko:
[mediawiki/extensions/TranslateSvg@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582911

gerritbot added a comment.Mar 25 2020, 3:38 AM

Change 583195 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PollNY@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583195

gerritbot added a comment.Mar 25 2020, 3:41 AM

Change 583196 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PictureGame@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583196

gerritbot added a comment.Mar 25 2020, 3:46 AM

Change 583197 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583197

gerritbot added a comment.Mar 25 2020, 3:51 AM

Change 583198 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PhpTagsStorage@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583198

gerritbot added a comment.Mar 25 2020, 3:57 AM

Change 583200 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MintyDocs@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583200

gerritbot added a comment.Mar 25 2020, 4:00 AM

Change 583201 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/DeleteBatch@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583201

gerritbot added a comment.Mar 25 2020, 4:02 AM

Change 583202 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CreatedPagesList@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583202

gerritbot added a comment.Mar 25 2020, 2:13 PM

Change 583195 merged by jenkins-bot:
[mediawiki/extensions/PollNY@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583195

gerritbot added a comment.Mar 25 2020, 2:13 PM

Change 583196 merged by jenkins-bot:
[mediawiki/extensions/PictureGame@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583196

gerritbot added a comment.Mar 25 2020, 2:13 PM

Change 583197 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583197

gerritbot added a comment.Mar 25 2020, 2:15 PM

Change 583200 merged by jenkins-bot:
[mediawiki/extensions/MintyDocs@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583200

gerritbot added a comment.Mar 25 2020, 2:28 PM

Change 583201 merged by jenkins-bot:
[mediawiki/extensions/DeleteBatch@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583201

gerritbot added a comment.Mar 25 2020, 2:28 PM

Change 583202 merged by jenkins-bot:
[mediawiki/extensions/CreatedPagesList@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583202

DannyS712 mentioned this in rEDBA1505b8bfe591: Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+.Mar 25 2020, 2:33 PM
DannyS712 mentioned this in rEPGA892f26d7a83d: Replace Article::doDeleteArticle with WikiPage::doDeleteArticleReal.Mar 25 2020, 2:44 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.26; 2020-03-31); removed MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 25 2020, 3:00 PM
gerritbot added a comment.Mar 25 2020, 5:05 PM

Change 583388 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Tests: Replace ::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583388

gerritbot added a comment.Mar 25 2020, 5:21 PM

Change 583390 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Maintenance: Change ::doDeleteArticle to WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583390

gerritbot added a comment.Mar 25 2020, 6:36 PM

Change 582902 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal

https://gerrit.wikimedia.org/r/582902

gerritbot added a comment.Mar 25 2020, 6:58 PM

Change 583198 merged by Ppchelko:
[mediawiki/extensions/PhpTagsStorage@master] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583198

gerritbot added a comment.Mar 25 2020, 7:11 PM

Change 583390 merged by jenkins-bot:
[mediawiki/core@master] Maintenance: Change ::doDeleteArticle to WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583390

gerritbot added a comment.Mar 25 2020, 7:16 PM

Change 583388 merged by jenkins-bot:
[mediawiki/core@master] Tests: Replace ::doDeleteArticle with WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/583388

gerritbot added a comment.Mar 25 2020, 7:23 PM

Change 583419 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article:doDeleteArticle and WikiPage::doDeleteArticle

https://gerrit.wikimedia.org/r/583419

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Mar 25 2020, 7:28 PM
gerritbot added a comment.Mar 25 2020, 8:01 PM

Change 583419 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article:doDeleteArticle and WikiPage::doDeleteArticle

https://gerrit.wikimedia.org/r/583419

DannyS712 closed this task as Resolved.Mar 25 2020, 8:09 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:32 AM
Reedy mentioned this in T263330: Call to undeclared method WikiPage::doDeleteArticle.Sep 19 2020, 5:20 PM
Zabe renamed this task from Hard deprecate Article:doDeleteArticle and WikiPage::doDeleteArticle to Hard deprecate Article::doDeleteArticle and WikiPage::doDeleteArticle.Mar 7 2021, 12:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL