Page MenuHomePhabricator
Create Task
Maniphest T247869

Hard deprecate old signature in WikiPage::doDeleteArticleReal
Closed, ResolvedPublic
Actions

Description

Per parent task

Core

  • Translate:
  • SpecialManageTranslatorSandbox: WikiPage
  • TranslateDeleteJob: WikiPage
  • AbuseFilter: AbuseFilterConsequencesTest - WikiPage
  • BlueSpiceSocialProfile: Handler - WikiPage
  • CirrusSearch: deleteBrowserTestPages - WikiPage
  • CommentStreams: Comment - WikiPage
  • Flow: FlowRestoreLQT - WikiPage
  • GlobalCssJs: removeOldManualUserPages - WikiPage
  • Jade: CleanJudgmentLinksTest - WikiPage
  • MassMessage: MassMessageJobTest - WikiPage
  • SplitPrivateWiki: SyncArticleJob - WikiPage
  • Thanks: ApiCoreThankIntegrationTest - WikiPage x2
  • WebDAV: WebDAVPageFile - WikiPage

Actual hard deprecation is next

Details

SubjectRepoBranchLines +/-
PageDumpTestDataTrait: Pass a user to WikiPage::doDeleteArticleRealmediawiki/coremaster+3 -2
Hard deprecate old signature for WikiPage::doDeleteArticleRealmediawiki/coremaster+26 -14
Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+mediawiki/extensions/WebDAVmaster+10 -4
Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+mediawiki/extensions/SplitPrivateWikimaster+13 -2
Pass a user to WikiPage::doDeleteArticleReal, use new signaturemediawiki/extensions/BlueSpiceSocialProfilemaster+4 -3
Use new signature for WikiPage::doDeleteArticleReal, require MW 1.35+mediawiki/extensions/CirrusSearchmaster+4 -2
Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+mediawiki/extensions/Translatemaster+40 -11
Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+mediawiki/extensions/CommentStreamsmaster+21 -9
Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+mediawiki/extensions/Thanksmaster+20 -11
Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+mediawiki/extensions/GlobalCssJsmaster+0 -0
ApiDelete: Make ::delete(File)? only accept a wikipage, make privatemediawiki/coremaster+16 -6
Pass a user to WikiPage::doDeleteArticleReal, use new signaturemediawiki/coremaster+26 -17
Pass a user to WikiPage::doDeleteArticleReal, use new signaturemediawiki/extensions/Flowmaster+11 -3
Pass a user to WikiPage::doDeleteArticleReal, use new signaturemediawiki/extensions/Jademaster+2 -1
Pass a user to WikiPage::doDeleteArticleReal, use new signaturemediawiki/extensions/MassMessagemaster+1 -1
Pass a user to WikiPage::doDeleteArticleReal, use new signaturemediawiki/extensions/AbuseFiltermaster+4 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Mar 17 2020, 4:34 PM
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 mentioned this in T247870: Hard deprecate Article::doDeleteArticleReal.
gerritbot added a comment.Mar 17 2020, 4:56 PM

Change 580375 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ApiDelete: Make ::delete(File)? only accept a wikipage, make private

https://gerrit.wikimedia.org/r/580375

gerritbot added a project: Patch-For-Review.Mar 17 2020, 4:56 PM
gerritbot added a comment.Mar 18 2020, 4:06 PM

Change 580992 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceSocialProfile@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/580992

gerritbot added a comment.Mar 19 2020, 12:36 AM

Change 581162 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581162

gerritbot added a comment.Mar 19 2020, 12:38 AM

Change 581163 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581163

gerritbot added a comment.Mar 19 2020, 12:40 AM

Change 581164 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581164

gerritbot added a comment.Mar 19 2020, 12:44 AM

Change 581165 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581165

gerritbot added a comment.Mar 19 2020, 12:47 AM

Change 581167 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581167

gerritbot added a comment.Mar 19 2020, 10:17 AM

Change 581165 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581165

gerritbot added a comment.Mar 19 2020, 2:33 PM

Change 581164 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581164

gerritbot added a comment.Mar 19 2020, 2:37 PM

Change 581162 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581162

gerritbot added a comment.Mar 19 2020, 2:37 PM

Change 581163 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581163

gerritbot added a comment.Mar 19 2020, 2:42 PM

Change 581167 merged by jenkins-bot:
[mediawiki/core@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/581167

DannyS712 updated the task description. (Show Details)Mar 19 2020, 3:24 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 19 2020, 8:48 PM
gerritbot added a comment.Mar 20 2020, 8:15 PM

Change 580375 merged by jenkins-bot:
[mediawiki/core@master] ApiDelete: Make ::delete(File)? only accept a wikipage, make private

https://gerrit.wikimedia.org/r/580375

DannyS712 closed subtask T247871: Audit all ->doDeleteArticleReal calls as Resolved.Mar 20 2020, 8:33 PM
DannyS712 updated the task description. (Show Details)Mar 25 2020, 6:27 AM
gerritbot added a comment.Mar 25 2020, 6:30 AM

Change 583204 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583204

gerritbot added a comment.Mar 25 2020, 6:36 AM

Change 583206 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CirrusSearch@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583206

gerritbot added a comment.Mar 25 2020, 6:39 AM

Change 583207 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalCssJs@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583207

gerritbot added a comment.Mar 25 2020, 6:41 AM

Change 583207 abandoned by DannyS712:
Use new signature for WikiPage::doDeleteArticleReal in MW 1.35

Reason:
Already done by legoktm in I110520a28dd11f96478c4983a382557270e78540

https://gerrit.wikimedia.org/r/583207

DannyS712 updated the task description. (Show Details)Mar 25 2020, 6:42 AM
gerritbot added a comment.Mar 25 2020, 6:43 AM

Change 583208 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583208

gerritbot added a comment.Mar 25 2020, 6:45 AM

Change 583209 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WebDAV@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583209

gerritbot added a comment.Mar 25 2020, 6:51 AM

Change 583210 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CommentStreams@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583210

gerritbot added a comment.Mar 25 2020, 2:38 PM

Change 583208 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583208

DannyS712 updated the task description. (Show Details)Mar 25 2020, 2:40 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.26; 2020-03-31); removed MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 25 2020, 3:00 PM
gerritbot added a comment.Mar 25 2020, 6:42 PM

Change 583210 merged by jenkins-bot:
[mediawiki/extensions/CommentStreams@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583210

DannyS712 updated the task description. (Show Details)Mar 25 2020, 6:45 PM
DannyS712 updated the task description. (Show Details)Mar 25 2020, 8:14 PM
gerritbot added a comment.Mar 26 2020, 7:14 AM

Change 583204 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583204

DannyS712 updated the task description. (Show Details)Mar 26 2020, 2:59 PM
gerritbot added a comment.Mar 26 2020, 3:45 PM

Change 583206 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Use new signature for WikiPage::doDeleteArticleReal, require MW 1.35+

https://gerrit.wikimedia.org/r/583206

DannyS712 updated the task description. (Show Details)Mar 26 2020, 4:04 PM
gerritbot added a comment.Mar 30 2020, 5:34 PM

Change 580992 merged by Ppchelko:
[mediawiki/extensions/BlueSpiceSocialProfile@master] Pass a user to WikiPage::doDeleteArticleReal, use new signature

https://gerrit.wikimedia.org/r/580992

DannyS712 updated the task description. (Show Details)Mar 30 2020, 5:37 PM
gerritbot added a comment.Mar 30 2020, 5:38 PM

Change 584659 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SplitPrivateWiki@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/584659

• Pchelolo mentioned this in rEBUS93e7bea8222f: Pass a user to WikiPage::doDeleteArticleReal, use new signature.Mar 30 2020, 5:40 PM
gerritbot added a comment.Mar 30 2020, 9:47 PM

Change 584659 merged by jenkins-bot:
[mediawiki/extensions/SplitPrivateWiki@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/584659

gerritbot added a comment.Mar 30 2020, 9:47 PM

Change 583209 merged by jenkins-bot:
[mediawiki/extensions/WebDAV@master] Use new signature for WikiPage::doDeleteArticleReal in MW 1.35+

https://gerrit.wikimedia.org/r/583209

DannyS712 updated the task description. (Show Details)Mar 30 2020, 9:59 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 30 2020, 10:11 PM
gerritbot added a comment.Mar 31 2020, 2:45 AM

Change 584783 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate old signature for WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/584783

gerritbot added a project: Patch-For-Review.Mar 31 2020, 2:45 AM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Mar 31 2020, 2:51 AM
gerritbot added a comment.Mar 31 2020, 3:56 AM

Change 584783 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate old signature for WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/584783

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2020, 4:10 AM
DannyS712 closed this task as Resolved.Mar 31 2020, 4:12 AM
cscott subscribed.Apr 16 2020, 4:58 PM

I'm seeing test failures from Flow?

https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php72-docker/18676/console

DannyS712 reopened this task as Open.Apr 16 2020, 5:02 PM

Woops - I seem to have missed a use

gerritbot added a comment.Apr 16 2020, 5:02 PM

Change 589361 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] PageDumpTestDataTrait: Pass a user to WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/589361

gerritbot added a project: Patch-For-Review.Apr 16 2020, 5:02 PM
gerritbot added a comment.Apr 16 2020, 5:25 PM

Change 589361 merged by jenkins-bot:
[mediawiki/core@master] PageDumpTestDataTrait: Pass a user to WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/589361

DannyS712 closed this task as Resolved.Apr 16 2020, 5:32 PM
DannyS712 removed a project: Patch-For-Review.

@cscott please reopen if this isn't actually fixed

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Apr 16 2020, 6:00 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits