Page MenuHomePhabricator
Create Task
Maniphest T252179

Edits saved via PageUpdater need autopatrol status set
Closed, ResolvedPublic
Actions

Description

When changing WikiPage::doEditContent to use page updaters, I missed the fact that the former automatically added autopatrol status, while the latter doesn't.

Reverts merged on master:

  • WikimediaMaintenance
  • Babel
  • Translate
  • UploadWizard
  • TemplateStyles

Reverts merged on wmf.31:

  • WikimediaMaintenance
  • Babel
  • Translate
  • UploadWizard
  • TemplateStyles Per @Krinkle "This does not need deployment (test suite only, passes either way)."

Reverts deployed to wmf.31:

  • WikimediaMaintenance
  • Babel
  • Translate
  • UploadWizard
  • TemplateStyles Per @Krinkle "This does not need deployment (test suite only, passes either way)."

Details

SubjectRepoBranchLines +/-
Revert "Remove use of WikiPage::doEditContent"mediawiki/extensions/Babelwmf/1.35.0-wmf.31+8 -11
Revert "Remove use of WikiPage::doEditContent"mediawiki/extensions/UploadWizardwmf/1.35.0-wmf.31+7 -13
Revert "Remove uses of WikiPage::doEditContent"mediawiki/extensions/Translatewmf/1.35.0-wmf.31+104 -216
Revert "Remove use of WikiPage::doEditContent"mediawiki/extensions/WikimediaMaintenancewmf/1.35.0-wmf.31+9 -22
Revert "Remove uses of WikiPage::doEditContent"mediawiki/extensions/Translatemaster+104 -216
Revert "Remove use of WikiPage::doEditContent"mediawiki/extensions/UploadWizardmaster+7 -13
Revert "Remove use of WikiPage::doEditContent"mediawiki/extensions/TemplateStylesmaster+4 -13
Revert "Remove use of WikiPage::doEditContent"mediawiki/extensions/Babelmaster+8 -11
Revert "Remove use of WikiPage::doEditContent"mediawiki/extensions/WikimediaMaintenancemaster+9 -22
All wikis except test to 1.35.0-wmf.30operations/mediawiki-configmaster+941 -941
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT11968 Reduce use of global and public variables
 OpenNoneT159283 Deprecate non-configuration globals
 OpenDannyS712T159299 Deprecate and remove $wgUser
 ResolvedDannyS712T267861 [GOAL] Emit deprecation warnings reading from $wgUser
 OpenDannyS712T243708 Mediawiki core needs uses of global $wgUser removed
 ResolvedDannyS712T242935 Deprecate core fallbacks to $wgUser
 ResolvedDannyS712T246284 Hard deprecate the Revision class
 ResolvedDannyS712T248291 Hard deprecate not passing a user to Revision::get methods with Revision::FOR_THIS_USER
 ResolvedDannyS712T249393 Deprecate methods returning Revision objects
 Declined• PcheloloT250638 Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus
 ResolvedDannyS712T249434 Replace hooks using Revision objects with RevisionRecord
 ResolvedDannyS712T248727 Replace ArticleRevisionUndeleted with RevisionUndeleted
 ResolvedDannyS712T232877 The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet
 ResolvedDannyS712T250023 Replace TitleMoveComplet(e|ing) hooks
 ResolvedDannyS712T250338 Replace `NewRevisionFromEditComplete` with a new hook
 ResolvedDannyS712T250543 Replace `ArticleRollbackComplete` hook
 ResolvedDannyS712T250566 Replace PageContent(Insert|Save)Complete hooks
 ResolvedDannyS712T255494 Replace `HistoryRevisionTools` hook with `HistoryTools`
 ResolvedDannyS712T255495 Replace `DiffRevisionTools` hook with `DiffTools`
 ResolvedDannyS712T255769 Replace `DiffViewHeader` hook with one that doesn't use Revision objects
 ResolvedDannyS712T249561 Deprecate methods accepting Revision objects as parameters
 ResolvedDannyS712T249563 Hard deprecate Revision use in WikiPage::doEditUpdates
 ResolvedDannyS712T249397 Replace LinksUpdate Revision methods with RevisionRecord
 ResolvedDannyS712T250318 Hard deprecate WikiPage::updateIfNewerOn
 ResolvedDannyS712T250680 Hard deprecate WikiPage::getUndoContent
 ResolvedDannyS712T250773 Hard deprecate support for Revisions from ContentHandler::getUndoContent
 ResolvedDannyS712T255759 Hard deprecate passing a Revision to WikiPage::prepareContentForEdit
 ResolvedDannyS712T255909 DerivedPageDataUpdater::prepareUpdate $options array can include Revision objects
 ResolvedDannyS712T250761 DifferenceEngine $mNewRev and $mOldRev are Revision objects
 ResolvedDannyS712T250976 Deprecate access to Article::$mRevision
 ResolvedDannyS712T251067 Hard deprecate individual Revision class methods [tracking]
 ResolvedDannyS712T250981 Hard deprecate Revision::getContent(Model|Handler|Format)
 ResolvedDannyS712T250579 Hard deprecate Revision::getUserText
 ResolvedDannyS712T250580 Hard deprecate Revision::isMinor
 ResolvedDannyS712T250608 Hard deprecate Revision::isCurrent
 ResolvedDannyS712T249183 Hard deprecate Revision::newFromTitle
 ResolvedDannyS712T249979 Hard deprecate Revision::newNullRevision
 ResolvedDannyS712T248772 Hard deprecate Revision::newFromArchiveRow
 ResolvedDannyS712T249021 Hard deprecate Revision::newFromId
 ResolvedDannyS712T250980 Hard deprecate Revision::getParentId
 ResolvedDannyS712T250714 Hard deprecate Revision::getVisibility
 ResolvedDannyS712T247259 Remove remaining calls and hard deprecate Revision::userCan
 ResolvedDannyS712T246414 Audit all userCan calls
 ResolvedDannyS712T251073 Hard deprecate Revision::getPrevious
 ResolvedDannyS712T245958 Revision::userCanBitfield falls back to $wgUser
 ResolvedDannyS712T251233 Hard deprecate Revision::getSha1
 ResolvedDannyS712T251593 Hard deprecate Revision::isDeleted
 ResolvedDannyS712T251853 Hard deprecate Revision::getPage
 ResolvedDannyS712T251856 Hard deprecate Revision::insertOn
 ResolvedDannyS712T254703 Hard deprecate Revision::getContent
 ResolvedDannyS712T254960 Hard deprecate Revision::getComment
 ResolvedDannyS712T254964 Hard deprecate Revision::getSize
 ResolvedDannyS712T254966 Hard deprecate Revision::getTimestamp
 ResolvedDannyS712T257010 Replace deployed uses of Revision constants
 ResolvedDannyS712T257011 Audit and remove extension `use Revision;` declarations where possible
 ResolvedDannyS712T257531 Cleanup forgotten usages of Revision
 ResolvedReleasebrennenT249963 1.35.0-wmf.31 deployment blockers
 ResolvedDannyS712T252179 Edits saved via PageUpdater need autopatrol status set

Event Timeline

DannyS712 created this task.May 7 2020, 11:43 PM
Restricted Application added projects: Growth-Team, User-DannyS712. · View Herald TranscriptMay 7 2020, 11:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.May 7 2020, 11:43 PM
DannyS712 renamed this task from Edits made by FuzzyBot should be autopatrolled to Edits made to translated versions of pages aren't autopatrolled.May 7 2020, 11:48 PM
DannyS712 updated the task description. (Show Details)
DannyS712 renamed this task from Edits made to translated versions of pages aren't autopatrolled to Edits saved via PageUpdater need autopatrol status set.May 7 2020, 11:53 PM
DannyS712 triaged this task as Unbreak Now! priority.
DannyS712 updated the task description. (Show Details)
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 7 2020, 11:53 PM
DannyS712 added parent tasks: T249963: 1.35.0-wmf.31 deployment blockers, T250638: Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus.May 7 2020, 11:53 PM
gerritbot added a comment.May 7 2020, 11:56 PM

Change 595068 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Babel@master] Properly apply autopatrol to edits

https://gerrit.wikimedia.org/r/595068

gerritbot added a project: Patch-For-Review.May 7 2020, 11:56 PM
gerritbot added a comment.May 8 2020, 12:00 AM

Change 595069 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Properly apply autopatrol to edits

https://gerrit.wikimedia.org/r/595069

Krinkle subscribed.EditedMay 8 2020, 12:09 AM
In T250638#6118056, @Krinkle wrote:

[…] Let's revert these for now (tracked via T252179), and think about this some more. Copying this logic everywhere is imho not an acceptable solution, not even temporarily.

gerritbot added a comment.May 8 2020, 12:12 AM

Change 595070 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Revert "Remove uses of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595070

DannyS712 added a comment.May 8 2020, 12:13 AM
In T252179#6118044, @Krinkle wrote:

When changing WikiPage::doEditContent to use page updaters, I missed the fact that the former automatically added autopatrol status, while the latter doesn't.

WikiPage.php
	 * @deprecated since 1.32, use PageUpdater::saveRevision instead. Note that the new method
	 * expects callers to take care of checking EDIT_MINOR against the minoredit right, and to
	 * apply the autopatrol right as appropriate.
	 *

This does not make sense to me. Callers like Babel or Translate should not concern themselves with these internal details. Coding that there is imho a mistake and would distribute critical core logic to places where it does not belong. Please revert to the old code for now, and then another week we can figure out how extensions etc should save edits.

{{doing}} the reverts now

gerritbot added a comment.May 8 2020, 12:14 AM

Change 595071 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Babel@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595071

Krinkle mentioned this in T250638: Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus.May 8 2020, 12:14 AM
gerritbot added a comment.May 8 2020, 12:16 AM

Change 595072 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UploadWizard@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595072

gerritbot added a comment.May 8 2020, 12:16 AM

Change 595073 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TemplateStyles@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595073

gerritbot added a comment.May 8 2020, 12:17 AM

Change 595074 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMaintenance@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595074

Stashbot added a comment.May 8 2020, 12:19 AM

Mentioned in SAL (#wikimedia-operations) [2020-05-08T00:19:28Z] <brennen> rolling 1.35.0-wmf.31 train back to group0 for T252179

Stashbot added a comment.May 8 2020, 12:30 AM

Mentioned in SAL (#wikimedia-operations) [2020-05-08T00:30:25Z] <brennen@deploy1001> rebuilt and synchronized wikiversions files: Revert all wikis except test to 1.35.0-wmf.30 for T252179

DannyS712 added a comment.May 8 2020, 12:32 AM

^ That is a lot to scroll through, but to summarize:

All wikis other than test wiki at .30
5 patches were merged that should be reverted: WikimediaMaintenance, TemplateStyles, UploadWizard, Babel, and Translate
Reverts for all 5 are pending at https://gerrit.wikimedia.org/r/#/q/topic:revert-pageupdater

gerritbot added a comment.May 8 2020, 12:35 AM

Change 595075 had a related patch set uploaded (by Brennen Bearnes; owner: Brennen Bearnes):
[operations/mediawiki-config@master] All wikis except test to 1.35.0-wmf.30

https://gerrit.wikimedia.org/r/595075

gerritbot added a comment.May 8 2020, 12:36 AM

Change 595075 merged by jenkins-bot:
[operations/mediawiki-config@master] All wikis except test to 1.35.0-wmf.30

https://gerrit.wikimedia.org/r/595075

DannyS712 edited projects, added MediaWiki-Core-Revision-backend, Platform Team Workboards (External Code Reviews); removed MediaWiki-extensions-Translate.May 8 2020, 12:37 AM
DannyS712 updated the task description. (Show Details)May 8 2020, 12:50 AM
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.May 8 2020, 12:51 AM

Change 595074 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595074

gerritbot added a comment.May 8 2020, 12:51 AM

Change 595076 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMaintenance@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595076

DannyS712 updated the task description. (Show Details)May 8 2020, 12:52 AM
DannyS712 updated the task description. (Show Details)May 8 2020, 12:56 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 8 2020, 1:00 AM
gerritbot added a comment.May 8 2020, 1:06 AM

Change 595071 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595071

gerritbot added a comment.May 8 2020, 1:06 AM

Change 595072 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595072

gerritbot added a comment.May 8 2020, 1:06 AM

Change 595073 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595073

gerritbot added a comment.May 8 2020, 1:06 AM

Change 595077 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Babel@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595077

gerritbot added a comment.May 8 2020, 1:06 AM

Change 595078 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UploadWizard@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595078

DannyS712 updated the task description. (Show Details)May 8 2020, 1:07 AM
gerritbot added a comment.May 8 2020, 8:03 AM

Change 595070 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Revert "Remove uses of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595070

gerritbot added a comment.May 8 2020, 8:15 AM

Change 595135 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@wmf/1.35.0-wmf.31] Revert "Remove uses of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595135

DannyS712 updated the task description. (Show Details)May 8 2020, 8:15 AM
DannyS712 updated the task description. (Show Details)May 8 2020, 5:46 PM
DannyS712 mentioned this in T249963: 1.35.0-wmf.31 deployment blockers.May 9 2020, 11:06 PM
DannyS712 moved this task from Next to In progress on the User-DannyS712 board.May 10 2020, 3:56 AM
brennen subscribed.May 11 2020, 3:13 PM
gerritbot added a comment.May 11 2020, 3:39 PM

Change 595135 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.35.0-wmf.31] Revert "Remove uses of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595135

gerritbot added a comment.May 11 2020, 3:40 PM

Change 595077 merged by jenkins-bot:
[mediawiki/extensions/Babel@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595077

gerritbot added a comment.May 11 2020, 3:40 PM

Change 595078 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595078

gerritbot added a comment.May 11 2020, 3:40 PM

Change 595076 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595076

DannyS712 updated the task description. (Show Details)May 11 2020, 3:40 PM
Stashbot added a comment.May 11 2020, 3:42 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-11T15:42:28Z] <brennen> syncing backports to 1.35.0-wmf.31 (T249963) for T252179

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 11 2020, 3:42 PM
DannyS712 updated the task description. (Show Details)May 11 2020, 4:05 PM
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)
Stashbot added a comment.May 11 2020, 4:13 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-11T16:13:46Z] <brennen@deploy1001> rebuilt and synchronized wikiversions files: mediawikiwiki to 1.35.0-wmf.31 (T249963) for testing T252179

DannyS712 closed this task as Resolved.May 11 2020, 4:57 PM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from In progress to Merged on the User-DannyS712 board.May 27 2020, 8:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL