Page MenuHomePhabricator

Edits saved via PageUpdater need autopatrol status set
Closed, ResolvedPublic

Description

When changing WikiPage::doEditContent to use page updaters, I missed the fact that the former automatically added autopatrol status, while the latter doesn't.

Reverts merged on master:

  • WikimediaMaintenance
  • Babel
  • Translate
  • UploadWizard
  • TemplateStyles

Reverts merged on wmf.31:

  • WikimediaMaintenance
  • Babel
  • Translate
  • UploadWizard
  • TemplateStyles Per @Krinkle "This does not need deployment (test suite only, passes either way)."

Reverts deployed to wmf.31:

  • WikimediaMaintenance
  • Babel
  • Translate
  • UploadWizard
  • TemplateStyles Per @Krinkle "This does not need deployment (test suite only, passes either way)."

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenDannyS712
OpenDannyS712
OpenDannyS712
OpenNone
ResolvedDannyS712
OpenNone
OpenNone
OpenNone
ResolvedDannyS712
ResolvedDannyS712
OpenDannyS712
ResolvedDannyS712
ResolvedDannyS712
OpenDannyS712
OpenNone
OpenNone
ResolvedDannyS712
OpenDannyS712
ResolvedDannyS712
ResolvedDannyS712
OpenDannyS712
ResolvedDannyS712
OpenNone
OpenDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
OpenDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
OpenDannyS712
ResolvedDannyS712
ResolvedDannyS712
OpenDannyS712
OpenDannyS712
ResolvedDannyS712
ResolvedReleasebrennen
ResolvedDannyS712

Event Timeline

Restricted Application added projects: Growth-Team, User-DannyS712. · View Herald TranscriptThu, May 7, 11:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Thu, May 7, 11:43 PM
DannyS712 renamed this task from Edits made by FuzzyBot should be autopatrolled to Edits made to translated versions of pages aren't autopatrolled.Thu, May 7, 11:48 PM
DannyS712 updated the task description. (Show Details)
DannyS712 renamed this task from Edits made to translated versions of pages aren't autopatrolled to Edits saved via PageUpdater need autopatrol status set.Thu, May 7, 11:53 PM
DannyS712 triaged this task as Unbreak Now! priority.
DannyS712 updated the task description. (Show Details)
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptThu, May 7, 11:53 PM

Change 595068 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Babel@master] Properly apply autopatrol to edits

https://gerrit.wikimedia.org/r/595068

Change 595069 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Properly apply autopatrol to edits

https://gerrit.wikimedia.org/r/595069

Krinkle added a subscriber: Krinkle.EditedFri, May 8, 12:09 AM

[…] Let's revert these for now (tracked via T252179), and think about this some more. Copying this logic everywhere is imho not an acceptable solution, not even temporarily.

Change 595070 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Revert "Remove uses of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595070

When changing WikiPage::doEditContent to use page updaters, I missed the fact that the former automatically added autopatrol status, while the latter doesn't.

WikiPage.php
	 * @deprecated since 1.32, use PageUpdater::saveRevision instead. Note that the new method
	 * expects callers to take care of checking EDIT_MINOR against the minoredit right, and to
	 * apply the autopatrol right as appropriate.
	 *

This does not make sense to me. Callers like Babel or Translate should not concern themselves with these internal details. Coding that there is imho a mistake and would distribute critical core logic to places where it does not belong. Please revert to the old code for now, and then another week we can figure out how extensions etc should save edits.

{{doing}} the reverts now

Change 595071 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Babel@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595071

Change 595072 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UploadWizard@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595072

Change 595073 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TemplateStyles@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595073

Change 595074 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMaintenance@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595074

Mentioned in SAL (#wikimedia-operations) [2020-05-08T00:19:28Z] <brennen> rolling 1.35.0-wmf.31 train back to group0 for T252179

Mentioned in SAL (#wikimedia-operations) [2020-05-08T00:30:25Z] <brennen@deploy1001> rebuilt and synchronized wikiversions files: Revert all wikis except test to 1.35.0-wmf.30 for T252179

^ That is a lot to scroll through, but to summarize:

All wikis other than test wiki at .30
5 patches were merged that should be reverted: WikimediaMaintenance, TemplateStyles, UploadWizard, Babel, and Translate
Reverts for all 5 are pending at https://gerrit.wikimedia.org/r/#/q/topic:revert-pageupdater

Change 595075 had a related patch set uploaded (by Brennen Bearnes; owner: Brennen Bearnes):
[operations/mediawiki-config@master] All wikis except test to 1.35.0-wmf.30

https://gerrit.wikimedia.org/r/595075

Change 595075 merged by jenkins-bot:
[operations/mediawiki-config@master] All wikis except test to 1.35.0-wmf.30

https://gerrit.wikimedia.org/r/595075

DannyS712 updated the task description. (Show Details)Fri, May 8, 12:50 AM
DannyS712 updated the task description. (Show Details)

Change 595074 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595074

Change 595076 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMaintenance@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595076

DannyS712 updated the task description. (Show Details)Fri, May 8, 12:52 AM
DannyS712 updated the task description. (Show Details)Fri, May 8, 12:56 AM

Change 595071 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595071

Change 595072 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595072

Change 595073 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595073

Change 595077 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Babel@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595077

Change 595078 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UploadWizard@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595078

DannyS712 updated the task description. (Show Details)Fri, May 8, 1:07 AM

Change 595070 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Revert "Remove uses of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595070

Change 595135 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@wmf/1.35.0-wmf.31] Revert "Remove uses of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595135

DannyS712 updated the task description. (Show Details)Fri, May 8, 8:15 AM
DannyS712 updated the task description. (Show Details)Fri, May 8, 5:46 PM
DannyS712 moved this task from Next to In progress on the User-DannyS712 board.Sun, May 10, 3:56 AM

Change 595135 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.35.0-wmf.31] Revert "Remove uses of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595135

Change 595077 merged by jenkins-bot:
[mediawiki/extensions/Babel@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595077

Change 595078 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595078

Change 595076 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@wmf/1.35.0-wmf.31] Revert "Remove use of WikiPage::doEditContent"

https://gerrit.wikimedia.org/r/595076

DannyS712 updated the task description. (Show Details)Mon, May 11, 3:40 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-11T15:42:28Z] <brennen> syncing backports to 1.35.0-wmf.31 (T249963) for T252179

DannyS712 updated the task description. (Show Details)Mon, May 11, 4:05 PM
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2020-05-11T16:13:46Z] <brennen@deploy1001> rebuilt and synchronized wikiversions files: mediawikiwiki to 1.35.0-wmf.31 (T249963) for testing T252179

DannyS712 closed this task as Resolved.Mon, May 11, 4:57 PM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from In progress to Merged on the User-DannyS712 board.Wed, May 27, 8:26 AM