Cleanup forgotten usages of Revision
Closed, ResolvedPublic
Actions

Description

From the production logs, we have 3 usages so far that were forgotten:

Use of MediaWiki\Storage\PageUpdater::doModify status get 'revision' was deprecated in MediaWiki 1.35. [Called from SpecialPageTranslation::markForTranslation in /srv/mediawiki/php-1.35.0-wmf.40/extensions/Translate/tag/SpecialPageTranslation.php at line
23

Use of Revision::__construct was deprecated in MediaWiki 1.31. [Called from MediaWiki\Storage\PageUpdater::MediaWiki\Storage\{closure} in /srv/mediawiki/php-1.35.0-wmf.40/includes/Storage/PageUpdater.php at line 1122]
3

Use of Revision::getRevisionRecord was deprecated in MediaWiki 1.31. [Called from SpecialPageTranslation::markForTranslation in /srv/mediawiki/php-1.35.0-wmf.40/extensions/Translate/tag/SpecialPageTranslation.php at line 887]

Details

	Subject	Repo	Branch	Lines +/-
	DeprecatablePropertyArray: Use MW_VERSION instead of array_key_exists	mediawiki/extensions/Translate	wmf/1.35.0-wmf.40	+4 -1
	DeprecatablePropertyArray: Use MW_VERSION instead of array_key_exists	mediawiki/extensions/Translate	master	+4 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T257531 Cleanup forgotten usages of Revision

Event Timeline

• Pchelolo created this task.Jul 8 2020, 11:23 PM

The three uses are all the same. Hmm,

		if ( array_key_exists( 'revision-record', $status->value ) ) {
			// MW 1.35+
			// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
			$newRevisionRecord = $status->value['revision-record'];
		} else {
			// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
			$newRevision = $status->value['revision'];
			if ( $newRevision instanceof Revision ) {
				$newRevisionRecord = $newRevision->getRevisionRecord();
			} else {
				$newRevisionRecord = null;
			}
		}

Apparently isn't working? Access revision -> callback to create Revision (use of __construct) -> ::getRevisionRecord.

$status->value is the DeprecatablePropertyArray from T254952: PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision. Does array_key_exists not work with DeprecatablePropertyArray?

DannyS712 added a project: MediaWiki-extensions-Translate.Jul 8 2020, 11:49 PM

Does array_key_exists not work with DeprecatablePropertyArray?

It certainly seems so. I've tried it out in a unit test. isset will do the trick.

Change 610102 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] DeprecatablePropertyArray: Use isset instead of array_key_exists

https://gerrit.wikimedia.org/r/610102

gerritbot added a project: Patch-For-Review.Jul 9 2020, 12:06 AM

In T257531#6291936, @Pchelolo wrote:

Does array_key_exists not work with DeprecatablePropertyArray?

It certainly seems so. I've tried it out in a unit test. isset will do the trick.

Though the value can be null, so isset might not be the best idea

Checking against just MW_VERSION

Change 610102 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] DeprecatablePropertyArray: Use MW_VERSION instead of array_key_exists

https://gerrit.wikimedia.org/r/610102

Change 610103 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@wmf/1.35.0-wmf.40] DeprecatablePropertyArray: Use MW_VERSION instead of array_key_exists

https://gerrit.wikimedia.org/r/610103

DannyS712 removed projects: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Platform Engineering, Epic.Jul 9 2020, 12:52 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 9 2020, 1:00 AM

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Jul 9 2020, 7:04 AM

Change 610103 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.35.0-wmf.40] DeprecatablePropertyArray: Use MW_VERSION instead of array_key_exists

https://gerrit.wikimedia.org/r/610103

DannyS712 closed this task as Resolved.Jul 9 2020, 11:38 AM

DannyS712 removed a project: Patch-For-Review.

Mentioned in SAL (#wikimedia-operations) [2020-07-09T11:42:24Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.40/extensions/Translate/tag/SpecialPageTranslation.php: 6541d3ff51f52fe8a1bdbfa86022f8d97d6c7680: DeprecatablePropertyArray: Use MW_VERSION instead of array_key_exists (T257531) (duration: 01m 05s)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 9 2020, 12:00 PM

DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Jul 9 2020, 11:12 PM

DannyS712 moved this task from Merged to Resolved (deprecation) on the User-DannyS712 board.

Cleanup forgotten usages of RevisionClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Cleanup forgotten usages of Revision
Closed, ResolvedPublic
Actions

Related Objects
Search...