Page MenuHomePhabricator
Create Task
Maniphest T254952

PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision
Closed, ResolvedPublic
Actions

Description

First, uses need to be removed

Details

SubjectRepoBranchLines +/-
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/extensions/Translatemaster+45 -36
TalkpageManager::ensureFlowRevision - don't document returning Revisionsmediawiki/extensions/Flowmaster+1 -1
PageUpdater: set DeprecatablePropertyArray to hard deprecate Revisionmediawiki/coremaster+35 -13
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/extensions/Flowmaster+3 -3
TestStorageHelper::makeEdit - return RevisionRecord, not Revisionmediawiki/extensions/Jademaster+41 -34
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/extensions/ORESmaster+20 -20
McrRevisionStoreDbTest: Don't create a Revision objectmediawiki/coremaster+3 -67
RevisionStoreDbTestBase: Reduce use of Revision from WikiPage::doEditContentmediawiki/coremaster+360 -249
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/extensions/Thanksmaster+4 -3
Remove use of the Revision object returned in WikiPage::doEditContent (2)mediawiki/coremaster+79 -74
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/extensions/CirrusSearchmaster+4 -1
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/coremaster+19 -16
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/extensions/Echomaster+8 -8
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/extensions/FlaggedRevsmaster+2 -2
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/extensions/Jademaster+3 -3
Remove use of the Revision object returned in WikiPage::doEditContentmediawiki/extensions/CentralNoticemaster+4 -4
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as High priority.Jun 9 2020, 11:19 PM
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Jun 9 2020, 11:19 PM

Change 604175 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604175

gerritbot added a project: Patch-For-Review.Jun 9 2020, 11:19 PM

Change 604174 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604174

gerritbot added a comment.Jun 9 2020, 11:20 PM

Change 604179 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604179

gerritbot added a comment.Jun 9 2020, 11:27 PM

Change 604181 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604181

gerritbot added a comment.Jun 9 2020, 11:36 PM

Change 604183 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604183

gerritbot added a comment.Jun 9 2020, 11:40 PM

Change 604185 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604185

gerritbot added a comment.Jun 9 2020, 11:42 PM

Change 604186 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604186

gerritbot added a comment.Jun 9 2020, 11:45 PM

Change 604187 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ORES@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604187

gerritbot added a comment.Jun 10 2020, 12:16 AM

Change 604175 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604175

gerritbot added a comment.Jun 10 2020, 12:16 AM

Change 604174 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604174

gerritbot added a comment.Jun 10 2020, 12:16 AM

Change 604186 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604186

gerritbot added a comment.Jun 10 2020, 12:29 AM

Change 604185 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604185

gerritbot added a comment.Jun 10 2020, 12:30 AM

Change 604193 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604193

gerritbot added a comment.Jun 10 2020, 12:32 AM

Change 604196 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CirrusSearch@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604196

gerritbot added a comment.Jun 10 2020, 12:34 AM

Change 604179 merged by jenkins-bot:
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604179

gerritbot added a comment.Jun 10 2020, 12:37 AM

Change 604197 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent (2)

https://gerrit.wikimedia.org/r/604197

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 10 2020, 1:00 AM
gerritbot added a comment.Jun 10 2020, 1:08 AM

Change 604207 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] RevisionStoreDbTestBase: Reduce use of Revision from WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604207

gerritbot added a comment.Jun 10 2020, 1:30 AM

Change 604196 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604196

gerritbot added a comment.Jun 10 2020, 2:03 AM

Change 604197 merged by jenkins-bot:
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent (2)

https://gerrit.wikimedia.org/r/604197

gerritbot added a comment.Jun 10 2020, 2:29 AM

Change 604193 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604193

gerritbot added a comment.Jun 10 2020, 2:45 AM

Change 604225 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] McrRevisionStoreDbTest: Don't create a Revision object

https://gerrit.wikimedia.org/r/604225

DannyS712 mentioned this in rEJAD94efa0a2143e: Remove use of the Revision object returned in WikiPage::doEditContent.Jun 10 2020, 3:28 AM
gerritbot added a comment.Jun 10 2020, 3:28 AM

Change 604207 merged by jenkins-bot:
[mediawiki/core@master] RevisionStoreDbTestBase: Reduce use of Revision from WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604207

gerritbot added a comment.Jun 10 2020, 3:31 AM

Change 604225 merged by jenkins-bot:
[mediawiki/core@master] McrRevisionStoreDbTest: Don't create a Revision object

https://gerrit.wikimedia.org/r/604225

gerritbot added a comment.Jun 10 2020, 3:07 PM

Change 604187 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604187

gerritbot added a comment.Jun 16 2020, 9:56 PM

Change 606019 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] TestStorageHelper::makeEdit - return RevisionRecord, not Revision

https://gerrit.wikimedia.org/r/606019

gerritbot added a comment.Jun 17 2020, 8:28 PM

Change 606019 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] TestStorageHelper::makeEdit - return RevisionRecord, not Revision

https://gerrit.wikimedia.org/r/606019

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.38; 2020-06-23); removed MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 17 2020, 9:00 PM
gerritbot added a comment.Jun 17 2020, 9:05 PM

Change 604181 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604181

gerritbot added a comment.Jun 24 2020, 8:56 PM

Change 604183 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604183

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.39; 2020-06-30); removed MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 24 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 24 2020, 9:10 PM
gerritbot added a comment.Jun 26 2020, 1:24 AM

Change 607912 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] TalkpageManager::ensureFlowRevision - don't document returning Revisions

https://gerrit.wikimedia.org/r/607912

gerritbot added a project: Patch-For-Review.Jun 26 2020, 1:24 AM
DannyS712 claimed this task.Jun 26 2020, 1:29 AM
In T254952#6258915, @gerritbot wrote:

Change 607912 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] TalkpageManager::ensureFlowRevision - don't document returning Revisions

https://gerrit.wikimedia.org/r/607912

All deployed uses should be removed (or for extensions that support prior versions, shouldn't be accessed in production code). I may have missed one or two, but at worst that would trigger logspam. Sending a patch to hard deprecate now

gerritbot added a comment.Jun 26 2020, 1:35 AM

Change 607914 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision

https://gerrit.wikimedia.org/r/607914

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Jun 26 2020, 1:39 AM

Once the hard deprecation is merged, will leave a note on the train blocker about the potential log spam

gerritbot added a comment.Jul 1 2020, 12:11 AM

Change 607914 merged by jenkins-bot:
[mediawiki/core@master] PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /607914

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jul 1 2020, 1:00 AM
gerritbot added a comment.Jul 1 2020, 2:38 AM

Change 607912 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] TalkpageManager::ensureFlowRevision - don't document returning Revisions

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/ /607912

DannyS712 closed this task as Resolved.Jul 1 2020, 3:08 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 mentioned this in T257531: Cleanup forgotten usages of Revision.Jul 8 2020, 11:48 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL