Page MenuHomePhabricator

PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision
Closed, ResolvedPublic

Description

First, uses need to be removed

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Translatemaster+45 -36
mediawiki/extensions/Flowmaster+1 -1
mediawiki/coremaster+35 -13
mediawiki/extensions/Flowmaster+3 -3
mediawiki/extensions/Jademaster+41 -34
mediawiki/extensions/ORESmaster+20 -20
mediawiki/coremaster+3 -67
mediawiki/coremaster+360 -249
mediawiki/extensions/Thanksmaster+4 -3
mediawiki/coremaster+79 -74
mediawiki/extensions/CirrusSearchmaster+4 -1
mediawiki/coremaster+19 -16
mediawiki/extensions/Echomaster+8 -8
mediawiki/extensions/FlaggedRevsmaster+2 -2
mediawiki/extensions/Jademaster+3 -3
mediawiki/extensions/CentralNoticemaster+4 -4
Show related patches Customize query in gerrit

Event Timeline

DannyS712 triaged this task as High priority.Jun 9 2020, 11:19 PM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 604175 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604175

Change 604174 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604174

Change 604179 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604179

Change 604181 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604181

Change 604183 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604183

Change 604185 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604185

Change 604186 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604186

Change 604187 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ORES@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604187

Change 604175 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604175

Change 604174 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604174

Change 604186 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604186

Change 604185 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604185

Change 604193 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604193

Change 604196 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CirrusSearch@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604196

Change 604179 merged by jenkins-bot:
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604179

Change 604197 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent (2)

https://gerrit.wikimedia.org/r/604197

Change 604207 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] RevisionStoreDbTestBase: Reduce use of Revision from WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604207

Change 604196 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604196

Change 604197 merged by jenkins-bot:
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent (2)

https://gerrit.wikimedia.org/r/604197

Change 604193 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604193

Change 604225 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] McrRevisionStoreDbTest: Don't create a Revision object

https://gerrit.wikimedia.org/r/604225

Change 604207 merged by jenkins-bot:
[mediawiki/core@master] RevisionStoreDbTestBase: Reduce use of Revision from WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604207

Change 604225 merged by jenkins-bot:
[mediawiki/core@master] McrRevisionStoreDbTest: Don't create a Revision object

https://gerrit.wikimedia.org/r/604225

Change 604187 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604187

Change 606019 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] TestStorageHelper::makeEdit - return RevisionRecord, not Revision

https://gerrit.wikimedia.org/r/606019

Change 606019 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] TestStorageHelper::makeEdit - return RevisionRecord, not Revision

https://gerrit.wikimedia.org/r/606019

Change 604181 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604181

Change 604183 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove use of the Revision object returned in WikiPage::doEditContent

https://gerrit.wikimedia.org/r/604183

Change 607912 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] TalkpageManager::ensureFlowRevision - don't document returning Revisions

https://gerrit.wikimedia.org/r/607912

Change 607912 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] TalkpageManager::ensureFlowRevision - don't document returning Revisions

https://gerrit.wikimedia.org/r/607912

All deployed uses should be removed (or for extensions that support prior versions, shouldn't be accessed in production code). I may have missed one or two, but at worst that would trigger logspam. Sending a patch to hard deprecate now

Change 607914 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision

https://gerrit.wikimedia.org/r/607914

Once the hard deprecation is merged, will leave a note on the train blocker about the potential log spam

Change 607914 merged by jenkins-bot:
[mediawiki/core@master] PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /607914

Change 607912 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] TalkpageManager::ensureFlowRevision - don't document returning Revisions

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/ /607912

DannyS712 closed this task as Resolved.Jul 1 2020, 3:08 AM
DannyS712 removed a project: Patch-For-Review.