Page MenuHomePhabricator
Create Task
Maniphest T249393

Deprecate methods returning Revision objects
Closed, ResolvedPublic
Actions

Description

So the class can be deprecated and removed

Tracked at P10887

Details

SubjectRepoBranchLines +/-
Parser: Hard deprecate Revision returned from statelessFetchTemplatemediawiki/coremaster+4 -5
Parser: Set DeprecatablePropertyArray to hard deprecate Revisionmediawiki/coremaster+4 -4
Parser::statelessFetchTemplate - return DeprecatablePropertyArraymediawiki/coremaster+29 -7
Hard deprecate Title::getFirstRevisionmediawiki/coremaster+2 -1
Make MessageCacheTest::makePage private, return RevisionRecordmediawiki/coremaster+15 -7
Remove use of Revision objects in RevisionItem classesmediawiki/coremaster+34 -27
Don't use WikiPage::getOldestRevision(), deprecated in MW 1.35mediawiki/extensions/BlueSpiceExtendedSearchmaster+4 -1
Have CoreParserFunctions::getCachedRevisionObject return RevisionRecordmediawiki/coremaster+23 -14
SpecialNewpages::revisionFromRcResult - return RevisionRecordmediawiki/coremaster+24 -12
ContentHandler::latestRevision - return RevisionRecordmediawiki/coremaster+4 -6
Replace uses and hard deprecate Article::getRevisionFetchedmediawiki/coremaster+47 -30
Remove a remaining use of Revision objectsmediawiki/extensions/AbuseFiltermaster+49 -14
SpecialMobileDiff::getRevisionsToCompare - return RevisionRecordmediawiki/extensions/MobileFrontendmaster+32 -22
Tests: Remove use of Title::getFirstRevisionmediawiki/extensions/FileImportermaster+24 -10
Remove use of revisions in ApiTraitmediawiki/extensions/CirrusSearchmaster+14 -12
Remove use of WikiPage::getRevision and other uses of Revision objectsmediawiki/extensions/FileImportermaster+48 -20
Replace PageArchive::getPreviousRevision with getPreviousRevisionRecordmediawiki/coremaster+22 -2
Replace PageArchive::getArchivedRevision with getArchivedRevisionRecordmediawiki/coremaster+24 -4
Hard deprecate Article:: and WikiPage::getOldestRevisionmediawiki/coremaster+14 -5
Remove use of WikiPage::getRevisionmediawiki/extensions/EntitySchemamaster+1 -1
Remove use of WikiPage::getOldestRevision, require MW 1.35+mediawiki/extensions/PageTriagemaster+4 -8
Remove use of WikiPage::getRevisionmediawiki/extensions/WikibaseMediaInfomaster+2 -2
Remove use of WikiPage::getRevisionmediawiki/extensions/WikiEditormaster+2 -1
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT11968 Reduce use of global and public variables
 OpenNoneT159283 Deprecate non-configuration globals
 OpenDannyS712T159299 Deprecate and remove $wgUser
 ResolvedDannyS712T267861 [GOAL] Emit deprecation warnings reading from $wgUser
 OpenDannyS712T243708 Mediawiki core needs uses of global $wgUser removed
 ResolvedDannyS712T246284 Hard deprecate the Revision class
 ResolvedDannyS712T249393 Deprecate methods returning Revision objects
 ResolvedDannyS712T249384 ParserOptions' currentRevisionCallback uses Revision objects
 ResolvedDannyS712T248655 EditPage::getBaseRevision returns a revision
 ResolvedDannyS712T249397 Replace LinksUpdate Revision methods with RevisionRecord
 ResolvedDannyS712T249982 PageArchive::getRevision uses timestamp, suggested replacement uses rev id
 ResolvedDannyS712T250249 WikiPage::insertProtectNullRevision returns Revision objects
 ResolvedDannyS712T250431 ContribsPager::tryToCreateValidRevision returns Revision objects
 ResolvedDannyS712T250532 Hard deprecate Article::getRevision and WikiPage::getRevision
 Declined• PcheloloT250638 Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus
 ResolvedDannyS712T252179 Edits saved via PageUpdater need autopatrol status set
 ResolvedDannyS712T251718 Hard deprecate PageArchive::getPreviousRevision
 ResolvedDannyS712T251965 Deprecate use of Revision objects in WikiPage::doRollback and ::commitRollback
 ResolvedDannyS712T253949 User::getNewMessageLinks can return Revision objects
 ResolvedDannyS712T254952 PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision

Event Timeline

DannyS712 triaged this task as Medium priority.Apr 4 2020, 1:17 AM
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 added subtasks: T249384: ParserOptions' currentRevisionCallback uses Revision objects, T248655: EditPage::getBaseRevision returns a revision.
gerritbot added a comment.Apr 4 2020, 1:20 AM

Change 585847 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Remove use of WikiPage::getOldestRevision in MW 1.35+

https://gerrit.wikimedia.org/r/585847

gerritbot added a project: Patch-For-Review.Apr 4 2020, 1:20 AM
gerritbot added a comment.Apr 7 2020, 11:37 PM

Change 587373 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikiEditor@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587373

gerritbot added a comment.Apr 7 2020, 11:40 PM

Change 587374 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587374

gerritbot added a comment.Apr 7 2020, 11:44 PM

Change 587375 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/EntitySchema@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587375

gerritbot added a comment.Apr 8 2020, 12:43 AM

Change 587374 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587374

gerritbot added a comment.Apr 8 2020, 12:53 AM

Change 587373 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587373

gerritbot added a comment.Apr 8 2020, 12:53 AM

Change 585847 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Remove use of WikiPage::getOldestRevision, require MW 1.35+

https://gerrit.wikimedia.org/r/585847

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 8 2020, 1:00 AM
gerritbot added a comment.Apr 8 2020, 3:00 AM

Change 587396 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article:: and WikiPage::getOldestRevision

https://gerrit.wikimedia.org/r/587396

gerritbot added a comment.Apr 8 2020, 7:28 AM

Change 587487 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add PageArchive::getArchivedRevisionRecord, deprecate getArchivedRevision

https://gerrit.wikimedia.org/r/587487

DannyS712 added a comment.Apr 8 2020, 7:37 AM

PageArchive::getPreviousRevision has 1 deployed use, in CirrusSearch

gerritbot added a comment.Apr 8 2020, 7:41 AM

Change 587489 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace PageArchive::getPreviousRevision with getPreviousRevisionRecord

https://gerrit.wikimedia.org/r/587489

gerritbot added a comment.Apr 8 2020, 8:41 AM

Change 587375 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587375

DannyS712 closed subtask T249397: Replace LinksUpdate Revision methods with RevisionRecord as Resolved.Apr 10 2020, 1:37 AM
gerritbot added a comment.Apr 10 2020, 4:37 AM

Change 587904 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace uses and hard deprecate Article::getRevisionFetched

https://gerrit.wikimedia.org/r/587904

• Pchelolo edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).Apr 10 2020, 3:23 PM
gerritbot added a comment.Apr 10 2020, 5:47 PM

Change 587396 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article:: and WikiPage::getOldestRevision

https://gerrit.wikimedia.org/r/587396

gerritbot added a comment.Apr 11 2020, 3:53 AM

Change 587487 merged by jenkins-bot:
[mediawiki/core@master] Replace PageArchive::getArchivedRevision with getArchivedRevisionRecord

https://gerrit.wikimedia.org/r/587487

gerritbot added a comment.Apr 11 2020, 3:54 AM

Change 587489 merged by jenkins-bot:
[mediawiki/core@master] Replace PageArchive::getPreviousRevision with getPreviousRevisionRecord

https://gerrit.wikimedia.org/r/587489

gerritbot added a comment.Apr 11 2020, 4:37 AM

Change 588069 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CirrusSearch@master] Remove use of revisions in ApiTrait

https://gerrit.wikimedia.org/r/588069

gerritbot added a comment.Apr 12 2020, 7:09 PM

Change 588164 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FileImporter@master] Remove use of WikiPage::getRevision and other uses of Revision objects

https://gerrit.wikimedia.org/r/588164

gerritbot added a comment.Apr 13 2020, 5:59 PM

Change 588164 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Remove use of WikiPage::getRevision and other uses of Revision objects

https://gerrit.wikimedia.org/r/588164

DannyS712 mentioned this in rEFLI9f7aa66b4197: Remove use of WikiPage::getRevision and other uses of Revision objects.Apr 13 2020, 5:59 PM
DannyS712 closed subtask T248655: EditPage::getBaseRevision returns a revision as Resolved.Apr 13 2020, 7:21 PM
gerritbot added a comment.Apr 13 2020, 11:47 PM

Change 588069 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove use of revisions in ApiTrait

https://gerrit.wikimedia.org/r/588069

gerritbot added a comment.Apr 14 2020, 9:54 PM

Change 588793 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] Remove a remaining use of Revision objects

https://gerrit.wikimedia.org/r/588793

gerritbot added a comment.Apr 14 2020, 10:02 PM

Change 588796 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FileImporter@master] Tests: Remove use of Title::getFirstRevision

https://gerrit.wikimedia.org/r/588796

gerritbot added a comment.Apr 15 2020, 4:23 AM

Change 588828 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] SpecialMobileDiff::getRevisionsToCompare - return RevisionRecord

https://gerrit.wikimedia.org/r/588828

gerritbot added a comment.Apr 15 2020, 7:20 PM

Change 588796 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Tests: Remove use of Title::getFirstRevision

https://gerrit.wikimedia.org/r/588796

thiemowmde mentioned this in rEFLI537b347fc37b: Tests: Remove use of Title::getFirstRevision.Apr 15 2020, 7:24 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 15 2020, 8:01 PM
gerritbot added a comment.Apr 16 2020, 8:23 PM

Change 588828 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] SpecialMobileDiff::getRevisionsToCompare - return RevisionRecord

https://gerrit.wikimedia.org/r/588828

gerritbot added a comment.Apr 17 2020, 8:51 PM

Change 589705 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Have CoreParserFunctions::getCachedRevisionObject return RevisionRecord

https://gerrit.wikimedia.org/r/589705

gerritbot added a comment.Apr 18 2020, 1:53 AM

Change 589789 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Make WikiPage::commitRollback internal to prepare for a breaking change

https://gerrit.wikimedia.org/r/589789

gerritbot added a comment.Apr 18 2020, 2:11 AM

Change 589792 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Remove rollback from generateSampleNotifications

https://gerrit.wikimedia.org/r/589792

DannyS712 mentioned this in T246284: Hard deprecate the Revision class.Apr 18 2020, 5:49 PM
gerritbot added a comment.Apr 18 2020, 8:08 PM

Change 589913 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] SpecialNewpages::revisionFromRcResult - return RevisionRecord

https://gerrit.wikimedia.org/r/589913

DannyS712 closed subtask T250249: WikiPage::insertProtectNullRevision returns Revision objects as Resolved.Apr 19 2020, 1:52 AM
DannyS712 closed subtask T250532: Hard deprecate Article::getRevision and WikiPage::getRevision as Resolved.Apr 20 2020, 11:32 PM
gerritbot added a comment.Apr 23 2020, 8:05 PM

Change 588793 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove a remaining use of Revision objects

https://gerrit.wikimedia.org/r/588793

gerritbot added a comment.Apr 27 2020, 6:33 PM

Change 587904 merged by jenkins-bot:
[mediawiki/core@master] Replace uses and hard deprecate Article::getRevisionFetched

https://gerrit.wikimedia.org/r/587904

gerritbot added a comment.Apr 27 2020, 10:03 PM

Change 592773 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ContentHandler::latestRevision - return RevisionRecord

https://gerrit.wikimedia.org/r/592773

gerritbot added a comment.Apr 29 2020, 2:04 AM

Change 592773 merged by jenkins-bot:
[mediawiki/core@master] ContentHandler::latestRevision - return RevisionRecord

https://gerrit.wikimedia.org/r/592773

gerritbot added a comment.Apr 29 2020, 2:07 AM

Change 589913 merged by jenkins-bot:
[mediawiki/core@master] SpecialNewpages::revisionFromRcResult - return RevisionRecord

https://gerrit.wikimedia.org/r/589913

gerritbot added a comment.Apr 29 2020, 2:53 AM

Change 593090 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Make MessageCacheTest::makePage private, return RevisionRecord

https://gerrit.wikimedia.org/r/593090

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 29 2020, 3:00 AM
gerritbot added a comment.Apr 30 2020, 8:16 PM

Change 589705 merged by jenkins-bot:
[mediawiki/core@master] Have CoreParserFunctions::getCachedRevisionObject return RevisionRecord

https://gerrit.wikimedia.org/r/589705

gerritbot added a comment.May 1 2020, 6:12 PM

Change 593785 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of Revision objects in RevisionItem classes

https://gerrit.wikimedia.org/r/593785

DannyS712 closed subtask T250431: ContribsPager::tryToCreateValidRevision returns Revision objects as Resolved.May 1 2020, 7:43 PM
gerritbot added a comment.May 2 2020, 5:44 AM

Change 593880 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/BlueSpiceExtendedSearch@master] Don't use WikiPage::getOldestRevision(), deprecated in MW 1.35

https://gerrit.wikimedia.org/r/593880

gerritbot added a comment.May 4 2020, 5:50 AM

Change 593880 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceExtendedSearch@master] Don't use WikiPage::getOldestRevision(), deprecated in MW 1.35

https://gerrit.wikimedia.org/r/593880

cscott mentioned this in rEBSES3d849a34f15b: Don't use WikiPage::getOldestRevision(), deprecated in MW 1.35.May 4 2020, 6:02 AM
gerritbot added a comment.May 6 2020, 12:46 AM

Change 593785 merged by jenkins-bot:
[mediawiki/core@master] Remove use of Revision objects in RevisionItem classes

https://gerrit.wikimedia.org/r/593785

DannyS712 closed subtask T251718: Hard deprecate PageArchive::getPreviousRevision as Resolved.May 7 2020, 4:08 PM
gerritbot added a comment.May 22 2020, 6:13 PM

Change 593090 merged by jenkins-bot:
[mediawiki/core@master] Make MessageCacheTest::makePage private, return RevisionRecord

https://gerrit.wikimedia.org/r/593090

DannyS712 closed subtask T249384: ParserOptions' currentRevisionCallback uses Revision objects as Resolved.Jun 4 2020, 2:13 AM
• Pchelolo closed subtask T253949: User::getNewMessageLinks can return Revision objects as Resolved.Jun 9 2020, 3:08 AM
DannyS712 reopened subtask T253949: User::getNewMessageLinks can return Revision objects as Open.Jun 9 2020, 8:17 AM
DannyS712 closed subtask T250638: Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus as Declined.Jun 9 2020, 9:49 PM
gerritbot added a comment.Jun 10 2020, 2:37 AM

Change 604224 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Title::getFirstRevision

https://gerrit.wikimedia.org/r/604224

gerritbot added a comment.Jun 10 2020, 3:24 AM

Change 604224 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Title::getFirstRevision

https://gerrit.wikimedia.org/r/604224

DannyS712 closed subtask T253949: User::getNewMessageLinks can return Revision objects as Resolved.Jun 10 2020, 3:45 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Jun 10 2020, 4:00 AM
DannyS712 mentioned this in T249434: Replace hooks using Revision objects with RevisionRecord.Jun 15 2020, 3:13 PM
DannyS712 closed subtask T249982: PageArchive::getRevision uses timestamp, suggested replacement uses rev id as Resolved.Jun 16 2020, 1:37 AM
gerritbot added a comment.Jun 24 2020, 1:22 AM

Change 607394 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Parser::fetchTemplateAndTitle - return DeprecatablePropertyArray

https://gerrit.wikimedia.org/r/607394

gerritbot added a comment.Jun 24 2020, 3:20 AM

Change 607394 merged by jenkins-bot:
[mediawiki/core@master] Parser::statelessFetchTemplate - return DeprecatablePropertyArray

https://gerrit.wikimedia.org/r/607394

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.39; 2020-06-30); removed MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 24 2020, 4:00 AM
gerritbot added a comment.Jun 26 2020, 11:55 PM

Change 608101 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Parser: Hard deprecate Revision returned from statelessFetchTemplate

https://gerrit.wikimedia.org/r/608101

DannyS712 reopened subtask T249982: PageArchive::getRevision uses timestamp, suggested replacement uses rev id as Open.Jun 30 2020, 7:39 AM
DannyS712 closed subtask T249982: PageArchive::getRevision uses timestamp, suggested replacement uses rev id as Resolved.Jun 30 2020, 10:45 AM
DannyS712 closed subtask T254952: PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision as Resolved.Jul 1 2020, 3:08 AM
gerritbot added a comment.Jul 1 2020, 6:23 AM

Change 608679 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Parser: Set DeprecatablePropertyArray to hard deprecate Revision

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608679

gerritbot added a comment.Jul 1 2020, 8:34 PM

Change 608679 merged by jenkins-bot:
[mediawiki/core@master] Parser: Set DeprecatablePropertyArray to hard deprecate Revision

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608679

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jul 1 2020, 9:00 PM
gerritbot added a comment.Jul 2 2020, 2:49 AM

Change 608101 abandoned by DannyS712:
Parser: Hard deprecate Revision returned from statelessFetchTemplate

Reason:
I duplicated this in 3f894708bd8a640f9175b0cd8d7b5e958477178b which has already merged

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608101

DannyS712 closed this task as Resolved.Jul 2 2020, 2:49 AM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.

Should be done

DannyS712 closed subtask T251965: Deprecate use of Revision objects in WikiPage::doRollback and ::commitRollback as Resolved.Jul 2 2020, 2:50 AM
DannyS712 moved this task from In progress to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL