Page MenuHomePhabricator

Deprecate methods returning Revision objects
Closed, ResolvedPublic

Description

So the class can be deprecated and removed

Tracked at P10887

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+4 -5
mediawiki/coremaster+4 -4
mediawiki/coremaster+29 -7
mediawiki/coremaster+2 -1
mediawiki/coremaster+15 -7
mediawiki/coremaster+34 -27
mediawiki/extensions/BlueSpiceExtendedSearchmaster+4 -1
mediawiki/coremaster+23 -14
mediawiki/coremaster+24 -12
mediawiki/coremaster+4 -6
mediawiki/coremaster+47 -30
mediawiki/extensions/AbuseFiltermaster+49 -14
mediawiki/extensions/MobileFrontendmaster+32 -22
mediawiki/extensions/FileImportermaster+24 -10
mediawiki/extensions/CirrusSearchmaster+14 -12
mediawiki/extensions/FileImportermaster+48 -20
mediawiki/coremaster+22 -2
mediawiki/coremaster+24 -4
mediawiki/coremaster+14 -5
mediawiki/extensions/EntitySchemamaster+1 -1
mediawiki/extensions/PageTriagemaster+4 -8
mediawiki/extensions/WikibaseMediaInfomaster+2 -2
mediawiki/extensions/WikiEditormaster+2 -1
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenDannyS712
ResolvedDannyS712
OpenDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
DeclinedPchelolo
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712
ResolvedDannyS712

Event Timeline

Change 585847 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Remove use of WikiPage::getOldestRevision in MW 1.35+

https://gerrit.wikimedia.org/r/585847

Change 587373 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikiEditor@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587373

Change 587374 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587374

Change 587375 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/EntitySchema@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587375

Change 587374 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587374

Change 587373 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587373

Change 585847 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Remove use of WikiPage::getOldestRevision, require MW 1.35+

https://gerrit.wikimedia.org/r/585847

Change 587396 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article:: and WikiPage::getOldestRevision

https://gerrit.wikimedia.org/r/587396

Change 587487 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add PageArchive::getArchivedRevisionRecord, deprecate getArchivedRevision

https://gerrit.wikimedia.org/r/587487

PageArchive::getPreviousRevision has 1 deployed use, in CirrusSearch

Change 587489 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace PageArchive::getPreviousRevision with getPreviousRevisionRecord

https://gerrit.wikimedia.org/r/587489

Change 587375 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Remove use of WikiPage::getRevision

https://gerrit.wikimedia.org/r/587375

Change 587904 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace uses and hard deprecate Article::getRevisionFetched

https://gerrit.wikimedia.org/r/587904

Change 587396 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article:: and WikiPage::getOldestRevision

https://gerrit.wikimedia.org/r/587396

Change 587487 merged by jenkins-bot:
[mediawiki/core@master] Replace PageArchive::getArchivedRevision with getArchivedRevisionRecord

https://gerrit.wikimedia.org/r/587487

Change 587489 merged by jenkins-bot:
[mediawiki/core@master] Replace PageArchive::getPreviousRevision with getPreviousRevisionRecord

https://gerrit.wikimedia.org/r/587489

Change 588069 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CirrusSearch@master] Remove use of revisions in ApiTrait

https://gerrit.wikimedia.org/r/588069

Change 588164 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FileImporter@master] Remove use of WikiPage::getRevision and other uses of Revision objects

https://gerrit.wikimedia.org/r/588164

Change 588164 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Remove use of WikiPage::getRevision and other uses of Revision objects

https://gerrit.wikimedia.org/r/588164

Change 588069 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove use of revisions in ApiTrait

https://gerrit.wikimedia.org/r/588069

Change 588793 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] Remove a remaining use of Revision objects

https://gerrit.wikimedia.org/r/588793

Change 588796 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FileImporter@master] Tests: Remove use of Title::getFirstRevision

https://gerrit.wikimedia.org/r/588796

Change 588828 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] SpecialMobileDiff::getRevisionsToCompare - return RevisionRecord

https://gerrit.wikimedia.org/r/588828

Change 588796 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Tests: Remove use of Title::getFirstRevision

https://gerrit.wikimedia.org/r/588796

Change 588828 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] SpecialMobileDiff::getRevisionsToCompare - return RevisionRecord

https://gerrit.wikimedia.org/r/588828

Change 589705 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Have CoreParserFunctions::getCachedRevisionObject return RevisionRecord

https://gerrit.wikimedia.org/r/589705

Change 589789 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Make WikiPage::commitRollback internal to prepare for a breaking change

https://gerrit.wikimedia.org/r/589789

Change 589792 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Remove rollback from generateSampleNotifications

https://gerrit.wikimedia.org/r/589792

Change 589913 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] SpecialNewpages::revisionFromRcResult - return RevisionRecord

https://gerrit.wikimedia.org/r/589913

Change 588793 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove a remaining use of Revision objects

https://gerrit.wikimedia.org/r/588793

Change 587904 merged by jenkins-bot:
[mediawiki/core@master] Replace uses and hard deprecate Article::getRevisionFetched

https://gerrit.wikimedia.org/r/587904

Change 592773 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ContentHandler::latestRevision - return RevisionRecord

https://gerrit.wikimedia.org/r/592773

Change 592773 merged by jenkins-bot:
[mediawiki/core@master] ContentHandler::latestRevision - return RevisionRecord

https://gerrit.wikimedia.org/r/592773

Change 589913 merged by jenkins-bot:
[mediawiki/core@master] SpecialNewpages::revisionFromRcResult - return RevisionRecord

https://gerrit.wikimedia.org/r/589913

Change 593090 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Make MessageCacheTest::makePage private, return RevisionRecord

https://gerrit.wikimedia.org/r/593090

Change 589705 merged by jenkins-bot:
[mediawiki/core@master] Have CoreParserFunctions::getCachedRevisionObject return RevisionRecord

https://gerrit.wikimedia.org/r/589705

Change 593785 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of Revision objects in RevisionItem classes

https://gerrit.wikimedia.org/r/593785

Change 593880 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/BlueSpiceExtendedSearch@master] Don't use WikiPage::getOldestRevision(), deprecated in MW 1.35

https://gerrit.wikimedia.org/r/593880

Change 593880 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceExtendedSearch@master] Don't use WikiPage::getOldestRevision(), deprecated in MW 1.35

https://gerrit.wikimedia.org/r/593880

Change 593785 merged by jenkins-bot:
[mediawiki/core@master] Remove use of Revision objects in RevisionItem classes

https://gerrit.wikimedia.org/r/593785

Change 593090 merged by jenkins-bot:
[mediawiki/core@master] Make MessageCacheTest::makePage private, return RevisionRecord

https://gerrit.wikimedia.org/r/593090

Change 604224 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Title::getFirstRevision

https://gerrit.wikimedia.org/r/604224

Change 604224 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Title::getFirstRevision

https://gerrit.wikimedia.org/r/604224

Change 607394 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Parser::fetchTemplateAndTitle - return DeprecatablePropertyArray

https://gerrit.wikimedia.org/r/607394

Change 607394 merged by jenkins-bot:
[mediawiki/core@master] Parser::statelessFetchTemplate - return DeprecatablePropertyArray

https://gerrit.wikimedia.org/r/607394

Change 608101 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Parser: Hard deprecate Revision returned from statelessFetchTemplate

https://gerrit.wikimedia.org/r/608101

Change 608679 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Parser: Set DeprecatablePropertyArray to hard deprecate Revision

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608679

Change 608679 merged by jenkins-bot:
[mediawiki/core@master] Parser: Set DeprecatablePropertyArray to hard deprecate Revision

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608679

Change 608101 abandoned by DannyS712:
Parser: Hard deprecate Revision returned from statelessFetchTemplate

Reason:
I duplicated this in 3f894708bd8a640f9175b0cd8d7b5e958477178b which has already merged

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608101

DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.

Should be done