Page MenuHomePhabricator
Create Task
Maniphest T253949

User::getNewMessageLinks can return Revision objects
Closed, ResolvedPublic
Actions

Description

User::getNewMessageLinks returns an array, which includes a Revision if the user has a new message

None of the known callers outside of core actually use the Revision that is returned; I would suggest making a breaking change to simply return RevisionRecord objects instead

Alternatively, this may make sense to move to the TalkPageNotificationManager, but it relies on WikiMap::getCurrentWikiId() which would force the service to only apply to a specific wiki. Perhaps move it to the service, with the User and the wikiid being parameters?

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+6 -1Hard deprecate User::getNewMessageLinks
mediawiki/coremaster+41 -1Deprecate User::getNewMessageRevisionId
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.May 29 2020, 3:38 AM
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
Pchelolo added a subscriber: Pchelolo.May 29 2020, 4:44 AM

See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/596502 - we opted for just removing the use of this method entirely. Should probably do the same in other occurrences if they exist

DannyS712 added a comment.May 29 2020, 5:16 AM
In T253949#6175452, @Pchelolo wrote:

See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/596502 - we opted for just removing the use of this method entirely. Should probably do the same in other occurrences if they exist

So just hard deprecate the entire method?

Pchelolo added a comment.May 29 2020, 5:32 AM

So just hard deprecate the entire method?

Yup, that was the plan.

gerritbot added a comment.May 29 2020, 5:37 AM

Change 599593 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] User::getNewMessageRevisionId - remove use of User::getNewMessageLinks

https://gerrit.wikimedia.org/r/599593

gerritbot added a project: Patch-For-Review.May 29 2020, 5:37 AM
Pchelolo raised the priority of this task from Medium to High.Jun 2 2020, 4:52 PM
Pchelolo edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.
Pchelolo moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (External Code Reviews) board.
DannyS712 claimed this task.Jun 2 2020, 11:53 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Jun 5 2020, 9:53 PM

Change 599593 merged by jenkins-bot:
[mediawiki/core@master] Deprecate User::getNewMessageRevisionId

https://gerrit.wikimedia.org/r/599593

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 5 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 5 2020, 10:10 PM
Pchelolo closed this task as Resolved.Jun 9 2020, 3:08 AM
Pchelolo moved this task from External Code Review In Progress to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.

I think since the method was deprecated the task can be closed.

DannyS712 reopened this task as Open.Jun 9 2020, 8:17 AM
DannyS712 moved this task from External Code Review Completed to External Code Review Needed on the Platform Team Workboards (External Code Reviews) board.
In T253949#6204494, @Pchelolo wrote:

I think since the method was deprecated the task can be closed.

User::getNewMessageLinks wasn't deprecated, User::getNewMessageRevisionId was

gerritbot added a comment.Jun 10 2020, 2:01 AM

Change 604219 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate User::getNewMessageLinks

https://gerrit.wikimedia.org/r/604219

gerritbot added a project: Patch-For-Review.Jun 10 2020, 2:01 AM
gerritbot added a comment.Jun 10 2020, 3:28 AM

Change 604219 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate User::getNewMessageLinks

https://gerrit.wikimedia.org/r/604219

DannyS712 closed this task as Resolved.Jun 10 2020, 3:45 AM
DannyS712 removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 10 2020, 4:00 AM
DannyS712 moved this task from In progress to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:17 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL