⚓ T251718 Hard deprecate PageArchive::getPreviousRevision

	Subject	Repo	Branch	Lines +/-
	Hard deprecate PageArchive::getPreviousRevision	mediawiki/core	master	+5 -1
	Remove use of PageArchive::getPreviousRevision	mediawiki/extensions/Video	master	+3 -2

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T249393 Deprecate methods returning Revision objects
Resolved	DannyS712	T251718 Hard deprecate PageArchive::getPreviousRevision

DannyS712 triaged this task as Medium priority.May 4 2020, 5:21 AM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 593975 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Video@master] Remove use of PageArchive::getPreviousRevision

https://gerrit.wikimedia.org/r/593975

gerritbot added a project: Patch-For-Review.May 4 2020, 5:22 AM

Change 593975 merged by jenkins-bot:
[mediawiki/extensions/Video@master] Remove use of PageArchive::getPreviousRevision

https://gerrit.wikimedia.org/r/593975

Change 594215 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate PageArchive::getPreviousRevision

https://gerrit.wikimedia.org/r/594215

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.May 4 2020, 3:38 PM

In T251718#6105141, @gerritbot wrote:

Change 594215 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate PageArchive::getPreviousRevision

https://gerrit.wikimedia.org/r/594215

That was pretty easy to replace the uses. Codesearch[1] shows no remaining calls

[1] https://codesearch.wmflabs.org/deployed/?q=-%3EgetPreviousRevision%5C(&i=nope&files=&repos=

Change 594215 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate PageArchive::getPreviousRevision

https://gerrit.wikimedia.org/r/594215

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 7 2020, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 7 2020, 3:10 PM

DannyS712 closed this task as Resolved.May 7 2020, 4:08 PM

DannyS712 mentioned this in T249964: 1.35.0-wmf.32 deployment blockers.May 11 2020, 5:19 PM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:30 AM