Page MenuHomePhabricator
Create Task
Maniphest T249397

Replace LinksUpdate Revision methods with RevisionRecord
Closed, ResolvedPublic
Actions

Description

LinksUpdate::setRevision and LinksUpdate::getRevision need to be replaced

They get and set LinksUpdate::$mRevision, which is otherwise unused (i.e. are only needed to pass Revision information along with the LinksUpdate)

I propose a new LinksUpdate::setRevisionRecord and LinksUpdate::getRevisionRecord be implemented instead

All known calls to getRevision (none in core; all of the calls are deployed on WMF production):

  • Echo - EchoHooks::onLinksUpdateAfterInsert
  • PageTriage - ArticleCompileInterface::getContentByPageId
  • PageTriage - ArticleCompileProcessor::getLastEditTimestamp
  • EventBus - EventBusHooks::onLinksUpdateComplete
  • PageImages - LinksUpdateHookHandler::getPageImageCandidates

Only 1 known call to setRevision:

  • Core - RefreshSecondaryDataUpdate::doUpdate

Details

SubjectRepoBranchLines +/-
Replace uses and hard deprecate LinksUpdate revision methodsmediawiki/coremaster+13 -11
Use LinksUpdate::getRevisionRecordmediawiki/extensions/Echomaster+3 -3
Use LinksUpdate::getRevisionRecordmediawiki/extensions/EventBusmaster+3 -3
Use LinksUpdate::getRevisionRecord in MW 1.35+mediawiki/extensions/PageImagesmaster+14 -13
Use LinksUpdate::getRevisionRecordmediawiki/extensions/PageTriagemaster+5 -4
Add LinksUpdate RevisionRecord methodsmediawiki/coremaster+28 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Apr 4 2020, 2:29 AM
Restricted Application added projects: Growth-Team, Analytics. · View Herald TranscriptApr 4 2020, 2:29 AM
DannyS712 triaged this task as Medium priority.Apr 4 2020, 2:30 AM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
gerritbot added a comment.Apr 4 2020, 2:46 AM

Change 585849 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add LinksUpdate RevisionRecord methods

https://gerrit.wikimedia.org/r/585849

gerritbot added a project: Patch-For-Review.Apr 4 2020, 2:46 AM
• Pchelolo edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).Apr 4 2020, 3:42 AM
Milimetric moved this task from Incoming to Radar on the Analytics board.Apr 6 2020, 4:16 PM
DannyS712 added a parent task: T249561: Deprecate methods accepting Revision objects as parameters.Apr 6 2020, 10:52 PM
gerritbot added a comment.Apr 8 2020, 12:53 AM

Change 585849 merged by jenkins-bot:
[mediawiki/core@master] Add LinksUpdate RevisionRecord methods

https://gerrit.wikimedia.org/r/585849

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 8 2020, 1:00 AM
gerritbot added a comment.Apr 8 2020, 1:08 AM

Change 587385 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageImages@master] Use LinksUpdate::getRevisionRecord in MW 1.35+

https://gerrit.wikimedia.org/r/587385

gerritbot added a comment.Apr 8 2020, 1:10 AM

Change 587387 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Use LinksUpdate::getRevisionRecord

https://gerrit.wikimedia.org/r/587387

gerritbot added a comment.Apr 8 2020, 1:46 AM

Change 587387 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Use LinksUpdate::getRevisionRecord

https://gerrit.wikimedia.org/r/587387

gerritbot added a comment.Apr 8 2020, 1:46 AM

Change 587385 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Use LinksUpdate::getRevisionRecord in MW 1.35+

https://gerrit.wikimedia.org/r/587385

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2020, 2:10 AM
DannyS712 updated the task description. (Show Details)Apr 8 2020, 2:24 AM
gerritbot added a comment.Apr 8 2020, 2:29 AM

Change 587391 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/EventBus@master] Use LinksUpdate::getRevisionRecord

https://gerrit.wikimedia.org/r/587391

gerritbot added a project: Patch-For-Review.Apr 8 2020, 2:29 AM

Change 587392 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Use LinksUpdate::getRevisionRecord

https://gerrit.wikimedia.org/r/587392

gerritbot added a comment.Apr 8 2020, 2:41 AM

Change 587391 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Use LinksUpdate::getRevisionRecord

https://gerrit.wikimedia.org/r/587391

DannyS712 updated the task description. (Show Details)Apr 8 2020, 2:44 AM
gerritbot added a comment.Apr 8 2020, 6:30 AM

Change 587392 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Use LinksUpdate::getRevisionRecord

https://gerrit.wikimedia.org/r/587392

DannyS712 updated the task description. (Show Details)Apr 8 2020, 6:34 AM
gerritbot added a comment.Apr 8 2020, 6:35 AM

Change 587425 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace uses and hard deprecate LinksUpdate revision methods

https://gerrit.wikimedia.org/r/587425

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Apr 8 2020, 6:39 AM
gerritbot added a comment.Apr 10 2020, 12:51 AM

Change 587425 merged by jenkins-bot:
[mediawiki/core@master] Replace uses and hard deprecate LinksUpdate revision methods

https://gerrit.wikimedia.org/r/587425

Maintenance_bot removed a project: Patch-For-Review.Apr 10 2020, 1:10 AM
DannyS712 closed this task as Resolved.Apr 10 2020, 1:36 AM
DannyS712 updated the task description. (Show Details)
DannyS712 mentioned this in T247143: Remove the Revision class [1.37].
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:32 AM
Aklapper edited projects, added Analytics-Radar; removed Analytics.Jun 10 2020, 6:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL