Page MenuHomePhabricator
Create Task
Maniphest T250249

WikiPage::insertProtectNullRevision returns Revision objects
Closed, ResolvedPublic
Actions

Description

WikiPage::insertProtectNullRevision can return Revision objects

It also includes a fallback to $wgUser (the fallback is hard deprecated though)

It should be replaced with a new method that can return RevisionRecord objects, and has no such fallback to $wgUser. I proposed WikiPage::insertNullProtectionRevision

Uses:

  • Core
  • Translate (deployed)
  • ArticleFeedbackv5 (not deployed)

Details

SubjectRepoBranchLines +/-
Use WikiPage::insertNullProtectionRevisionmediawiki/extensions/ArticleFeedbackv5master+1 -1
Hard deprecate WikiPage::insertProtectNullRevisionmediawiki/coremaster+9 -9
Use WikiPage::insertNullProtectionRevision when availablemediawiki/extensions/Translatemaster+23 -8
Add WikiPage::insertNullProtectionRevisionmediawiki/coremaster+39 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Apr 15 2020, 5:41 AM
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Apr 15 2020, 5:42 AM

Change 588836 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add WikiPage::insertNullProtectionRevision

https://gerrit.wikimedia.org/r/588836

gerritbot added a project: Patch-For-Review.Apr 15 2020, 5:42 AM
gerritbot added a comment.Apr 15 2020, 9:38 PM

Change 589138 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Use WikiPage::insertNullProtectionRevision when available

https://gerrit.wikimedia.org/r/589138

gerritbot added a comment.Apr 15 2020, 9:44 PM

Change 588836 merged by jenkins-bot:
[mediawiki/core@master] Add WikiPage::insertNullProtectionRevision

https://gerrit.wikimedia.org/r/588836

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 15 2020, 10:00 PM
gerritbot added a comment.Apr 16 2020, 2:39 PM

Change 589138 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Use WikiPage::insertNullProtectionRevision when available

https://gerrit.wikimedia.org/r/589138

DannyS712 updated the task description. (Show Details)Apr 16 2020, 2:41 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 16 2020, 3:11 PM
gerritbot added a comment.Apr 18 2020, 5:03 AM

Change 589824 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate WikiPage::insertProtectNullRevision

https://gerrit.wikimedia.org/r/589824

gerritbot added a project: Patch-For-Review.Apr 18 2020, 5:03 AM
gerritbot added a comment.Apr 18 2020, 5:09 AM

Change 589826 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ArticleFeedbackv5@master] Use WikiPage::insertNullProtectionRevision

https://gerrit.wikimedia.org/r/589826

DannyS712 added a comment.Apr 18 2020, 5:10 AM
In T250249#6067564, @gerritbot wrote:

Change 589826 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ArticleFeedbackv5@master] Use WikiPage::insertNullProtectionRevision

https://gerrit.wikimedia.org/r/589826

Simple replacement, but not deployed so doesn't need to be merged for hard deprecation to occur

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Apr 18 2020, 5:10 AM
gerritbot added a comment.Apr 19 2020, 1:29 AM

Change 589824 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate WikiPage::insertProtectNullRevision

https://gerrit.wikimedia.org/r/589824

DannyS712 updated the task description. (Show Details)Apr 19 2020, 1:31 AM
gerritbot added a comment.Apr 19 2020, 1:51 AM

Change 589826 merged by jenkins-bot:
[mediawiki/extensions/ArticleFeedbackv5@master] Use WikiPage::insertNullProtectionRevision

https://gerrit.wikimedia.org/r/589826

DannyS712 closed this task as Resolved.Apr 19 2020, 1:52 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 updated the task description. (Show Details)
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:31 AM
DannyS712 mentioned this in T245705: Remove support for calling WikiPage::insertProtectNullRevision functions without passing a user object.Jul 24 2020, 9:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL