Page MenuHomePhabricator

Hard deprecate passing a Revision to WikiPage::prepareContentForEdit
Closed, ResolvedPublic

Description

Already accepts a RevisionRecord (or null, parameter is optional)

A search of deployed uses: https://codesearch.wmflabs.org/deployed/?q=prepareContentForEdit&i=nope&files=&repos=
shows that all calls that pass something other than null are in core, specifically in WikiPageDbTest, and thus passing a Revision can be hard deprecated without needing to fix any existing callers

Event Timeline

Change 606404 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate passing a Revision to WikiPage::prepareContentForEdit

https://gerrit.wikimedia.org/r/606404

DannyS712 triaged this task as Medium priority.Jun 18 2020, 10:28 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.

Change 606404 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate passing a Revision to WikiPage::prepareContentForEdit

https://gerrit.wikimedia.org/r/606404

DannyS712 closed this task as Resolved.Jun 24 2020, 12:33 AM