Page MenuHomePhabricator
Create Task
Maniphest T250023

Replace TitleMoveComplet(e|ing) hooks
Closed, ResolvedPublic
Actions

Assigned To
DannyS712
Authored By
DannyS712
Apr 12 2020, 1:13 AM
Tags
Referenced Files
None
Subscribers
Aklapper
Catrope
DannyS712
• Demian

Description

They use Revision objects, and also pass objects by reference that shouldn't be changed and are only passed for legacy reasons.

  • TitleMoveCompleting -> PageMoveCompleting
  • TitleMoveComplete -> PageMoveComplete

Use RevisionRecord instead of Revision
Don't pass by reference

Deployed extensions to update

TitleMoveCompleting

TitleMoveComplete

Core hard deprecation

Details

SubjectRepoBranchLines +/-
Hard deprecate the `TitleMoveComplete` and `PageContent(Insert|Save)Complete` hooksmediawiki/coremaster+18 -8
Remove use of `TitleMoveComplete` hook in MW 1.35+mediawiki/extensions/Translatemaster+77 -1
Update hooks to use `PageMoveComplete`mediawiki/extensions/FlaggedRevsmaster+18 -6
Update hooks to use `PageMoveComplete` hook in MW 1.35+mediawiki/extensions/Cognatemaster+18 -1
Update hooks to use `PageMoveComplete`mediawiki/extensions/Wikibasemaster+34 -19
Hard deprecate the `TitleMoveCompleting` hookmediawiki/coremaster+2 -3
Update hooks to use `PageMoveComplete`mediawiki/extensions/UploadWizardmaster+15 -6
Update hooks to use `PageMoveComplete` hook in MW 1.35+mediawiki/extensions/GlobalUsagemaster+63 -3
Update hooks to use `PageMoveComplete`mediawiki/extensions/LiquidThreadsmaster+20 -7
Update hooks to use `PageMoveComplete`mediawiki/extensions/JsonConfigmaster+5 -3
Hooks: Replace use of `TitleMoveCompleting` with `PageMoveCompleting`mediawiki/extensions/Flowmaster+13 -11
Update hooks to use `PageMoveComplete`mediawiki/extensions/EventBusmaster+16 -17
Update hooks to use `PageMoveComplete`mediawiki/extensions/CirrusSearchmaster+20 -5
Add PageMoveCompleting hook, to replace TitleMoveCompletingmediawiki/coremaster+61 -7
Hard deprecate the `TitleMoveCompleting` hookmediawiki/coremaster+2 -3
Hooks: Use PageMoveComplete instead of TitleMoveCompletingmediawiki/extensions/Flowmaster+11 -9
Hooks: Update to use `PageMoveComplete` and `PageSaveComplete`mediawiki/extensions/PageTriagemaster+54 -53
Replace TitleMoveCompleting and TitleMoveComplete hooksmediawiki/coremaster+77 -6
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Apr 12 2020, 1:13 AM
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Apr 12 2020, 1:15 AM

Change 588128 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace TitleMoveCompleting and TitleMoveComplete hooks

https://gerrit.wikimedia.org/r/588128

gerritbot added a project: Patch-For-Review.Apr 12 2020, 1:15 AM
DannyS712 mentioned this in T249434: Replace hooks using Revision objects with RevisionRecord.Apr 13 2020, 4:45 AM
gerritbot added a comment.Jun 10 2020, 8:56 PM

Change 588128 merged by jenkins-bot:
[mediawiki/core@master] Replace TitleMoveCompleting and TitleMoveComplete hooks

https://gerrit.wikimedia.org/r/588128

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 10 2020, 9:00 PM
DannyS712 updated the task description. (Show Details)Jun 10 2020, 9:03 PM
gerritbot added a comment.Jun 10 2020, 9:04 PM

Change 604509 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Hooks: Update to use PageMoveComplete and PageSaveComplete

https://gerrit.wikimedia.org/r/604509

DannyS712 added a comment.Jun 11 2020, 3:13 AM
This comment was removed by DannyS712.
gerritbot added a comment.Jun 11 2020, 4:28 AM

Change 604548 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Hooks: Use PageMoveComplete instead of TitleMoveCompleting

https://gerrit.wikimedia.org/r/604548

gerritbot added a comment.Jun 11 2020, 6:40 AM

Change 604548 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Hooks: Use PageMoveComplete instead of TitleMoveCompleting

https://gerrit.wikimedia.org/r/604548

gerritbot added a comment.Jun 15 2020, 9:43 PM

Change 604509 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Hooks: Update to use PageMoveComplete and PageSaveComplete

https://gerrit.wikimedia.org/r/604509

gerritbot added a comment.Jun 15 2020, 9:53 PM

Change 605681 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the TitleMoveCompleting hook

https://gerrit.wikimedia.org/r/605681

gerritbot added a comment.Jun 16 2020, 1:01 AM

Change 605681 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the TitleMoveCompleting hook

https://gerrit.wikimedia.org/r/605681

Maintenance_bot removed a project: Patch-For-Review.Jun 16 2020, 1:10 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.38; 2020-06-23); removed MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 16 2020, 2:00 AM
DannyS712 mentioned this in T255609: Special:MovePage: Invalid atomic section ended (got MovePage::moveUnsafe but expected Flow\BoardMover).Jun 16 2020, 7:52 PM
DannyS712 mentioned this in T255608: DBUnexpectedError when moving a page with a StructuredDiscussion talkpage.
gerritbot added a comment.Jun 17 2020, 5:25 AM

Change 606071 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Add PageMoveCompleting hook, to replace TitleMoveCompleting

https://gerrit.wikimedia.org/r/606071

gerritbot added a project: Patch-For-Review.Jun 17 2020, 5:25 AM
Catrope subscribed.Jun 17 2020, 5:25 AM
In T250023#6230515, @gerritbot wrote:

Change 606071 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Add PageMoveCompleting hook, to replace TitleMoveCompleting

https://gerrit.wikimedia.org/r/606071

See T255608#6230485 for why we need the Completing hook in addition to the Complete hook.

DannyS712 updated the task description. (Show Details)Jun 20 2020, 9:42 AM
gerritbot added a comment.Jun 24 2020, 2:21 AM

Change 606071 merged by jenkins-bot:
[mediawiki/core@master] Add PageMoveCompleting hook, to replace TitleMoveCompleting

https://gerrit.wikimedia.org/r/606071

gerritbot added a comment.Jun 24 2020, 2:22 AM

Change 607398 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Hooks: Replace use of TitleMoveCompleting with PageMoveCompleting

https://gerrit.wikimedia.org/r/607398

DannyS712 mentioned this in T246284: Hard deprecate the Revision class.Jun 25 2020, 3:45 AM
DannyS712 added projects: StructuredDiscussions, PageTriage, Cognate, MediaWiki-extensions-WikibaseClient, CirrusSearch, Event-Platform, MediaWiki-extensions-FlaggedRevs, GlobalUsage, JsonConfig, MediaWiki-extensions-LiquidThreads, MediaWiki-extensions-Translate, UploadWizard.Jun 25 2020, 5:54 PM
DannyS712 updated the task description. (Show Details)
Restricted Application added projects: Growth-Team, Wikidata, Analytics, Discovery-Search. · View Herald TranscriptJun 25 2020, 5:54 PM
gerritbot added a comment.Jun 25 2020, 6:17 PM

Change 607856 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/JsonConfig@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607856

gerritbot added a comment.Jun 25 2020, 6:20 PM

Change 607859 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CirrusSearch@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607859

DannyS712 added a comment.Jun 25 2020, 6:27 PM

To avoid merge conflicts with all of the updates in T250566: Replace PageContent(Insert|Save)Complete hooks, pausing for now

DannyS712 updated the task description. (Show Details)Jun 25 2020, 6:27 PM
gerritbot added a comment.Jun 25 2020, 7:40 PM

Change 607859 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607859

gerritbot added a comment.Jun 25 2020, 7:43 PM

Change 607866 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/EventBus@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607866

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.39; 2020-06-30); removed MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 25 2020, 8:00 PM
gerritbot added a comment.Jun 25 2020, 8:18 PM

Change 607866 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607866

DannyS712 updated the task description. (Show Details)Jun 25 2020, 8:21 PM
gerritbot added a comment.Jun 25 2020, 11:05 PM

Change 607398 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Hooks: Replace use of TitleMoveCompleting with PageMoveCompleting

https://gerrit.wikimedia.org/r/607398

gerritbot added a comment.Jun 25 2020, 11:05 PM

Change 607899 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the TitleMoveCompleting hook

https://gerrit.wikimedia.org/r/607899

DannyS712 updated the task description. (Show Details)Jun 25 2020, 11:07 PM
gerritbot added a comment.Jun 25 2020, 11:09 PM

Change 607900 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607900

gerritbot added a comment.Jun 25 2020, 11:13 PM

Change 607901 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UploadWizard@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607901

gerritbot added a comment.Jun 25 2020, 11:16 PM

Change 607856 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607856

DannyS712 updated the task description. (Show Details)Jun 25 2020, 11:16 PM
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Jun 25 2020, 11:21 PM

Change 607903 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalUsage@master] Update hooks to use PageMoveComplete hook in MW 1.35+

https://gerrit.wikimedia.org/r/607903

gerritbot added a comment.Jun 25 2020, 11:49 PM

Change 607899 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the TitleMoveCompleting hook

https://gerrit.wikimedia.org/r/607899

gerritbot added a comment.Jun 25 2020, 11:49 PM

Change 607900 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607900

gerritbot added a comment.Jun 25 2020, 11:49 PM

Change 607901 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/607901

gerritbot added a comment.Jun 25 2020, 11:49 PM

Change 607903 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@master] Update hooks to use PageMoveComplete hook in MW 1.35+

https://gerrit.wikimedia.org/r/607903

DannyS712 updated the task description. (Show Details)Jun 25 2020, 11:50 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 26 2020, 12:11 AM
gerritbot added a comment.Jun 27 2020, 12:41 AM

Change 608111 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/608111

gerritbot added a project: Patch-For-Review.Jun 27 2020, 12:41 AM
gerritbot added a comment.Jun 27 2020, 12:50 AM

Change 608112 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Remove use of TitleMoveComplete hook in MW 1.35+

https://gerrit.wikimedia.org/r/608112

DannyS712 updated the task description. (Show Details)Jun 27 2020, 12:58 AM
DannyS712 added a comment.Jun 27 2020, 1:02 AM

Update: patches now pending for translate and wikibase

For Cognate, waiting until after https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cognate/+/607840/ (T250566) which will make it easier to have the hook registration vary based on version to maintain backwards compatibility

For flagged revs, waiting until after https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/607716/ (T250566) to avoid merge conflicts and simplify the review queue, since the extension has no maintainer

• Demian subscribed.Jun 27 2020, 1:40 AM
gerritbot added a comment.Jun 30 2020, 3:19 PM

Change 608483 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Cognate@master] Update hooks to use PageMoveComplete hook in MW 1.35+

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cognate/ /608483

gerritbot added a comment.Jun 30 2020, 3:26 PM

Change 608484 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/ /608484

DannyS712 updated the task description. (Show Details)Jun 30 2020, 4:01 PM
gerritbot added a comment.Jun 30 2020, 6:53 PM

Change 608111 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /608111

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 30 2020, 7:00 PM
DannyS712 updated the task description. (Show Details)Jun 30 2020, 7:18 PM
gerritbot added a comment.Jun 30 2020, 11:46 PM

Change 608483 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] Update hooks to use PageMoveComplete hook in MW 1.35+

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cognate/ /608483

gerritbot added a comment.Jun 30 2020, 11:52 PM

Change 608484 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Update hooks to use PageMoveComplete

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/ /608484

gerritbot added a comment.Jul 1 2020, 12:11 AM

Change 608112 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove use of TitleMoveComplete hook in MW 1.35+

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/ /608112

DannyS712 updated the task description. (Show Details)Jul 1 2020, 12:15 AM
gerritbot added a comment.Jul 1 2020, 12:16 AM

Change 608676 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the TitleMoveComplete hook

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608676

DannyS712 updated the task description. (Show Details)Jul 1 2020, 12:18 AM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Jul 1 2020, 2:38 AM

Change 608676 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the TitleMoveComplete and PageContent(Insert|Save)Complete hooks

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608676

DannyS712 closed this task as Resolved.Jul 1 2020, 3:08 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 updated the task description. (Show Details)
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL