Hard deprecate Revision::getSha1
Closed, ResolvedPublic
Actions

Description

Only deployed use outside of core is in Scribunto

Update Scribunto's Scribunto_LuaTitleLibrary::getContentInternal
Update core uses
Hard deprecate

Details

	Subject	Repo	Branch	Lines +/-
	Replace uses and hard deprecate Revision::getSha1	mediawiki/core	master	+30 -1
	Remove use of Parser::fetchCurrentRevisionOfTitle and Revision::getSha1	mediawiki/extensions/Scribunto	master	+3 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T251233 Hard deprecate Revision::getSha1

Event Timeline

DannyS712 triaged this task as Medium priority.Apr 28 2020, 9:33 AM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 589699 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Scribunto@master] Remove use of Parser::fetchCurrentRevisionOfTitle and Revision::getSha1

https://gerrit.wikimedia.org/r/589699

gerritbot added a project: Patch-For-Review.Apr 28 2020, 9:34 AM

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].Apr 28 2020, 9:34 AM

Change 589699 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Remove use of Parser::fetchCurrentRevisionOfTitle and Revision::getSha1

https://gerrit.wikimedia.org/r/589699

DannyS712 mentioned this in rELUAa9b073fc6214: Remove use of Parser::fetchCurrentRevisionOfTitle and Revision::getSha1.Apr 28 2020, 12:49 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 28 2020, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2020, 1:10 PM

DannyS712 updated the task description. (Show Details)Apr 29 2020, 5:35 AM

Change 593095 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace uses and hard deprecate Revision::getSha1

https://gerrit.wikimedia.org/r/593095

gerritbot added a project: Patch-For-Review.Apr 29 2020, 5:37 AM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Apr 29 2020, 5:48 AM

Change 593095 merged by jenkins-bot:
[mediawiki/core@master] Replace uses and hard deprecate Revision::getSha1

https://gerrit.wikimedia.org/r/593095

DannyS712 closed this task as Resolved.Apr 30 2020, 9:04 PM

DannyS712 removed a project: Patch-For-Review.

DannyS712 updated the task description. (Show Details)

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:30 AM