Page MenuHomePhabricator

The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet
Open, Needs TriagePublic

Description

1.31

Event Timeline

Zoranzoki21 added a subscriber: Zoranzoki21.

@Jdforrester-WMF In https://codesearch.wmflabs.org/search/?q=RevisionInsertComplete&i=nope&files=&repos= I found to hard deprecation is scheduled for 1.32 but we are already on 1.33 and 1.34 will be soon released. Should I add wfDeprecated( METHOD, '1.xx' ); in https://gerrit.wikimedia.org/g/mediawiki/core/+/dafe226e8c06f4e69ff6da63fad72a59342f4552/includes/Revision/RevisionStore.php#541 or what?

Restricted Application added a project: User-Zoranzoki21. · View Herald TranscriptSep 15 2019, 11:32 AM
Reedy added a comment.Sep 15 2019, 8:51 PM

Have a look and you should get your answer as to what you should be doing