⚓ T232877 The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet

	Subject	Repo	Branch	Lines +/-
	Hard deprecate the RevisionInsertComplete hook	mediawiki/core	master	+4 -2
	Replace RevisionInsertComplete hook with RevisionRecordInserted	mediawiki/extensions/WikimediaEvents	master	+12 -12

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T249434 Replace hooks using Revision objects with RevisionRecord
Open	None	T232867 Hooks listed as deprecated in MediaWiki should actually be deprecated (and vice versa)
Resolved	DannyS712	T232877 The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet

Jdforrester-WMF created this task.Sep 13 2019, 5:54 PM

@Jdforrester-WMF In https://codesearch.wmflabs.org/search/?q=RevisionInsertComplete&i=nope&files=&repos= I found to hard deprecation is scheduled for 1.32 but we are already on 1.33 and 1.34 will be soon released. Should I add wfDeprecated( METHOD, '1.xx' ); in https://gerrit.wikimedia.org/g/mediawiki/core/+/dafe226e8c06f4e69ff6da63fad72a59342f4552/includes/Revision/RevisionStore.php#541 or what?

Restricted Application added a project: User-Kizule. · View Herald TranscriptSep 15 2019, 11:32 AM

Have you looked at the code for Hooks.php?

https://github.com/wikimedia/mediawiki/blob/master/includes/Hooks.php#L190-L200

In T232877#5494309, @Reedy wrote:

Have you looked at the code for Hooks.php?

https://github.com/wikimedia/mediawiki/blob/master/includes/Hooks.php#L190-L200

No, why?

In T232877#5494310, @Zoranzoki21 wrote:

In T232877#5494309, @Reedy wrote:

Have you looked at the code for Hooks.php?

https://github.com/wikimedia/mediawiki/blob/master/includes/Hooks.php#L190-L200

No, why?

Have a look and you should get your answer as to what you should be doing

Kizule removed Kizule as the assignee of this task.Feb 19 2020, 7:41 PM

Kizule removed a project: User-Kizule.

DannyS712 claimed this task.Mar 28 2020, 3:22 AM

DannyS712 added a parent task: T246284: Hard deprecate the Revision class.

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 28 2020, 3:22 AM

Change 584096 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaEvents@master] Replace RevisionInsertComplete hook with RevisionRecordInserted

https://gerrit.wikimedia.org/r/584096

gerritbot added a project: Patch-For-Review.Mar 28 2020, 3:26 AM

In T232877#6006749, @gerritbot wrote:

Change 584096 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaEvents@master] Replace RevisionInsertComplete hook with RevisionRecordInserted

https://gerrit.wikimedia.org/r/584096

One remaining use needs to be removed before hard deprecation
Should the hook deprecation version be 1.31 or 1.35?

In T232877#6006751, @DannyS712 wrote:

Should the hook deprecation version be 1.31 or 1.35?

1.31, but it helps to add a comment in the code next to it saying when it was hard-deprecated (1.35), to assist with later clean-up.

Change 584096 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Replace RevisionInsertComplete hook with RevisionRecordInserted

https://gerrit.wikimedia.org/r/584096

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 31 2020, 12:00 AM

See also https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EventBus/+/584762 for a documentation-only reference removal.

In T232877#6012954, @Jdforrester-WMF wrote:

In T232877#6006751, @DannyS712 wrote:

Should the hook deprecation version be 1.31 or 1.35?

1.31, but it helps to add a comment in the code next to it saying when it was hard-deprecated (1.35), to assist with later clean-up.

Okay. I'll do this in a bit, to avoid merge conflicts or needing to make stacks

Change 584969 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the RevisionInsertComplete hook

https://gerrit.wikimedia.org/r/584969

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Mar 31 2020, 4:17 PM

Change 584969 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the RevisionInsertComplete hook

https://gerrit.wikimedia.org/r/584969

DannyS712 closed this task as Resolved.Mar 31 2020, 4:53 PM

DannyS712 removed a project: Patch-For-Review.

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.27; 2020-04-07); removed MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 31 2020, 5:00 PM