Page MenuHomePhabricator

The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet
Closed, ResolvedPublic

Description

1.31

Event Timeline

Kizule added a subscriber: Kizule.

@Jdforrester-WMF In https://codesearch.wmflabs.org/search/?q=RevisionInsertComplete&i=nope&files=&repos= I found to hard deprecation is scheduled for 1.32 but we are already on 1.33 and 1.34 will be soon released. Should I add wfDeprecated( METHOD, '1.xx' ); in https://gerrit.wikimedia.org/g/mediawiki/core/+/dafe226e8c06f4e69ff6da63fad72a59342f4552/includes/Revision/RevisionStore.php#541 or what?

In T232877#5494310, @Zoranzoki21 wrote:

Have a look and you should get your answer as to what you should be doing

Kizule removed a project: User-Kizule.

Change 584096 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaEvents@master] Replace RevisionInsertComplete hook with RevisionRecordInserted

https://gerrit.wikimedia.org/r/584096

Change 584096 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaEvents@master] Replace RevisionInsertComplete hook with RevisionRecordInserted

https://gerrit.wikimedia.org/r/584096

One remaining use needs to be removed before hard deprecation
Should the hook deprecation version be 1.31 or 1.35?

Should the hook deprecation version be 1.31 or 1.35?

1.31, but it helps to add a comment in the code next to it saying when it was hard-deprecated (1.35), to assist with later clean-up.

Change 584096 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Replace RevisionInsertComplete hook with RevisionRecordInserted

https://gerrit.wikimedia.org/r/584096

Should the hook deprecation version be 1.31 or 1.35?

1.31, but it helps to add a comment in the code next to it saying when it was hard-deprecated (1.35), to assist with later clean-up.

Okay. I'll do this in a bit, to avoid merge conflicts or needing to make stacks

Change 584969 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the RevisionInsertComplete hook

https://gerrit.wikimedia.org/r/584969

Change 584969 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the RevisionInsertComplete hook

https://gerrit.wikimedia.org/r/584969

Thank you!

No problem. I have nothing to do tomorrow, so I should be able to action the other hooks