⚓ T251593 Hard deprecate Revision::isDeleted

Subject	Repo	Branch	Lines +/-
Hard deprecate Revision::getPrevious and ::isDeleted	mediawiki/core	master	+14 -0
Reduce use of Revision objects in ThanksHooks	mediawiki/extensions/Thanks	master	+29 -10
Remove use of Revision objects in RepoHooks::onPageHistoryLineEnding	mediawiki/extensions/Wikibase	master	+14 -9
Replace Article::$mRevision with RevisionRecord	mediawiki/core	master	+86 -61

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T251593 Hard deprecate Revision::isDeleted

DannyS712 created this task.May 1 2020, 5:55 AM

Restricted Application added projects: Growth-Team, Wikidata. · View Herald TranscriptMay 1 2020, 5:55 AM

DannyS712 triaged this task as Medium priority.May 1 2020, 5:55 AM

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].

DannyS712 updated the task description. (Show Details)May 1 2020, 6:02 PM

Change 593826 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace Article::$mRevision with RevisionRecord

https://gerrit.wikimedia.org/r/593826

gerritbot added a project: Patch-For-Review.May 1 2020, 9:24 PM

DannyS712 updated the task description. (Show Details)May 3 2020, 12:36 AM

Change 594246 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Remove use of Revision objects in RepoHooks::onPageHistoryLineEnding

https://gerrit.wikimedia.org/r/594246

DannyS712 claimed this task.May 4 2020, 6:47 PM

Change 594326 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Reduce use of Revision objects in ThanksHooks

https://gerrit.wikimedia.org/r/594326

Change 593826 merged by jenkins-bot:
[mediawiki/core@master] Replace Article::$mRevision with RevisionRecord

https://gerrit.wikimedia.org/r/593826

DannyS712 updated the task description. (Show Details)May 4 2020, 11:33 PM

Change 594246 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove use of Revision objects in RepoHooks::onPageHistoryLineEnding

https://gerrit.wikimedia.org/r/594246

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 7 2020, 11:00 AM

DannyS712 updated the task description. (Show Details)May 7 2020, 4:04 PM

@BPirkle @cicalese can you take a look at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Thanks/+/594326/ please? Its the only patch remaining before the method can be hard deprecated.

Change 594326 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Reduce use of Revision objects in ThanksHooks

https://gerrit.wikimedia.org/r/594326

Will wait for T251073: Hard deprecate Revision::getPrevious to be ready and hard deprecate them both at the same time - only waiting for https://gerrit.wikimedia.org/r/#/c/599983/

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.35; 2020-06-02); removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 30 2020, 8:03 AM

Change 601916 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getPrevious and ::isDeleted

https://gerrit.wikimedia.org/r/601916

gerritbot added a project: Patch-For-Review.Jun 3 2020, 12:21 AM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Jun 3 2020, 12:25 AM

Change 601916 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getPrevious and ::isDeleted

https://gerrit.wikimedia.org/r/601916

DannyS712 closed this task as Resolved.Jun 3 2020, 2:53 AM

DannyS712 removed a project: Patch-For-Review.

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.36; 2020-06-09); removed MW-1.35-notes (1.35.0-wmf.35; 2020-06-02).Jun 3 2020, 3:00 AM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:15 PM