Hard deprecate Revision::getPrevious
Closed, ResolvedPublic
Actions

Description

Remaining deployed uses:

Core
- EditPage::edit
- DifferenceEngine::showDiffPage and ::loadRevisionData
- RevisionDbTest
CognatePageHookHandler::onPageContentSaveComplete (hook handler, hook needs to be replaced)
MobileFrontendHooks::onDiffViewHeader (hook handler, hook needs to be replaced)
ThanksHooks::insertThankLink (hook handler for HistoryRevisionTools and DiffRevisionTools, both hooks need to be replaced)

Details

Subject	Repo	Branch	Lines +/-
Hard deprecate Revision::getPrevious and ::isDeleted	mediawiki/core	master	+14 -0
MobileFrontendHooks::onDiffViewHeader - reduce use of Revision objects	mediawiki/extensions/MobileFrontend	master	+15 -7
onPageContentSaveComplete - remove use of Revision objects	mediawiki/extensions/Cognate	master	+50 -23
Reduce use of Revision objects in ThanksHooks	mediawiki/extensions/Thanks	master	+29 -10
EditPage::edit - remove use of Revision objects	mediawiki/core	master	+14 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T251073 Hard deprecate Revision::getPrevious

Event Timeline

DannyS712 triaged this task as Medium priority.Apr 27 2020, 4:07 AM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

DannyS712 mentioned this in T225977: Revision::getPrevious() returns null within onNewRevisionFromEditComplete hook.

DannyS712 edited parent tasks, added: T251067: Hard deprecate individual Revision class methods [tracking]; removed: T246284: Hard deprecate the Revision class.

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].

DannyS712 added projects: Cognate, MobileFrontend, Thanks.Apr 27 2020, 4:14 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 27 2020, 4:14 AM

There is nothing to review here, all subtasks are tracked separately. Removed from CPT external code review, moved to "tracking" on the CPT board.

In T251073#6088524, @daniel wrote:

There is nothing to review here, all subtasks are tracked separately. Removed from CPT external code review, moved to "tracking" on the CPT board.

Should I add the external code review tag once there are patches to review?

Change 594326 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Reduce use of Revision objects in ThanksHooks

https://gerrit.wikimedia.org/r/594326

gerritbot added a project: Patch-For-Review.May 4 2020, 10:48 PM

DannyS712 edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.May 4 2020, 10:55 PM

DannyS712 moved this task from Next to In progress on the User-DannyS712 board.

Jdlrobson added a project: Web-Team-Backlog (Tracking).May 4 2020, 11:41 PM

DannyS712 claimed this task.May 5 2020, 9:09 AM

In T251073#6091127, @DannyS712 wrote:

In T251073#6088524, @daniel wrote:

There is nothing to review here, all subtasks are tracked separately. Removed from CPT external code review, moved to "tracking" on the CPT board.

Should I add the external code review tag once there are patches to review?

yes, go ahead

Change 599138 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPage::edit - remove use of Revision objects

https://gerrit.wikimedia.org/r/599138

DannyS712 updated the task description. (Show Details)May 28 2020, 3:28 AM

Change 599138 merged by jenkins-bot:
[mediawiki/core@master] EditPage::edit - remove use of Revision objects

https://gerrit.wikimedia.org/r/599138

DannyS712 updated the task description. (Show Details)May 28 2020, 3:31 AM

Change 599158 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Cognate@master] onPageContentSaveComplete - remove use of Revision objects

https://gerrit.wikimedia.org/r/599158

Change 594326 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Reduce use of Revision objects in ThanksHooks

https://gerrit.wikimedia.org/r/594326

Change 599983 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] MobileFrontendHooks::onDiffViewHeader - reduce use of Revision objects

https://gerrit.wikimedia.org/r/599983

DannyS712 mentioned this in T251593: Hard deprecate Revision::isDeleted.May 29 2020, 8:49 PM

Change 599158 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] onPageContentSaveComplete - remove use of Revision objects

https://gerrit.wikimedia.org/r/599158

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.35; 2020-06-02).May 30 2020, 8:03 AM

DannyS712 updated the task description. (Show Details)Jun 3 2020, 12:15 AM

Change 601916 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getPrevious and ::isDeleted

https://gerrit.wikimedia.org/r/601916

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Jun 3 2020, 12:25 AM

Change 599983 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] MobileFrontendHooks::onDiffViewHeader - reduce use of Revision objects

https://gerrit.wikimedia.org/r/599983

Change 601916 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getPrevious and ::isDeleted

https://gerrit.wikimedia.org/r/601916

DannyS712 closed this task as Resolved.Jun 3 2020, 2:53 AM

DannyS712 removed a project: Patch-For-Review.

DannyS712 updated the task description. (Show Details)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.36; 2020-06-09); removed MW-1.35-notes (1.35.0-wmf.35; 2020-06-02).Jun 3 2020, 3:00 AM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:15 PM