Codesearch: https://codesearch.wmflabs.org/deployed/?q=-%3EgetPage%5C(%5C)&i=nope&files=&repos=
Looks like a lot of uses, but there are other methods by that name; since Revision::getPage returns int|null, its fairly easy to find the calls on Revision objects, since they cannot be ->getPage()->foo().
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T159283 Deprecate non-configuration globals | |||
| Open | DannyS712 | T159299 Deprecate and remove $wgUser | |||
| Resolved | DannyS712 | T267861 [GOAL] Emit deprecation warnings reading from $wgUser | |||
| Open | DannyS712 | T243708 Mediawiki core needs uses of global $wgUser removed | |||
| Resolved | DannyS712 | T246284 Hard deprecate the Revision class | |||
| Resolved | DannyS712 | T251067 Hard deprecate individual Revision class methods [tracking] | |||
| Resolved | DannyS712 | T251853 Hard deprecate Revision::getPage |
Change 594342 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Remove use of WikiPage::doEditContent and the Revision object returned
Change 594342 abandoned by DannyS712:
Remove use of WikiPage::doEditContent and the Revision object returned
Change 604174 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Remove use of the revision returned in WikiPage::doEditContent
Change 604175 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove use of the Revision object returned in WikiPage::doEditContent
Change 604179 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent
Change 604175 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove use of the Revision object returned in WikiPage::doEditContent
Change 604174 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove use of the Revision object returned in WikiPage::doEditContent
Change 604191 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ApiRollback: Reduce use of Revision objects
Change 604179 merged by jenkins-bot:
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent
Change 604197 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent (2)
Change 604207 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] RevisionStoreDbTestBase: Reduce use of Revision from WikiPage::doEditContent
Change 604191 merged by jenkins-bot:
[mediawiki/core@master] ApiRollback: Reduce use of Revision objects
Change 604197 merged by jenkins-bot:
[mediawiki/core@master] Remove use of the Revision object returned in WikiPage::doEditContent (2)
Change 604207 merged by jenkins-bot:
[mediawiki/core@master] RevisionStoreDbTestBase: Reduce use of Revision from WikiPage::doEditContent
There are a number of methods with the same name, making searching for existing uses hard. That being said, I could not find any remaining deployed uses outside of tests, and I believe that we can hard deprecate the method. If I missed any of the uses, there would be some logspam, but no code should break. Once the deprecation is merged, I'll leave a note on the blockers task for the week with a heads-up
Change 604237 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getPage
Change 604237 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getPage and ::getComment