But, rather than deprecating just not passing a user, the whole function should be deprecated as part of MCR migration to RevisionRecord, which already requires a user for the equivalent function
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Hard deprecate Revision::userCanBitfield | mediawiki/core | master | +66 -14 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T159283 Deprecate non-configuration globals | |||
| Open | DannyS712 | T159299 Deprecate and remove $wgUser | |||
| Resolved | DannyS712 | T267861 [GOAL] Emit deprecation warnings reading from $wgUser | |||
| Open | DannyS712 | T243708 Mediawiki core needs uses of global $wgUser removed | |||
| Resolved | DannyS712 | T242935 Deprecate core fallbacks to $wgUser | |||
| Resolved | DannyS712 | T246284 Hard deprecate the Revision class | |||
| Resolved | DannyS712 | T251067 Hard deprecate individual Revision class methods [tracking] | |||
| Resolved | DannyS712 | T245958 Revision::userCanBitfield falls back to $wgUser |
Event Timeline
Comment Actions
Change 574253 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::userCanBitfield
Comment Actions
Callers that accepted a null user and relied on the fallback to $wgUser had fallbacks added individually, and support for not passing a user soft deprecated. To fix:
- Revision::userCan
- ArchivedFile::userCan
- OldLocalFile::userCan
Comment Actions
Change 574253 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::userCanBitfield
Comment Actions
This patch soft deprecated not providing a user to callers, since they need a user. The following methods now use $wgUser as a fallback (previously the fallback was within userCanBitfield)
- Revision::userCan
- ArchivedFile::userCan
- OldLocalFile::userCan