Page MenuHomePhabricator

Hard deprecate Revision::isCurrent
Closed, ResolvedPublic

Description

Only deployed use outside of core is in Wikibase

However, the relevant method accepts a Revision object as a parameter, and will need to be updated to RevisionRecord anyway (this is DifferenceEngine::getRevisionHeader)

Method should accept RevisionRecord rather than just using Revision::getRevisionRecord where needed

Event Timeline

DannyS712 triaged this task as Medium priority.Apr 19 2020, 9:46 AM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 590282 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] EntityContentDiffView::getRevisionHeader - don't require Revisions

https://gerrit.wikimedia.org/r/590282

Change 590283 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] DifferenceEngine::getRevisionHeader - accept a RevisionRecord

https://gerrit.wikimedia.org/r/590283

Change 590282 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityContentDiffView::getRevisionHeader - don't require Revisions

https://gerrit.wikimedia.org/r/590282

Change 590283 merged by jenkins-bot:
[mediawiki/core@master] DifferenceEngine::getRevisionHeader - accept a RevisionRecord

https://gerrit.wikimedia.org/r/590283

Change 593826 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace Article::$mRevision with RevisionRecord

https://gerrit.wikimedia.org/r/593826

Change 593826 merged by jenkins-bot:
[mediawiki/core@master] Replace Article::$mRevision with RevisionRecord

https://gerrit.wikimedia.org/r/593826

Remaining uses:

  • RevisionDbTest
  • DifferenceEngine

DifferenceEngine will be fixed in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593272/ soon, and then hard deprecation can occur

Change 598865 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getUserText, ::isMinor, and ::isCurrent

https://gerrit.wikimedia.org/r/598865

Change 598865 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getUserText, ::isMinor, and ::isCurrent

https://gerrit.wikimedia.org/r/598865

DannyS712 closed this task as Resolved.May 27 2020, 6:35 PM
DannyS712 removed a project: Patch-For-Review.