Hard deprecate Revision::insertOn
Closed, ResolvedPublic
Actions

Description

All deployed uses are in core: https://codesearch.wmflabs.org/deployed/?q=-%3EinsertOn%5C(&i=nope&files=&repos=

MovePage::moveToInternal
ImportableOldRevisionImporter::import

And RevisionDbTest, which will ignore the deprecation when it occurs

Details

Subject	Repo	Branch	Lines +/-
Hard deprecate Revision::insertOn	mediawiki/core	master	+11 -0
ImportableOldRevisionImporter: Remove use of Revision::insertOn	mediawiki/core	master	+36 -18
MovePage::moveToInternal - remove use of Revision::insertOn	mediawiki/core	master	+25 -16

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T251856 Hard deprecate Revision::insertOn

Event Timeline

DannyS712 triaged this task as Medium priority.May 5 2020, 3:37 AM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].

Change 594346 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] MovePage::moveToInternal - remove use of Revision::insertOn

https://gerrit.wikimedia.org/r/594346

gerritbot added a project: Patch-For-Review.May 5 2020, 3:41 AM

Change 594416 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ImportableOldRevisionImporter: Remove use of Revision objects

https://gerrit.wikimedia.org/r/594416

Change 594346 merged by jenkins-bot:
[mediawiki/core@master] MovePage::moveToInternal - remove use of Revision::insertOn

https://gerrit.wikimedia.org/r/594346

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 6 2020, 1:00 AM

DannyS712 updated the task description. (Show Details)May 6 2020, 1:01 AM

Change 594416 merged by jenkins-bot:
[mediawiki/core@master] ImportableOldRevisionImporter: Remove use of Revision::insertOn

https://gerrit.wikimedia.org/r/594416

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 21 2020, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 21 2020, 3:10 AM

DannyS712 updated the task description. (Show Details)May 21 2020, 3:18 AM

Change 597665 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::insertOn

https://gerrit.wikimedia.org/r/597665