⚓ T255495 Replace `DiffRevisionTools` hook with `DiffTools`

Subject	Repo	Branch	Lines +/-
Hard deprecate `DiffRevisionTools` and `HistoryRevisionTools` hooks	mediawiki/core	master	+6 -8
Add `HistoryTools` and `DiffTools` hooks	mediawiki/core	master	+92 -4
Use new `HistoryTools` and `DiffTools` hooks	mediawiki/extensions/Thanks	master	+16 -11

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T249434 Replace hooks using Revision objects with RevisionRecord
Resolved	DannyS712	T255495 Replace `DiffRevisionTools` hook with `DiffTools`

DannyS712 triaged this task as Medium priority.Jun 15 2020, 9:17 PM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

Change 605670 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add HistoryTools and DiffTools hooks

https://gerrit.wikimedia.org/r/605670

gerritbot added a project: Patch-For-Review.Jun 15 2020, 9:19 PM

In deployed code, only used in the Thanks extension

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 15 2020, 9:33 PM

Change 605674 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Use new HistoryTools and DiffTools hooks

https://gerrit.wikimedia.org/r/605674

DannyS712 mentioned this in T249434: Replace hooks using Revision objects with RevisionRecord.Jun 15 2020, 11:25 PM

DannyS712 claimed this task.Jun 18 2020, 1:26 PM

Change 605670 merged by jenkins-bot:
[mediawiki/core@master] Add HistoryTools and DiffTools hooks

https://gerrit.wikimedia.org/r/605670

Change 605674 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Use new HistoryTools and DiffTools hooks

https://gerrit.wikimedia.org/r/605674

Change 607392 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate DiffRevisionTools and HistoryRevisionTools hooks

https://gerrit.wikimedia.org/r/607392

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Jun 24 2020, 1:00 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 24 2020, 1:00 AM

Change 607392 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate DiffRevisionTools and HistoryRevisionTools hooks

https://gerrit.wikimedia.org/r/607392

DannyS712 closed this task as Resolved.Jun 24 2020, 1:32 AM

DannyS712 removed a project: Patch-For-Review.

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:13 PM