Page MenuHomePhabricator

Hard deprecate Revision::getComment
Closed, ResolvedPublic

Description

Revision::getComment should be hard deprecated

https://codesearch.wmflabs.org/deployed/?q=-%3EgetComment%5C(&i=nope&files=&repos=

There are a number of methods with the same name, making searching for existing uses hard. That being said, I believe the only remaining uses are:

  • RevisionStoreDbTestBase::revisionToRow
  • RevisionDbTest
  • RevisionTest
  • ApiRevisionDeleteTest
  • WikiPageDbTest::testInsertProtectNullRevision

Thus, I believe that we can hard deprecate the method. If I missed any of the uses, there would be some logspam, but no code should break. Once the deprecation is merged, I'll leave a note on the blockers task for the week with a heads-up

Event Timeline

DannyS712 triaged this task as Medium priority.Jun 10 2020, 3:57 AM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)

Change 604237 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getPage and ::getComment

https://gerrit.wikimedia.org/r/604237

Change 604237 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getPage and ::getComment

https://gerrit.wikimedia.org/r/604237

DannyS712 closed this task as Resolved.Jun 10 2020, 5:01 AM
DannyS712 removed a project: Patch-For-Review.