Description

Revision::getComment should be hard deprecated

https://codesearch.wmflabs.org/deployed/?q=-%3EgetComment%5C(&i=nope&files=&repos=

There are a number of methods with the same name, making searching for existing uses hard. That being said, I believe the only remaining uses are:

Thus, I believe that we can hard deprecate the method. If I missed any of the uses, there would be some logspam, but no code should break. Once the deprecation is merged, I'll leave a note on the blockers task for the week with a heads-up

Details

	Subject	Repo	Branch	Lines +/-
	Hard deprecate Revision::getPage and ::getComment	mediawiki/core	master	+28 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T254960 Hard deprecate Revision::getComment

Event Timeline

DannyS712 triaged this task as Medium priority.Jun 10 2020, 3:57 AM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

DannyS712 updated the task description. (Show Details)

DannyS712 claimed this task.Jun 10 2020, 4:06 AM

DannyS712 updated the task description. (Show Details)

Change 604237 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getPage and ::getComment

https://gerrit.wikimedia.org/r/604237

gerritbot added a project: Patch-For-Review.Jun 10 2020, 4:10 AM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Jun 10 2020, 4:11 AM

Change 604237 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getPage and ::getComment

https://gerrit.wikimedia.org/r/604237

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 10 2020, 5:00 AM

DannyS712 closed this task as Resolved.Jun 10 2020, 5:01 AM

DannyS712 removed a project: Patch-For-Review.

DannyS712 mentioned this in T254174: 1.35.0-wmf.37 deployment blockers.Jun 10 2020, 5:03 AM

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:14 PM