ArticleRevisionUndeleted uses a revision, but only a revision record is needed, and the use of revision should be removed
- Add new hook
- Update Flow
- Update LiquidThreads
- Update FlaggedRevs
- Deprecate old hook
ArticleRevisionUndeleted uses a revision, but only a revision record is needed, and the use of revision should be removed
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T11968 Reduce use of global and public variables | |||
Open | None | T159283 Deprecate non-configuration globals | |||
Open | DannyS712 | T159299 Deprecate and remove $wgUser | |||
Resolved | DannyS712 | T267861 [GOAL] Emit deprecation warnings reading from $wgUser | |||
Open | DannyS712 | T243708 Mediawiki core needs uses of global $wgUser removed | |||
Resolved | DannyS712 | T246284 Hard deprecate the Revision class | |||
Resolved | DannyS712 | T249434 Replace hooks using Revision objects with RevisionRecord | |||
Resolved | DannyS712 | T248727 Replace ArticleRevisionUndeleted with RevisionUndeleted |
Change 584098 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add RevisionRecordUndeleted hook
Note: all three extensions require 1.35+, and so they do not need to maintain support for the deprecated hook to work for versions where the new one doesn't exist
Change 587546 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Replace ArticleRevisionUndeleted with RevisionUndeleted
Change 587548 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Replace ArticleRevisionUndeleted with RevisionUndeleted
Change 584098 merged by jenkins-bot:
[mediawiki/core@master] Add RevisionUndeleted hook to replace ArticleRevisionUndeleted
I sent patches for LiquidThreads and Flow, but I'll wait on FlaggedRevs until after https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/585376/ (cc @Pchelolo)
Change 587548 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace ArticleRevisionUndeleted with RevisionUndeleted
Change 587546 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Replace ArticleRevisionUndeleted with RevisionUndeleted
Change 588802 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Replace ArticleRevisionUndeleted with RevisionUndeleted
Change 588805 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] RevisionUndeleted hook: Add $oldPageId
Change 588806 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Fix RevisionUndeleted handler
Change 588807 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Fix RevisionUndeleted handler
^ So I messed up on my understanding of the old page id parameter. Sent patches to add it to the hook and then update the extensions
Change 588805 merged by jenkins-bot:
[mediawiki/core@master] RevisionUndeleted hook: Add $oldPageId
Change 588807 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Fix RevisionUndeleted handler
Change 588806 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix RevisionUndeleted handler
Change 588815 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.28] RevisionUndeleted hook: Add $oldPageId
Change 588816 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@wmf/1.35.0-wmf.28] Fix RevisionUndeleted handler
Change 588817 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@wmf/1.35.0-wmf.28] Fix RevisionUndeleted handler
Change 588815 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.28] RevisionUndeleted hook: Add $oldPageId
Change 588817 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.35.0-wmf.28] Fix RevisionUndeleted handler
Change 588816 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@wmf/1.35.0-wmf.28] Fix RevisionUndeleted handler
Mentioned in SAL (#wikimedia-operations) [2020-04-15T13:23:37Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.28/includes/page/PageArchive.php: T248727 Fix RevisionUndeleted hook to add (duration: 01m 08s)
Mentioned in SAL (#wikimedia-operations) [2020-04-15T13:25:24Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.28/extensions/LiquidThreads/classes/DeletionController.php: T248727 Adjust to RevisionUndeleted hook now having (duration: 01m 06s)
Mentioned in SAL (#wikimedia-operations) [2020-04-15T13:26:50Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.28/extensions/Flow/Hooks.php: T248727 Adjust to RevisionUndeleted hook now having (duration: 01m 04s)
Change 588802 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Replace ArticleRevisionUndeleted with RevisionUndeleted
Change 589015 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the ArticleRevisionUndeleted hook
Change 589015 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the ArticleRevisionUndeleted hook