Replace ArticleRevisionUndeleted with RevisionUndeleted
Closed, ResolvedPublic
Actions

Description

ArticleRevisionUndeleted uses a revision, but only a revision record is needed, and the use of revision should be removed

Details

Subject	Repo	Branch	Lines +/-
Hard deprecate the `ArticleRevisionUndeleted` hook	mediawiki/core	master	+6 -4
Replace ArticleRevisionUndeleted with RevisionUndeleted	mediawiki/extensions/FlaggedRevs	master	+4 -5
Fix RevisionUndeleted handler	mediawiki/extensions/Flow	wmf/1.35.0-wmf.28	+3 -2
Fix RevisionUndeleted handler	mediawiki/extensions/LiquidThreads	wmf/1.35.0-wmf.28	+2 -3
RevisionUndeleted hook: Add $oldPageId	mediawiki/core	wmf/1.35.0-wmf.28	+2 -1
RevisionUndeleted hook: Add $oldPageId	mediawiki/core	master	+2 -1
Fix RevisionUndeleted handler	mediawiki/extensions/Flow	master	+3 -2
Fix RevisionUndeleted handler	mediawiki/extensions/LiquidThreads	master	+2 -3
Replace ArticleRevisionUndeleted with RevisionUndeleted	mediawiki/extensions/Flow	master	+12 -8
Replace ArticleRevisionUndeleted with RevisionUndeleted	mediawiki/extensions/LiquidThreads	master	+8 -4
Add RevisionUndeleted hook to replace ArticleRevisionUndeleted	mediawiki/core	master	+12 -1

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T249434 Replace hooks using Revision objects with RevisionRecord
Resolved	DannyS712	T248727 Replace ArticleRevisionUndeleted with RevisionUndeleted

Event Timeline

DannyS712 triaged this task as Medium priority.Mar 28 2020, 3:53 AM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 584098 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add RevisionRecordUndeleted hook

https://gerrit.wikimedia.org/r/584098

gerritbot added a project: Patch-For-Review.Mar 28 2020, 3:54 AM

DannyS712 added projects: MediaWiki-extensions-LiquidThreads, StructuredDiscussions, MediaWiki-extensions-FlaggedRevs.Mar 28 2020, 3:57 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 28 2020, 3:57 AM

DannyS712 moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Mar 28 2020, 3:58 AM

Note: all three extensions require 1.35+, and so they do not need to maintain support for the deprecated hook to work for versions where the new one doesn't exist

DannyS712 edited parent tasks, added: T249434: Replace hooks using Revision objects with RevisionRecord; removed: T246284: Hard deprecate the Revision class.Apr 4 2020, 9:54 PM

DannyS712 mentioned this in T249434: Replace hooks using Revision objects with RevisionRecord.Apr 4 2020, 10:03 PM

daniel moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Apr 8 2020, 11:35 AM

DannyS712 renamed this task from Replace ArticleRevisionUndeleted with RevisionRecordUndeleted to Replace ArticleRevisionUndeleted with RevisionUndeleted.Apr 8 2020, 12:49 PM

Change 587546 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Replace ArticleRevisionUndeleted with RevisionUndeleted

https://gerrit.wikimedia.org/r/587546

Change 587548 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Replace ArticleRevisionUndeleted with RevisionUndeleted

https://gerrit.wikimedia.org/r/587548

Change 584098 merged by jenkins-bot:
[mediawiki/core@master] Add RevisionUndeleted hook to replace ArticleRevisionUndeleted

https://gerrit.wikimedia.org/r/584098

I sent patches for LiquidThreads and Flow, but I'll wait on FlaggedRevs until after https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/585376/ (cc @Pchelolo)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 8 2020, 5:00 PM

Change 587548 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace ArticleRevisionUndeleted with RevisionUndeleted

https://gerrit.wikimedia.org/r/587548

DannyS712 updated the task description. (Show Details)Apr 8 2020, 7:01 PM

Change 587546 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Replace ArticleRevisionUndeleted with RevisionUndeleted

https://gerrit.wikimedia.org/r/587546

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2020, 7:10 PM

DannyS712 updated the task description. (Show Details)Apr 8 2020, 7:21 PM

DannyS712 added a project: MediaWiki-Core-Hooks.Apr 11 2020, 11:06 AM

DannyS712 moved this task from Untriaged to Deprecate/remove on the MediaWiki-Core-Hooks board.

Krinkle removed a project: MediaWiki-Core-Hooks.Apr 11 2020, 5:46 PM

Change 588802 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Replace ArticleRevisionUndeleted with RevisionUndeleted

https://gerrit.wikimedia.org/r/588802

gerritbot added a project: Patch-For-Review.Apr 14 2020, 10:25 PM

Change 588805 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] RevisionUndeleted hook: Add $oldPageId

https://gerrit.wikimedia.org/r/588805

Change 588806 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Fix RevisionUndeleted handler

https://gerrit.wikimedia.org/r/588806

Change 588807 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Fix RevisionUndeleted handler

https://gerrit.wikimedia.org/r/588807

^ So I messed up on my understanding of the old page id parameter. Sent patches to add it to the hook and then update the extensions

Change 588805 merged by jenkins-bot:
[mediawiki/core@master] RevisionUndeleted hook: Add $oldPageId

https://gerrit.wikimedia.org/r/588805

Change 588807 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Fix RevisionUndeleted handler

https://gerrit.wikimedia.org/r/588807

Change 588806 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix RevisionUndeleted handler

https://gerrit.wikimedia.org/r/588806

Change 588815 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.28] RevisionUndeleted hook: Add $oldPageId

https://gerrit.wikimedia.org/r/588815

Change 588816 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@wmf/1.35.0-wmf.28] Fix RevisionUndeleted handler

https://gerrit.wikimedia.org/r/588816

Change 588817 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@wmf/1.35.0-wmf.28] Fix RevisionUndeleted handler

https://gerrit.wikimedia.org/r/588817

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 15 2020, 12:00 AM

DannyS712 mentioned this in T247775: 1.35.0-wmf.28 deployment blockers.Apr 15 2020, 12:07 AM

Change 588815 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.28] RevisionUndeleted hook: Add $oldPageId

https://gerrit.wikimedia.org/r/588815

Change 588817 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.35.0-wmf.28] Fix RevisionUndeleted handler

https://gerrit.wikimedia.org/r/588817

Change 588816 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@wmf/1.35.0-wmf.28] Fix RevisionUndeleted handler

https://gerrit.wikimedia.org/r/588816

Mentioned in SAL (#wikimedia-operations) [2020-04-15T13:23:37Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.28/includes/page/PageArchive.php: T248727 Fix RevisionUndeleted hook to add (duration: 01m 08s)

Mentioned in SAL (#wikimedia-operations) [2020-04-15T13:25:24Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.28/extensions/LiquidThreads/classes/DeletionController.php: T248727 Adjust to RevisionUndeleted hook now having (duration: 01m 06s)

Mentioned in SAL (#wikimedia-operations) [2020-04-15T13:26:50Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.28/extensions/Flow/Hooks.php: T248727 Adjust to RevisionUndeleted hook now having (duration: 01m 04s)

Change 588802 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Replace ArticleRevisionUndeleted with RevisionUndeleted

https://gerrit.wikimedia.org/r/588802

Change 589015 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the ArticleRevisionUndeleted hook

https://gerrit.wikimedia.org/r/589015

Jdforrester-WMF updated the task description. (Show Details)Apr 15 2020, 1:37 PM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Apr 15 2020, 1:41 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.28; 2020-04-14); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 15 2020, 2:00 PM

Change 589015 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the ArticleRevisionUndeleted hook

https://gerrit.wikimedia.org/r/589015

DannyS712 closed this task as Resolved.Apr 15 2020, 7:22 PM

DannyS712 removed a project: Patch-For-Review.

DannyS712 updated the task description. (Show Details)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 15 2020, 8:01 PM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:31 AM