Page MenuHomePhabricator

Deprecate not passing a user to ParserOptions::__construct and ::newCanonical
Open, Needs TriagePublic

Description

If a user isn't provided, it uses global $wgUser

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/EventLoggingmaster+3 -2
mediawiki/extensions/Quizmaster+2 -2
mediawiki/coremaster+25 -16
mediawiki/extensions/ProofreadPagemaster+1 -1
mediawiki/extensions/AbuseFiltermaster+13 -4
mediawiki/extensions/ParserMigrationmaster+1 -1
mediawiki/extensions/MultiBoilerplatemaster+3 -1
mediawiki/extensions/SecurePollmaster+4 -1
mediawiki/extensions/Wikibasemaster+2 -2
mediawiki/extensions/PhpTagsStoragemaster+1 -1
mediawiki/extensions/MintyDocsmaster+5 -1
mediawiki/extensions/GrowthExperimentsmaster+1 -1
mediawiki/extensions/ProofreadPagemaster+3 -1
mediawiki/extensions/BlueSpiceRSSFeedermaster+2 -2
mediawiki/extensions/TEImaster+1 -1
mediawiki/extensions/CollaborationKitmaster+5 -5
mediawiki/extensions/MassMessageEmailmaster+1 -1
mediawiki/extensions/Wikibasemaster+9 -9
mediawiki/extensions/NewUserMessagemaster+6 -2
mediawiki/extensions/LiquidThreadsmaster+2 -2
mediawiki/extensions/Mathmaster+1 -1
mediawiki/extensions/Newsmaster+4 -3
mediawiki/extensions/MediaWikiChatmaster+1 -1
mediawiki/extensions/Scribuntomaster+9 -4
mediawiki/extensions/Babelmaster+1 -1
mediawiki/coremaster+1 -1
mediawiki/extensions/Kartographermaster+3 -3
mediawiki/extensions/MassMessagemaster+1 -1
mediawiki/extensions/Flowmaster+11 -4
mediawiki/extensions/FeaturedFeedsmaster+23 -12
mediawiki/extensions/Echomaster+4 -4
mediawiki/extensions/intersectionmaster+1 -1
mediawiki/extensions/Commentsmaster+1 -1
mediawiki/extensions/FileImportermaster+13 -5
mediawiki/extensions/ConfirmEditmaster+1 -1
mediawiki/extensions/Graphmaster+1 -1
mediawiki/extensions/NewsTickermaster+1 -1
mediawiki/extensions/DocBookExportmaster+1 -1
mediawiki/extensions/TwoColConflictmaster+1 -1
mediawiki/extensions/VisualEditormaster+1 -1
mediawiki/skins/eruditemaster+1 -1
mediawiki/extensions/VEForAllmaster+1 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 576523 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576523

Change 576525 merged by jenkins-bot:
[mediawiki/extensions/VEForAll@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576525

Change 576522 merged by jenkins-bot:
[mediawiki/skins/erudite@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576522

Change 576616 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576616

Change 576613 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576613

Change 576615 merged by jenkins-bot:
[mediawiki/extensions/DocBookExport@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576615

Change 576611 merged by jenkins-bot:
[mediawiki/extensions/NewsTicker@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576611

Change 576617 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576617

Change 576914 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576914

Change 576915 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576915

Change 576916 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576916

Change 576917 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Comments@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576917

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Mar 4 2020, 8:00 PM

Change 576915 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576915

Change 576917 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576917

Change 576612 merged by jenkins-bot:
[mediawiki/extensions/intersection@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576612

@Hexmode @MarkAHershberger heads up that there is a use in in hexmode / mediawiki-UserSnoop's UserSnoop\Pager::sandboxParse there is a new ParserOptions(); call that will need a user

Change 577406 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FeaturedFeeds@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577406

Change 577406 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577406

Change 577710 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Math@master] User ParserOptions::newFromAnon instead of relying on wgUser

https://gerrit.wikimedia.org/r/577710

Change 577711 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MediaWikiChat@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577711

Change 577712 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MultiBoilerplate@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577712

Change 577713 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/News@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577713

Change 577714 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/NewUserMessage@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577714

Change 577716 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ProofreadPage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577716

Change 577717 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Scribunto@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577717

Change 577718 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MintyDocs@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577718

Change 577719 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577719

Change 576914 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576914

Change 577720 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577720

Change 577721 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] MessageCache: Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577721

Change 577722 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577722

Change 577723 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Kartographer@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577723

Change 577724 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Babel@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577724

Change 577719 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577719

Change 577721 merged by jenkins-bot:
[mediawiki/core@master] MessageCache: Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577721

Change 577723 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577723

Change 577724 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577724

Change 577717 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577717

Change 577710 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577710

Change 577711 merged by jenkins-bot:
[mediawiki/extensions/MediaWikiChat@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577711

Change 577713 merged by jenkins-bot:
[mediawiki/extensions/News@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577713

Change 577921 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceRSSFeeder@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577921

Change 577925 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CollaborationKit@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577925

Change 577927 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SecurePoll@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577927

Change 577930 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PhpTagsStorage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577930

Change 577931 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessageEmail@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577931

Change 578043 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TEI@master] Pass a user to ParserOptions::newCanonical

https://gerrit.wikimedia.org/r/578043

Change 577720 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577720

Change 577714 merged by jenkins-bot:
[mediawiki/extensions/NewUserMessage@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577714

Change 577722 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577722

Change 577925 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577925

Change 577931 merged by jenkins-bot:
[mediawiki/extensions/MassMessageEmail@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577931

Change 578043 merged by jenkins-bot:
[mediawiki/extensions/TEI@master] Replace ParserOptions::newCanonical with ::newFromUser, pass a user

https://gerrit.wikimedia.org/r/578043

Change 579111 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/579111

Change 579112 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ParserMigration@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/579112

Change 579113 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GrowthExperiments@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/579113

Change 577921 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceRSSFeeder@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577921

Change 577716 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577716

Change 579113 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Pass 'canonical' for creating ParserOptions instead of using on $wgUser

https://gerrit.wikimedia.org/r/579113

Uses of new ParserOptions in deployed extensions that still need to be updated:

  • SecurePoll
  • EventLogging
  • EntitySchema
  • CollaborationKit
  • AbuseFilter
  • Quiz
  • Flow
  • Wikibase

Also: core, vendor

Uses of ParserOptions::newCanonical in deployed extensions that still need to be updated:

  • Wikibase
  • ProofreadPage

Also: parsoid, vendor, core

Change 577718 merged by jenkins-bot:
[mediawiki/extensions/MintyDocs@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577718

Change 577930 merged by Umherirrender:
[mediawiki/extensions/PhpTagsStorage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577930

Change 579111 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don’t rely on $wgUser when creating ParserOptions in test

https://gerrit.wikimedia.org/r/579111

Change 577927 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Use ParserOptions::newFromUser with conext user

https://gerrit.wikimedia.org/r/577927

Change 577712 merged by jenkins-bot:
[mediawiki/extensions/MultiBoilerplate@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577712

Change 579112 merged by jenkins-bot:
[mediawiki/extensions/ParserMigration@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/579112

Huji closed this task as Resolved.May 11 2020, 2:44 PM
Huji added a subscriber: Huji.

All associated patches have been merged.

DannyS712 reopened this task as Open.May 11 2020, 2:45 PM

All associated patches have been merged.

There are more replacements left that I haven't sent patches for :)

Huji added a comment.May 11 2020, 2:46 PM

Oops. Shortsighted action on my part. Thank you for all the hard work!

And here I was just trying to set up my Vagrant env to review this. Oh well. Thanks, guys!

Change 595541 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ProofreadPage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/595541

Change 576916 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Use ParserOptions::newFromUser() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/576916

Change 595541 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/595541

Change 605694 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate calling ParserOptions::newCanonical with no parameters

https://gerrit.wikimedia.org/r/605694

Change 605694 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate calling ParserOptions::newCanonical with no parameters

https://gerrit.wikimedia.org/r/605694

Change 606787 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/EventLogging@master] JsonSchemaTest: Pass a user when creating ParserOptions

https://gerrit.wikimedia.org/r/606787

Change 606788 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Quiz@master] Tests: Pass a user when creating ParserOptions objects

https://gerrit.wikimedia.org/r/606788

Change 606787 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] JsonSchemaTest: Pass a user when creating ParserOptions

https://gerrit.wikimedia.org/r/606787