Rather than making sure it callers pass a user parameter, it should just be deprecated entirely (see also T239975: Complete WikiPage/Article split and deprecate Page interface)
Then, once the wikipage function requires a user, we can just remove the article function
It has no known callers: https://codesearch.wmflabs.org/search/?q=-%3EinsertProtectNullRevision%5C(&i=nope&files=&repos=
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Hard deprecate Article::insertProtectNullRevision | mediawiki/core | master | +4 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T159283 Deprecate non-configuration globals | |||
| Open | DannyS712 | T159299 Deprecate and remove $wgUser | |||
| Resolved | DannyS712 | T267861 [GOAL] Emit deprecation warnings reading from $wgUser | |||
| Open | DannyS712 | T243708 Mediawiki core needs uses of global $wgUser removed | |||
| Resolved | DannyS712 | T245331 Remove core fallbacks to global $wgUser [1.36] | |||
| Invalid | None | T245705 Remove support for calling WikiPage::insertProtectNullRevision functions without passing a user object | |||
| Resolved | DannyS712 | T245706 Hard deprecate Article::insertProtectNullRevision |
Event Timeline
Comment Actions
Change 573425 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::insertProtectNullRevision
Comment Actions
Change 573425 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::insertProtectNullRevision