Page MenuHomePhabricator

Deprecate & remove `.background-image-svg-quick()` mixin from 'mediawiki.mixins.less'
Closed, ResolvedPublic

Description

.background-image-svg-quick() in 'mediawiki.mixins.less has never seemed to get traction.

Even though it follows the DRY principle, I think we should remove centralized code complexity and leave it up to certain projects to have a solution like it implemented themselves.
The original reason (72fc2a68f44a7) to circumvent RL @embed has also been gone for a while now: 792ba935677 (T121730).
SVG fallbacks needs in general should go away anytime soon as well: https://caniuse.com/#feat=svg-css

Proposal

  • Deprecate mixin
    • Remove mentions of it in codebases we're aware of
  • Remove mixin in next version of MediaWiki

Background

Questioning this started in early versions of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikiEditor/+/499881/4/modules/jquery.wikiEditor.dialogs.config.less when thinking about need for the mixin use.

Related task

Removal of background-image-svg() in T248062

Event Timeline

Volker_E renamed this task from Deprecate `.background-image-svg-quick()` mixin from 'mediawiki.mixins.less' to Deprecate & remove `.background-image-svg-quick()` mixin from 'mediawiki.mixins.less'.Mar 19 2020, 8:13 PM
Volker_E updated the task description. (Show Details)

Change 581730 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.mixins: Deprecate .background-image-svg-quick() mixin

https://gerrit.wikimedia.org/r/581730

Change 581734 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/TwnMainPage@master] Remove mention of deprecated .background-image-svg-quick() mixin

https://gerrit.wikimedia.org/r/581734

Change 581730 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.mixins: Deprecate .background-image-svg-quick() mixin

https://gerrit.wikimedia.org/r/581730

Change 581734 merged by jenkins-bot:
[mediawiki/extensions/TwnMainPage@master] Remove mention of deprecated .background-image-svg-quick() mixin

https://gerrit.wikimedia.org/r/581734

Change 615897 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.mixins: Remove deprecated .background-image-svg-quick() mixin

https://gerrit.wikimedia.org/r/615897

Change 615897 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.mixins: Remove deprecated .background-image-svg-quick() mixin

https://gerrit.wikimedia.org/r/615897

Volker_E claimed this task.
Volker_E updated the task description. (Show Details)