Page MenuHomePhabricator
Create Task
Maniphest T248078

Fix all functions that have required parameters following optional ones
Closed, ResolvedPublic
Actions

Description

In PHP 8, they would generate E_DEPRECATED like: Deprecated: Required parameter $param2 follows optional parameter $param1 in filename.php on line 123

List of all files with an issue:

AbuseFilterTest.php
Adder.php
AJAXPoll.class.php
AthenaHooks.php
Attribute.php
BouquetSkinNavigationService.php
Comment.php
Contributors.php
CreatedPagesListTestBase.php
CreateNotification.php
DataModelBackend.LBFactory.php
DataModelBackend.php
DeskMessMirroredSkinNavigationService.php
DiscussionThreading.class.php
DPLListMode.php
DynamicPageListInclude.php
Editor.php
EDUtils.php
EmailDomain.php
ExtractFeatures.php
FallbackRunnerTest.php
FixedHeaderTable.php
FlickrAPIUtils.php
GamepressSkinNavigationService.php
GraphViz.php
KeywordFeatureAssertions.php
KeywordNodeVisitorTest.php
LastUserLogin.php
MockPageUpdater.php
OfflineImportLexicon_body.php
OmegaWikiDatabaseAPI.php
owAddAnnotation.php
PageContentBuilderTest.php
PermissionsTest.php
QuizTest.php
RegexBlockData.php
RequestLoggerTest.php
SelectCategory_body.php
SportsTeams.class.php
TabberHooks.php
Tabs.php
TimelineHashTest.php
UserSystemMessage.php
view.BaseElement.php
WFForum.php
WikiArticleFeeds_body.php
WikiDataAPI.php
WikiForumGui.php
WikiPage.php
YetAnotherKeywords.php

Details

SubjectRepoBranchLines +/-
Fix optional parameter before requiredmediawiki/extensions/Wikibasemaster+1 -1
Fix optional parameter before requiredmediawiki/extensions/Quizmaster+1 -1
Fix optional parameter before requiredmediawiki/extensions/timelinemaster+1 -1
Fix optional parameter before requiredmediawiki/extensions/ProofreadPagemaster+1 -1
Fix optional parameter before requiredmediawiki/extensions/Flowmaster+1 -1
Fix optional parameter before requiredmediawiki/extensions/CirrusSearchmaster+5 -5
phpunit: Change optional params before required params to also be requiredmediawiki/coremaster+5 -5
Prohibit required parameters after optional onesmediawiki/tools/codesniffermaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

MaxSem created this task.Mar 19 2020, 11:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2020, 11:40 AM
gerritbot added a comment.Mar 19 2020, 11:55 AM

Change 581549 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/tools/codesniffer@master] Prohibit required parameters after optional ones

https://gerrit.wikimedia.org/r/581549

gerritbot added a project: Patch-For-Review.Mar 19 2020, 11:55 AM
gerritbot added a comment.Mar 19 2020, 1:10 PM

Change 581566 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] Fix optional function parameters before required ones

https://gerrit.wikimedia.org/r/581566

Aklapper added projects: MW-1.35-release, MW-1.34-release, MW-1.33-release, MW-1.31-release.Mar 19 2020, 2:38 PM
Reedy removed projects: MW-1.31-release, MW-1.33-release, MW-1.34-release.Mar 19 2020, 6:09 PM
Reedy subscribed.

Going to untag MW 1.31 (EOL June 2021), MW 1.33 (EOL June 2020) and MW 1.34 (EOL November 2020). All will (or should be; 1.33 and 1.34 definitely will be) be EOL before PHP 8.0 is released

1.35 is probably in scope being an LTS... And it doesn't seem unreasonable people will want to run 1.35 in the time it's supported on PHP 8.0

Daimona subscribed.Mar 20 2020, 6:06 PM

FTR, note that phan already checks for this. However, many extensions don't run phan (and it's also never executed on tests), so it's a good idea to have a PHPCS sniff for this.

gerritbot added a comment.Mar 20 2020, 6:06 PM

Change 581549 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Prohibit required parameters after optional ones

https://gerrit.wikimedia.org/r/581549

gerritbot added a comment.Mar 30 2020, 9:29 PM

Change 581566 merged by jenkins-bot:
[mediawiki/core@master] phpunit: Change optional params before required params to also be required

https://gerrit.wikimedia.org/r/581566

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 30 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 30 2020, 10:10 PM
DannyS712 subscribed.Apr 24 2020, 2:27 AM
In T248078#5987737, @gerritbot wrote:

Change 581549 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Prohibit required parameters after optional ones

https://gerrit.wikimedia.org/r/581549

@MaxSem can this be closed as resolved?

Reedy added a comment.Apr 28 2020, 1:04 AM
In T248078#6080103, @DannyS712 wrote:
In T248078#5987737, @gerritbot wrote:

Change 581549 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Prohibit required parameters after optional ones

https://gerrit.wikimedia.org/r/581549

@MaxSem can this be closed as resolved?

In T248078#5987735, @Daimona wrote:

FTR, note that phan already checks for this. However, many extensions don't run phan (and it's also never executed on tests), so it's a good idea to have a PHPCS sniff for this.

Reedy mentioned this in T252023: Optional parameter before required.May 6 2020, 2:50 PM
Reedy added a subtask: T252023: Optional parameter before required.
Reedy updated the task description. (Show Details)May 18 2020, 7:48 PM
gerritbot added a comment.May 18 2020, 7:55 PM

Change 597138 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Flow@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597138

gerritbot added a project: Patch-For-Review.May 18 2020, 7:55 PM
gerritbot added a comment.May 18 2020, 7:57 PM

Change 597139 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/CirrusSearch@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597139

gerritbot added a comment.May 18 2020, 8:00 PM

Change 597142 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Wikibase@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597142

gerritbot added a comment.May 18 2020, 8:01 PM

Change 597143 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/ProofreadPage@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597143

gerritbot added a comment.May 18 2020, 8:02 PM

Change 597144 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Quiz@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597144

gerritbot added a comment.May 18 2020, 8:03 PM

Change 597146 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/timeline@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597146

Reedy closed subtask T252023: Optional parameter before required as Resolved.May 18 2020, 8:04 PM
gerritbot added a comment.May 18 2020, 8:27 PM

Change 597139 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597139

gerritbot added a comment.May 18 2020, 8:38 PM

Change 597138 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597138

gerritbot added a comment.May 18 2020, 8:38 PM

Change 597143 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597143

gerritbot added a comment.May 18 2020, 8:38 PM

Change 597146 merged by jenkins-bot:
[mediawiki/extensions/timeline@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597146

gerritbot added a comment.May 18 2020, 8:38 PM

Change 597144 merged by jenkins-bot:
[mediawiki/extensions/Quiz@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597144

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).May 18 2020, 9:00 PM
gerritbot added a comment.May 19 2020, 12:45 AM

Change 597142 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix optional parameter before required

https://gerrit.wikimedia.org/r/597142

Maintenance_bot removed a project: Patch-For-Review.May 19 2020, 1:10 AM
Reedy closed this task as Resolved.Jul 29 2020, 12:01 AM
Reedy claimed this task.

Marking resolved

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits