Page MenuHomePhabricator
Create Task
Maniphest T248390

Better NoJS support
Open, Needs TriagePublic
Actions

Description

Currently a lot of Social-Tools depend on JavaScript being enabled, even when there's no pressing need for it. Basic functionality should work without JavaScript just as well as it does with JS, even if some things are slightly less interactive.

The changes needed depend on the component, e.g. sometimes all that's needed might be to change an <input>'s type from button to submit, whereas for example SocialProfile's UserBoard needs more significant internal changes and refactoring.

Furthermore some things (e.g. MediaWikiChat or QuizGame) simply cannot work as intended without JavaScript. They should probably inform the user about that via something like <noscript>This feature requires JavaScript to be enabled</noscript>.

Details

SubjectRepoBranchLines +/-
Make the challenge admin only "cancel challenge" link work without JSmediawiki/extensions/Challengemaster+51 -18
Make the "Go Back" button on upload warning/error work even for no-JS usersmediawiki/extensions/SportsTeamsmaster+22 -10
Remove unnecessary onclick handler on a submit buttonmediawiki/extensions/Challengemaster+1 -2
Tone down the amount of unnecessary onclick handlersmediawiki/extensions/SocialProfilemaster+16 -14
Do not require JS in order to add a new team or edit an existing one via Special:SportsTeamsManagermediawiki/extensions/SportsTeamsmaster+2 -2
Use <a>, not <div onclick=...> for what is literally a linkmediawiki/extensions/ImageRatingmaster+2 -2
Bring back Special:CommentAction as the no-JS backend + provide basic functionality w/o JSmediawiki/extensions/Commentsmaster+459 -58
[SECURITY] Fix stored XSS via poll choices on Poll: pages etc.mediawiki/extensions/PollNYREL1_35+62 -19
No-JS support for the category tag cloud on Special:CreateBlogPostmediawiki/extensions/BlogPagemaster+56 -1
[SECURITY] Fix stored XSS via poll choices on Poll: pages etc.mediawiki/extensions/PollNYmaster+62 -19
Split ext.fanBoxes mixed CSS & JS module into separate ext.fanBoxes.styles and ext.fanBoxes.scripts modulesmediawiki/extensions/FanBoxesmaster+33 -14
Implement hover effect via CSS, not via JSmediawiki/extensions/PictureGamemaster+13 -34
Code cleanup + noJS workmediawiki/extensions/Challengemaster+440 -128
Version 3.8.0: better no-JS supportmediawiki/extensions/LinkFiltermaster+79 -19
Fix parsing of &lt; into < in the "invite-back-to-userpage" i18n msg, remove pointless legacy class_exists check (UserEmailTrack class is now a part of this extension rather than SocialProfile), improve no-JS usabilitymediawiki/extensions/MiniInvitemaster+20 -17
[SECURITY] Fix various classic CSRF points in the special pages and API module + improve no-JS usability as wellmediawiki/extensions/PollNYmaster+431 -140
Better no-JS supportmediawiki/extensions/SocialProfilemaster+754 -308
Rename BoardBlast error message keys to indicate they won't be JS-only in the near futuremediawiki/extensions/SocialProfilemaster+10 -10
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

ashley created this task.Mar 24 2020, 2:13 PM
ashley mentioned this in T248583: PollNY: Classic CSRF in Special:CreatePoll & Special:UpdatePoll + API module.Mar 26 2020, 1:55 PM
gerritbot added a comment.May 16 2020, 4:46 PM

Change 596814 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/SocialProfile@master] Rename BoardBlast error message keys to indicate they won't be JS-only in the near future

https://gerrit.wikimedia.org/r/596814

gerritbot added a project: Patch-For-Review.May 16 2020, 4:46 PM
gerritbot added a comment.May 16 2020, 4:55 PM

Change 596814 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Rename BoardBlast error message keys to indicate they won't be JS-only in the near future

https://gerrit.wikimedia.org/r/596814

Maintenance_bot removed a project: Patch-For-Review.May 16 2020, 5:10 PM
ashley mentioned this in rESPRd6e0286ff4f0: Rename BoardBlast error message keys to indicate they won't be JS-only in the….May 16 2020, 5:23 PM
gerritbot added a comment.May 20 2020, 6:16 AM

Change 597419 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/SocialProfile@master] Better no-JS support

https://gerrit.wikimedia.org/r/597419

gerritbot added a project: Patch-For-Review.May 20 2020, 6:16 AM
gerritbot added a comment.May 22 2020, 7:06 PM

Change 597419 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Better no-JS support

https://gerrit.wikimedia.org/r/597419

Maintenance_bot removed a project: Patch-For-Review.May 22 2020, 7:10 PM
ashley mentioned this in rESPR7cc4ed03601b: Better no-JS support.May 22 2020, 7:34 PM
gerritbot added a comment.May 23 2020, 11:08 PM

Change 598213 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/PollNY@master] [SECURITY] Fix various classic CSRF points in the special pages and API module + improve no-JS usability as well

https://gerrit.wikimedia.org/r/598213

gerritbot added a project: Patch-For-Review.May 23 2020, 11:08 PM
DannyS712 subscribed.May 24 2020, 5:53 AM
gerritbot added a comment.May 24 2020, 9:43 PM

Change 598213 merged by jenkins-bot:
[mediawiki/extensions/PollNY@master] [SECURITY] Fix various classic CSRF points in the special pages and API module + improve no-JS usability as well

https://gerrit.wikimedia.org/r/598213

Maintenance_bot removed a project: Patch-For-Review.May 24 2020, 10:10 PM
ashley added a subtask: T165712: SocialProfile: Pressing the "cancel" button when asked if the end-user is sure they want to remove a specific user from friends list doesn't do anything.Jun 12 2020, 8:19 PM
gerritbot added a comment.Aug 1 2020, 11:50 PM

Change 617851 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/LinkFilter@master] Version 3.8.0: better no-JS support

https://gerrit.wikimedia.org/r/617851

gerritbot added a project: Patch-For-Review.Aug 1 2020, 11:50 PM
gerritbot added a comment.Aug 14 2020, 10:38 AM

Change 620304 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/MiniInvite@master] Fix parsing of &lt; into < in the "invite-back-to-userpage" i18n msg, remove pointless legacy class_exists check (UserEmailTrack class is now a part of this extension rather than SocialProfile), improve no-JS usability

https://gerrit.wikimedia.org/r/620304

gerritbot added a comment.Aug 14 2020, 10:38 AM

Change 620304 merged by Jack Phoenix:
[mediawiki/extensions/MiniInvite@master] Fix parsing of &lt; into < in the "invite-back-to-userpage" i18n msg, remove pointless legacy class_exists check (UserEmailTrack class is now a part of this extension rather than SocialProfile), improve no-JS usability

https://gerrit.wikimedia.org/r/620304

gerritbot added a comment.Aug 16 2020, 9:26 AM

Change 617851 merged by jenkins-bot:
[mediawiki/extensions/LinkFilter@master] Version 3.8.0: better no-JS support

https://gerrit.wikimedia.org/r/617851

gerritbot added a comment.Oct 19 2020, 12:03 PM

Change 634944 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/Challenge@master] Code cleanup + noJS work

https://gerrit.wikimedia.org/r/634944

gerritbot added a comment.Oct 20 2020, 3:00 PM

Change 634944 merged by jenkins-bot:
[mediawiki/extensions/Challenge@master] Code cleanup + noJS work

https://gerrit.wikimedia.org/r/634944

ashley mentioned this in T266508: PollNY: Stored XSS (CVE-2020-29003).Oct 26 2020, 8:48 PM
gerritbot added a comment.Oct 26 2020, 9:07 PM

Change 636497 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/PictureGame@master] Implement hover effect via CSS, not via JS

https://gerrit.wikimedia.org/r/636497

gerritbot added a comment.Oct 27 2020, 11:49 PM

Change 636497 merged by jenkins-bot:
[mediawiki/extensions/PictureGame@master] Implement hover effect via CSS, not via JS

https://gerrit.wikimedia.org/r/636497

ashley mentioned this in rEPGA3cd3f1c9ab89: Implement hover effect via CSS, not via JS.Oct 28 2020, 12:01 AM
gerritbot added a comment.Nov 14 2020, 1:00 PM

Change 640992 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/FanBoxes@master] Split ext.fanBoxes mixed CSS & JS module into separate ext.fanBoxes.styles and ext.fanBoxes.scripts modules

https://gerrit.wikimedia.org/r/640992

gerritbot added a comment.Nov 14 2020, 1:02 PM

Change 640992 merged by Jack Phoenix:
[mediawiki/extensions/FanBoxes@master] Split ext.fanBoxes mixed CSS & JS module into separate ext.fanBoxes.styles and ext.fanBoxes.scripts modules

https://gerrit.wikimedia.org/r/640992

gerritbot added a comment.Nov 16 2020, 6:13 PM

Change 641216 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/PollNY@master] [SECURITY] Fix stored XSS via poll choices on Poll: pages etc.

https://gerrit.wikimedia.org/r/641216

gerritbot added a comment.Nov 16 2020, 6:34 PM

Change 641216 merged by Legoktm:
[mediawiki/extensions/PollNY@master] [SECURITY] Fix stored XSS via poll choices on Poll: pages etc.

https://gerrit.wikimedia.org/r/641216

gerritbot added a comment.Nov 18 2020, 5:12 PM

Change 641794 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/BlogPage@master] No-JS support for the category tag cloud on Special:CreateBlogPost

https://gerrit.wikimedia.org/r/641794

gerritbot added a comment.Nov 21 2020, 6:52 AM

Change 641794 merged by jenkins-bot:
[mediawiki/extensions/BlogPage@master] No-JS support for the category tag cloud on Special:CreateBlogPost

https://gerrit.wikimedia.org/r/641794

gerritbot added a comment.Nov 24 2020, 4:26 PM

Change 643292 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/Comments@master] Bring back Special:CommentAction as the no-JS backend + provide basic functionality w/o JS

https://gerrit.wikimedia.org/r/643292

gerritbot added a comment.Dec 22 2020, 9:20 PM

Change 651588 had a related patch set uploaded (by SBassett; owner: Jack Phoenix):
[mediawiki/extensions/PollNY@REL1_35] [SECURITY] Fix stored XSS via poll choices on Poll: pages etc.

https://gerrit.wikimedia.org/r/651588

gerritbot added a comment.Dec 22 2020, 9:31 PM

Change 651588 merged by jenkins-bot:
[mediawiki/extensions/PollNY@REL1_35] [SECURITY] Fix stored XSS via poll choices on Poll: pages etc.

https://gerrit.wikimedia.org/r/651588

ashley moved this task from Backlog to General on the Social-Tools board.May 17 2022, 7:55 PM
Aklapper removed a project: Patch-For-Review.Aug 16 2022, 10:08 AM
Aklapper removed ashley as the assignee of this task.Sep 26 2022, 10:23 AM
Aklapper subscribed.

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

gerritbot added a comment.Aug 24 2023, 12:04 PM

Change 952192 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/ImageRating@master] Use <a>, not <div onclick=...> for what is literally a link

https://gerrit.wikimedia.org/r/952192

gerritbot added a project: Patch-For-Review.Aug 24 2023, 12:04 PM
gerritbot added a comment.Aug 24 2023, 12:27 PM

Change 952192 merged by jenkins-bot:

[mediawiki/extensions/ImageRating@master] Use <a>, not <div onclick=...> for what is literally a link

https://gerrit.wikimedia.org/r/952192

ashley mentioned this in rEIMRa8098e0273a8: Use <a>, not <div onclick=...> for what is literally a link.Aug 24 2023, 12:48 PM
gerritbot added a comment.Aug 27 2023, 10:00 AM

Change 952549 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/SportsTeams@master] Do not require JS in order to add a new team or edit an existing one via Special:SportsTeamsManager

https://gerrit.wikimedia.org/r/952549

gerritbot added a comment.Aug 27 2023, 10:06 AM

Change 952549 merged by jenkins-bot:

[mediawiki/extensions/SportsTeams@master] Do not require JS in order to add a new team or edit an existing one via Special:SportsTeamsManager

https://gerrit.wikimedia.org/r/952549

gerritbot added a comment.Sep 5 2023, 1:05 PM

Change 954912 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/SocialProfile@master] Tone down the amount of unnecessary onclick handlers

https://gerrit.wikimedia.org/r/954912

gerritbot added a comment.Sep 5 2023, 2:08 PM

Change 954912 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Tone down the amount of unnecessary onclick handlers

https://gerrit.wikimedia.org/r/954912

ashley mentioned this in rESPR8b9d6d3ce302: Tone down the amount of unnecessary onclick handlers.Sep 5 2023, 2:09 PM
gerritbot added a comment.Sep 6 2023, 7:15 AM

Change 955283 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/Challenge@master] Remove unnecessary onclick handler on a submit button

https://gerrit.wikimedia.org/r/955283

gerritbot added a comment.Sep 6 2023, 7:18 AM

Change 955283 merged by Jack Phoenix:

[mediawiki/extensions/Challenge@master] Remove unnecessary onclick handler on a submit button

https://gerrit.wikimedia.org/r/955283

gerritbot added a comment.Sep 18 2023, 5:37 PM

Change 958532 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/SportsTeams@master] Make the "Go Back" button on upload warning/error work even for no-JS users

https://gerrit.wikimedia.org/r/958532

gerritbot added a comment.Sep 18 2023, 5:57 PM

Change 958532 merged by jenkins-bot:

[mediawiki/extensions/SportsTeams@master] Make the "Go Back" button on upload warning/error work even for no-JS users

https://gerrit.wikimedia.org/r/958532

DannyS712 unsubscribed.Oct 5 2023, 8:29 PM
gerritbot added a comment.Feb 22 2024, 8:50 AM

Change 1005707 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/Challenge@master] Make the challenge admin only "cancel challenge" link work without JS

https://gerrit.wikimedia.org/r/1005707

ashley mentioned this in rEMWC986d8d3750a6: No-JS adjustments.Thu, Apr 25, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL