Page MenuHomePhabricator

Consider having a linter that could catch config file entries that set unused variables
Open, MediumPublic

Event Timeline

mmodell created this task.Mar 30 2020, 2:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2020, 2:50 PM

In theory you can get every possible config option by reading through extension.json and DefaultSettings.php. But we often stage new config settings before deployment, so the proposed linter would need to be able to work around that.

@Krinkle's codesearch-based script might work nicely in CI (maybe with some false positive exclusion list) because as soon as something is merged in master, it'll be in search so it can be added to mediawiki-config.

Krinkle updated the task description. (Show Details)Jul 25 2020, 10:25 AM
Krinkle updated the task description. (Show Details)
Akuckartz awarded a token.
Akuckartz added a subscriber: Akuckartz.

Change 616641 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/tools/code-utils@master] wmf-config-wg-vars.js: Add README

https://gerrit.wikimedia.org/r/616641

Change 616641 merged by Krinkle:
[mediawiki/tools/code-utils@master] wmf-config-wg-vars.js: Add README

https://gerrit.wikimedia.org/r/616641

Change 616643 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/tools/code-utils@master] wmf-config-wg-vars.js: Use the '/deployed' preset for Code search

https://gerrit.wikimedia.org/r/616643

Change 616643 merged by Krinkle:
[mediawiki/tools/code-utils@master] wmf-config-wg-vars.js: Use the '/deployed' preset for Code search

https://gerrit.wikimedia.org/r/616643