Consider having a linter that could catch config file entries that set unused variables
Open, MediumPublic
Actions

Assigned To

None

Authored By

	• mmodell
	Mar 30 2020, 2:50 PM

Description

From the actionables on https://wikitech.wikimedia.org/wiki/Incident_documentation/20200207-wikidata

.. and again from https://wikitech.wikimedia.org/wiki/Incident_documentation/20200703-Lilypond_down (after T257079).

Details

	Subject	Repo	Branch	Lines +/-
	wmf-config-wg-vars.js: Use the '/deployed' preset for Code search	mediawiki/tools/code-utils	master	+3 -3
	wmf-config-wg-vars.js: Add README	mediawiki/tools/code-utils	master	+27 -3

Customize query in gerrit

Related Objects

Mentioned In: T252758: Wikbase settings should not allow setting unexpected settings
Mentioned Here: T257079: Audit mismatched/unused wmf-config settings (2020)

Event Timeline

• mmodell created this task.Mar 30 2020, 2:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2020, 2:50 PM

• mmodell moved this task from Active investigation to Follow-up prevention on the Wikimedia-Incident board.Mar 30 2020, 2:50 PM

Jdforrester-WMF subscribed.Mar 30 2020, 6:26 PM

Krinkle edited projects, added Sustainability (Incident Followup); removed Wikimedia-Incident.Apr 28 2020, 9:50 PM

Addshore added a project: Wikidata.May 14 2020, 10:06 AM

Addshore mentioned this in T252758: Wikbase settings should not allow setting unexpected settings.

Does this help?

https://wikitech.wikimedia.org/wiki/Technical_debt/Unused_config

In theory you can get every possible config option by reading through extension.json and DefaultSettings.php. But we often stage new config settings before deployment, so the proposed linter would need to be able to work around that.

@Krinkle's codesearch-based script might work nicely in CI (maybe with some false positive exclusion list) because as soon as something is merged in master, it'll be in search so it can be added to mediawiki-config.

Legoktm moved this task from Backlog to Planning on the MediaWiki-Configuration board.Jul 24 2020, 11:08 PM

Krinkle updated the task description. (Show Details)Jul 25 2020, 10:25 AM

Krinkle updated the task description. (Show Details)

Akuckartz added a project: MediaWiki-Stakeholders-Group.Jul 25 2020, 10:37 AM

Akuckartz awarded a token.

Akuckartz subscribed.

Change 616641 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/tools/code-utils@master] wmf-config-wg-vars.js: Add README

https://gerrit.wikimedia.org/r/616641

Change 616641 merged by Krinkle:
[mediawiki/tools/code-utils@master] wmf-config-wg-vars.js: Add README

https://gerrit.wikimedia.org/r/616641

Change 616643 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/tools/code-utils@master] wmf-config-wg-vars.js: Use the '/deployed' preset for Code search

https://gerrit.wikimedia.org/r/616643

Change 616643 merged by Krinkle:
[mediawiki/tools/code-utils@master] wmf-config-wg-vars.js: Use the '/deployed' preset for Code search