Page MenuHomePhabricator

Verify that actionOverrides callbacks work with Article as a parameter
Open, Stalled, Needs TriagePublic

Description

Action::factory() removes Page support and will only support Article as a parameter, thus Article will now be passed into the action overrides callbacks. The documentation for the callbacks state that they should work with any Page instance, but we need to validate that it's the case first and check if converting deprecated WikiPage into Article in Action::factory wouldn't break the callbacks.

Check action overrides for Page parameter
https://codesearch.wmflabs.org/deployed/?q=function%20getActionOverrides&i=nope&files=%5C.php%24&repos=

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 5:44 PM
Pchelolo renamed this task from Action::factory() with Article to Verify that actionOverrides callbacks work with Article as a parameter.Apr 1 2020, 6:04 PM
Pchelolo updated the task description. (Show Details)
WDoranWMF set Due Date to Apr 9 2020, 4:00 AM.Apr 9 2020, 3:21 PM
mmodell changed the subtype of this task from "Task" to "Deadline".Apr 9 2020, 3:23 PM

Change 588517 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/Flow@master] For Action::__construct() use Article instead of Page

https://gerrit.wikimedia.org/r/588517

Change 588521 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/Wikibase@master] For Action::__construct use Article instead of Page

https://gerrit.wikimedia.org/r/588521

Change 588522 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/WikibaseLexeme@master] For Action::__construct use Article instead of Page

https://gerrit.wikimedia.org/r/588522

Change 588527 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/EntitySchema@master] For Action::__construct use Article instead of Page

https://gerrit.wikimedia.org/r/588527

Change 588534 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] For Action::__construct use Article instead of Page

https://gerrit.wikimedia.org/r/588534

We can't merge developed patches until 1.36 version of MediaWiki core
Status: temporary blocked until 1.36

WDoranWMF changed the task status from Open to Stalled.May 21 2020, 1:34 PM
Helga_sf removed Art-Baltai as the assignee of this task.Tue, Jun 23, 4:24 PM