Page MenuHomePhabricator
Create Task
Maniphest T249146

Verify that actionOverrides callbacks work with Article as a parameter
Closed, ResolvedPublic
Actions

Description

Action::factory() removes Page support and will only support Article as a parameter, thus Article will now be passed into the action overrides callbacks. The documentation for the callbacks state that they should work with any Page instance, but we need to validate that it's the case first and check if converting deprecated WikiPage into Article in Action::factory wouldn't break the callbacks.

Check action overrides for Page parameter
https://codesearch.wmflabs.org/deployed/?q=function%20getActionOverrides&i=nope&files=%5C.php%24&repos=

Details

SubjectRepoBranchLines +/-
v1.36 For Action::__construct use Article instead of Pagemediawiki/coremaster+3 -3
v1.36 For Action::__construct use Article instead of Pagemediawiki/extensions/Wikibasemaster+20 -20
v1.36 For Action::__construct use Article instead of Pagemediawiki/extensions/WikibaseLexememaster+1 -6
v1.36 For Action::__construct() use Article instead of Pagemediawiki/extensions/Flowmaster+10 -15
v1.36 For Action::__construct use Article instead of Pagemediawiki/extensions/EntitySchemamaster+9 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Art-Baltai created this task.Apr 1 2020, 5:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 5:44 PM
• Pchelolo added a parent task: T239975: Complete WikiPage/Article split and deprecate Page interface.Apr 1 2020, 5:48 PM
• Pchelolo renamed this task from Action::factory() with Article to Verify that actionOverrides callbacks work with Article as a parameter.Apr 1 2020, 6:04 PM
• Pchelolo updated the task description. (Show Details)
WDoranWMF set Due Date to Apr 9 2020, 4:00 AM.Apr 9 2020, 3:21 PM
• mmodell changed the subtype of this task from "Task" to "Deadline".Apr 9 2020, 3:23 PM
WDoranWMF removed Due Date.Apr 9 2020, 3:23 PM
WDoranWMF moved this task from In Progress/Doing to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Apr 9 2020, 5:08 PM
WDoranWMF moved this task from Estimated/Estimation to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.
gerritbot added a comment.Apr 14 2020, 2:08 AM

Change 588517 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/Flow@master] For Action::__construct() use Article instead of Page

https://gerrit.wikimedia.org/r/588517

gerritbot added a project: Patch-For-Review.Apr 14 2020, 2:08 AM
gerritbot added a comment.Apr 14 2020, 3:19 AM

Change 588521 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/Wikibase@master] For Action::__construct use Article instead of Page

https://gerrit.wikimedia.org/r/588521

gerritbot added a comment.Apr 14 2020, 3:20 AM

Change 588522 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/WikibaseLexeme@master] For Action::__construct use Article instead of Page

https://gerrit.wikimedia.org/r/588522

gerritbot added a comment.Apr 14 2020, 3:37 AM

Change 588527 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/EntitySchema@master] For Action::__construct use Article instead of Page

https://gerrit.wikimedia.org/r/588527

gerritbot added a comment.Apr 14 2020, 3:59 AM

Change 588534 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] For Action::__construct use Article instead of Page

https://gerrit.wikimedia.org/r/588534

Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Apr 15 2020, 12:36 AM
Art-Baltai moved this task from In Progress/In Review to Blocked on the Platform Team Workboards (S&F Workboard) board.May 13 2020, 10:33 PM
Art-Baltai added a comment.May 21 2020, 1:19 PM

We can't merge developed patches until 1.36 version of MediaWiki core
Status: temporary blocked until 1.36

WDoranWMF changed the task status from Open to Stalled.May 21 2020, 1:34 PM
Helga_sf removed Art-Baltai as the assignee of this task.Jun 23 2020, 4:24 PM
Aklapper changed the task status from Stalled to Open.Jul 23 2020, 8:21 PM

Resetting task status as we've branched for 1.36

roman-stolar claimed this task.Aug 26 2022, 10:47 AM
gerritbot added a comment.Dec 29 2022, 11:29 AM

Change 588527 abandoned by Umherirrender:

[mediawiki/extensions/EntitySchema@master] v1.36 For Action::__construct use Article instead of Page

Reason:

Superseeded by If16fc24343c43fa9e3e69a7724afa649bcea8bb0

https://gerrit.wikimedia.org/r/588527

gerritbot added a comment.Dec 29 2022, 11:34 AM

Change 588517 abandoned by Umherirrender:

[mediawiki/extensions/Flow@master] v1.36 For Action::__construct() use Article instead of Page

Reason:

Was done as part of Iec3704522827f41e2a23656b9a5763416dc36047

https://gerrit.wikimedia.org/r/588517

gerritbot added a comment.Dec 29 2022, 11:34 AM

Change 588522 abandoned by Umherirrender:

[mediawiki/extensions/WikibaseLexeme@master] v1.36 For Action::__construct use Article instead of Page

Reason:

Was done in Ie4da10da61d22e0fe93905ebe92db8fa7e505be5

https://gerrit.wikimedia.org/r/588522

gerritbot added a comment.Dec 29 2022, 11:36 AM

Change 588521 abandoned by Umherirrender:

[mediawiki/extensions/Wikibase@master] v1.36 For Action::__construct use Article instead of Page

Reason:

Was done in I6f1d137e6e52e99d4e9ea6e504e19d356b33572e

https://gerrit.wikimedia.org/r/588521

gerritbot added a comment.Dec 29 2022, 11:36 AM

Change 588534 abandoned by Umherirrender:

[mediawiki/core@master] v1.36 For Action::__construct use Article instead of Page

Reason:

Was done as part of I8188172aeb7ec775eeb2060a1e163112e9e5ed66

https://gerrit.wikimedia.org/r/588534

Umherirrender closed this task as Resolved.Dec 29 2022, 11:38 AM
Umherirrender subscribed.

All work/replacement seems done

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL