Page MenuHomePhabricator
Create Task
Maniphest T249370

Cannot amend Gerrit changeset written by other author in Mediawiki Core repo (due to not being in Trusted-Contributors group)
Closed, ResolvedPublic
Actions

Description

Trying to run

git review -R

after running

git commit -a --amend

gives following error:

remote: 
remote: Processing changes: refs: 1
remote: Processing changes: refs: 1, done            
To ssh://gerrit.wikimedia.org:29418/mediawiki/core.git
 ! [remote rejected]       HEAD -> refs/for/master%topic=T249323 (cannot add patch set to 585759.)
error: failed to push some refs to 'ssh://alqaholic007@gerrit.wikimedia.org:29418/mediawiki/core.git'

Steps to replicate the error:

git review -d 585759
  • make a change in README file
git commit -a --amend
git review -R

I found a related article at T230916: Cannot amend Gerrit changeset in MediaWiki Core repo (due to not being in addPatchSet?) turns out it is some permissions issue

OS: OSX Mojave
Node: 12.x
git-review: v1.28.0

Related Objects
Search...

Event Timeline

Soham created this task.Apr 3 2020, 7:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2020, 7:30 PM
Soham updated the task description. (Show Details)Apr 3 2020, 7:30 PM
Soham added a parent task: T249323: Micro-task: Amend existing commit in Gerrit.
Ammarpad subscribed.Apr 3 2020, 7:58 PM

You cannot amend the patchset since you're its author. Yes you need to be added to Trusted-Contributors to be able to do that

Reedy removed Soham as the assignee of this task.Apr 3 2020, 8:02 PM
Vidhi-Mody subscribed.Apr 3 2020, 8:56 PM

Getting the same error!

Soham updated the task description. (Show Details)Apr 3 2020, 8:58 PM
Soham updated the task description. (Show Details)
Aklapper renamed this task from Cannot amend Gerrit changeset in Mediawiki Core repo to Cannot amend Gerrit changeset written by other author in Mediawiki Core repo.Apr 3 2020, 9:21 PM
Aklapper added a comment.Apr 3 2020, 9:24 PM

gives following error:

@AlQaholic007: Please always post text as text, so it can be indexed and searched for.
Please also always provide complete steps. This seems to be after running git review -d 585759. See https://www.mediawiki.org/wiki/How_to_report_a_bug

DannyS712 added a project: Gerrit.Apr 4 2020, 1:53 AM
Soham updated the task description. (Show Details)Apr 4 2020, 5:14 AM
Soham updated the task description. (Show Details)
Soham added a comment.Apr 4 2020, 5:17 AM
In T249370#6027889, @Aklapper wrote:

gives following error:

@AlQaholic007: Please always post text as text, so it can be indexed and searched for.
Please also always provide complete steps. This seems to be after running git review -d 585759. See https://www.mediawiki.org/wiki/How_to_report_a_bug

My bad @Aklapper I have modified the task body with steps to reproduce the error

Paladox subscribed.Apr 4 2020, 5:21 AM

That will be because you need to be added to the trusted user group in Gerrit (to gain the ability to upload changes to other users changes).

Paladox added a comment.Apr 4 2020, 5:26 AM

I’ve added you to the group, please let us know if it works.

Paladox added a comment.Apr 4 2020, 5:27 AM

Added you too @Vidhi-Mody

Vidhi-Mody added a comment.Apr 4 2020, 7:39 AM

@Paladox it's working now. Thanks!

Soham added a comment.Apr 4 2020, 7:39 AM

@Paladox thanks a tonne. This issue has been resolved now and can be closed

Soham closed this task as Resolved.Apr 4 2020, 7:40 AM
Gaura87 subscribed.Apr 4 2020, 7:57 AM

@Paladox please add me to in that group my developer account username is gaurav87
THANKS

Aklapper renamed this task from Cannot amend Gerrit changeset written by other author in Mediawiki Core repo to Cannot amend Gerrit changeset written by other author in Mediawiki Core repo (due to not being in Trusted-Contributors group).Apr 4 2020, 9:06 AM
zeljkofilipin mentioned this in T249413: Add Google Summer of Code students to Trusted-Contributors group in Gerrit.Apr 4 2020, 11:34 AM
Gbahdeyboh subscribed.Apr 4 2020, 1:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits