CI jobs for WMF deployed extensions should use vendor.git , not composer
Closed, ResolvedPublic
Actions

Description

I have found out a few extensions that are apparently deployed to Wikimedia but have their CI jobs relying on composer to install dependencies. They should be switched to use mediawiki/vendor instead.

There are:

They are configured in integration/config with the composer variant of the job, and there is even a FIXME for them. Example:

zuul/layout.yaml

- name: mediawiki/extensions/MachineVision
  template:
    # FIXME: Document why this is using the composer variant.
    - name: extension-quibble-composer

That should be extension-quibble-vendor, or due to T232759:

- extension-quibble-noselenium
- extension-quibble-only-selenium

Details

	Subject	Repo	Branch	Lines +/-
	layout: Move last production extensions to use vendor	integration/config	master	+8 -8

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Resolved	hashar	T232626 CI mediawiki/core run times have increased since July 26th, 2019
Resolved	hashar	T232759 Move CI selenium/qunit tests of mediawiki repository to a standalone job
Resolved	hashar	T249845 CI jobs for WMF deployed extensions should use vendor.git , not composer
Resolved	• Mholloway	T237596 Add MachineVision dependencies to vendor
Declined	Reedy	T237588 Security review for MachineVision libraries

Event Timeline

hashar created this task.Apr 9 2020, 4:32 PM

Restricted Application added projects: Wikidata, Structured-Data-Backlog. · View Herald TranscriptApr 9 2020, 4:32 PM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript

Interestingly, MachineVision has a task to get its dependencies added to vendor: T237596

hashar mentioned this in T237596: Add MachineVision dependencies to vendor.Apr 9 2020, 4:36 PM

Jdforrester-WMF updated the task description. (Show Details)Apr 9 2020, 4:55 PM

Change 587806 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: Move last production extensions to use vendor

https://gerrit.wikimedia.org/r/587806

gerritbot added a project: Patch-For-Review.Apr 9 2020, 4:55 PM

Change 587806 merged by jenkins-bot:
[integration/config@master] layout: Move last production extensions to use vendor

https://gerrit.wikimedia.org/r/587806

Jdforrester-WMF closed this task as Resolved.Apr 9 2020, 5:18 PM

Jdforrester-WMF assigned this task to hashar.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF closed subtask T237596: Add MachineVision dependencies to vendor as Resolved.

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2020, 6:10 PM