Page MenuHomePhabricator

CI jobs for WMF deployed extensions should use vendor.git , not composer
Closed, ResolvedPublic

Description

I have found out a few extensions that are apparently deployed to Wikimedia but have their CI jobs relying on composer to install dependencies. They should be switched to use mediawiki/vendor instead.

There are:

  • TemplateStyles
  • MachineVision
  • PropertySuggester
  • WikibaseQualityConstraints
  • Wikidata.org
  • WikibaseJavaScriptApi
  • WikibaseQuality
  • WikibaseQualityExternalValidation

They are configured in integration/config with the composer variant of the job, and there is even a FIXME for them. Example:

zuul/layout.yaml
- name: mediawiki/extensions/MachineVision
  template:
    # FIXME: Document why this is using the composer variant.
    - name: extension-quibble-composer

That should be extension-quibble-vendor, or due to T232759:

- extension-quibble-noselenium
- extension-quibble-only-selenium

Event Timeline

hashar created this task.Apr 9 2020, 4:32 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript

Change 587806 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: Move last production extensions to use vendor

https://gerrit.wikimedia.org/r/587806

Change 587806 merged by jenkins-bot:
[integration/config@master] layout: Move last production extensions to use vendor

https://gerrit.wikimedia.org/r/587806

Jdforrester-WMF closed this task as Resolved.Apr 9 2020, 5:18 PM
Jdforrester-WMF assigned this task to hashar.
Jdforrester-WMF updated the task description. (Show Details)