Page MenuHomePhabricator

MediaWiki core and WikibaseLexeme both declare "vuex" ResourceLoader module
Closed, ResolvedPublic

Description

Since change I883d9531d1, MediaWiki core provides a "vuex" ResourceLoader module. However, WikibaseLexeme also registers a module of that same name (but only in “repo” mode, i. e. on Wikidata and Test Wikidata). These modules contain incompatible versions of Vuex: Core ships v3, WikibaseLexeme v2.

Apparently, MediaWiki doesn’t report this as an error or anything, you’ll just silently get one of the versions (the WikibaseLexeme one, on my test wiki). This should be fixed before any code headed for Wikidata starts using "vuex" and expects it to produce Vuex v3.

Event Timeline

Change 589003 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Rename vuex ResourceLoader module to vuex2

https://gerrit.wikimedia.org/r/589003

Argh, sorry, it never occurred to me that we didn't have a structure test for this.

Change 589003 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Rename vuex ResourceLoader module to vuex2

https://gerrit.wikimedia.org/r/589003

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 15 2020, 1:55 PM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Backlog to Done on the MediaWiki-Interface board.

Well, with all the conditional registration in WikibaseLexeme, this would’ve been pretty hard to catch automatically :/ I hope there are no other conflicts. (Nothing else in WikibaseLexeme sticks out to me, at least, though T250273 is related.)