Page MenuHomePhabricator
Create Task
Maniphest T250512

Preformatting syntax (space before first character) shouldn't be extended
Closed, ResolvedPublic
Actions

Description

Putting a space as the first character results in <pre>-type formatting. https://ar.wikipedia.org/w/index.php?title=نقاش_المستخدم:عبد_المغيث&curid=6552463&diff=45711243&oldid=45711190 shows that formatting being continued, and it shouldn't.

Details

SubjectRepoBranchLines +/-
Fix inserting replies inside a <pre>mediawiki/extensions/DiscussionToolsmaster+32 -1
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Apr 17 2020, 6:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2020, 6:08 PM
matmarex claimed this task.Apr 25 2020, 5:46 PM
matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).
matmarex subscribed.

This is actually a special case of T250126! The reply gets placed inside the <pre> tag, rather than outside (and then gets messed up in funny ways, since the wikitext syntax doesn't allow that).

gerritbot added a comment.Apr 25 2020, 5:46 PM

Change 592460 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix inserting replies inside a <pre>

https://gerrit.wikimedia.org/r/592460

gerritbot added a project: Patch-For-Review.Apr 25 2020, 5:46 PM
matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 25 2020, 5:46 PM
gerritbot added a comment.Apr 28 2020, 10:31 PM

Change 592460 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix inserting replies inside a <pre>

https://gerrit.wikimedia.org/r/592460

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 28 2020, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 28 2020, 11:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 29 2020, 5:25 PM
matmarex added a project: Editing QA.
Ryasmeen edited projects, added Verified; removed Editing QA.May 29 2020, 8:45 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.
• ppelberg closed this task as Resolved.Jun 5 2020, 1:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL