Page MenuHomePhabricator
Create Task
Maniphest T251430

API / GlobalBlocks: PHP Notice: Undefined property: stdClass::$gb_timestamp
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.28

message
PHP Notice: Undefined property: stdClass::$gb_timestamp

Impact

Just saw a spike of ~1k of these warnings starting at 2020-04-29 16:47:51 UTC, all on enwiki.

Details

Request ID
08aa9363-c159-4a82-ae54-f41d70e33882
Request URL
https://en.wikipedia.org/w/api.php
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.28/extensions/GlobalBlocking/includes/api/ApiQueryGlobalBlocks.php(148): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.28/includes/api/ApiQuery.php(263): ApiQueryGlobalBlocks->execute()
#2 /srv/mediawiki/php-1.35.0-wmf.28/includes/api/ApiMain.php(1580): ApiQuery->execute()
#3 /srv/mediawiki/php-1.35.0-wmf.28/includes/api/ApiMain.php(523): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.35.0-wmf.28/includes/api/ApiMain.php(494): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.35.0-wmf.28/api.php(84): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): require(string)
#7 {main}
SubjectRepoBranchLines +/-
Unconditionally select gb_timestampmediawiki/extensions/GlobalBlockingwmf/1.35.0-wmf.28+3 -3
Unconditionally select gb_timestampmediawiki/extensions/GlobalBlockingmaster+3 -3
Unconditionally select gb_timestampmediawiki/extensions/GlobalBlockingwmf/1.35.0-wmf.30+3 -3
Unconditionally select gb_timestampmediawiki/extensions/GlobalBlockingREL1_31+3 -3
Unconditionally select gb_timestampmediawiki/extensions/GlobalBlockingREL1_33+3 -3
Unconditionally select gb_timestampmediawiki/extensions/GlobalBlockingREL1_34+3 -3
Customize query in gerrit

Event Timeline

brennen created this task.Apr 29 2020, 5:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2020, 5:18 PM
brennen renamed this task from PHP Notice: Undefined property: stdClass::$gb_timestamp to API / GlobaBlocks: PHP Notice: Undefined property: stdClass::$gb_timestamp.Apr 29 2020, 5:22 PM
brennen updated the task description. (Show Details)
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
Krinkle renamed this task from API / GlobaBlocks: PHP Notice: Undefined property: stdClass::$gb_timestamp to API / GlobalBlocks: PHP Notice: Undefined property: stdClass::$gb_timestamp.Apr 29 2020, 6:30 PM
Jdforrester-WMF subscribed.Apr 29 2020, 7:28 PM

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/+/master/includes/api/ApiQueryGlobalBlocks.php#148

So… $row is stdClass; $res is an IResultWrapper of nominal stdClasss which are actually injected by Database as proper results normally, aren't they?

Reedy subscribed.Apr 29 2020, 8:22 PM
In T251430#6094979, @Jdforrester-WMF wrote:

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/+/master/includes/api/ApiQueryGlobalBlocks.php#148

So… $row is stdClass; $res is an IResultWrapper of nominal stdClasss which are actually injected by Database as proper results normally, aren't they?

It's being unconditionally used... but only conditionally selected - https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/+/master/includes/api/ApiQueryGlobalBlocks.php#73

gerritbot added a comment.Apr 29 2020, 8:24 PM

Change 593305 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/GlobalBlocking@master] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593305

gerritbot added a project: Patch-For-Review.Apr 29 2020, 8:24 PM
Reedy added a comment.EditedApr 29 2020, 8:25 PM

So basically, it works fine if someone explicitly selects it, or if they don't change the default properties (as per https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/+blame/master/includes/api/ApiQueryGlobalBlocks.php#220), but if they do, it'll error out

Jdforrester-WMF added a comment.Apr 29 2020, 8:33 PM

Lovely.

Reedy added a comment.Apr 29 2020, 8:34 PM

Confirmed by making entries in logstash appear on demand that https://en.wikipedia.org/w/api.php?action=query&list=globalblocks&bgprop=address&bglimit=max does it, even though no error appears to the end user

"continue": {
    "bgstart": "2020-04-29T20:26:30Z",
    "continue": "-||"
},
Reedy added a comment.Apr 29 2020, 8:37 PM

I don't know if we want to bother to backport to prod branches... It's not a recent regression, just no one has hit the specific parameters recently...

Screenshot 2020-04-29 at 21.36.47.png (374×1 px, 43 KB)

gerritbot added a comment.Apr 29 2020, 8:38 PM

Change 593307 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/GlobalBlocking@REL1_34] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593307

gerritbot added a comment.Apr 29 2020, 8:38 PM

Change 593308 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/GlobalBlocking@REL1_33] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593308

gerritbot added a comment.Apr 29 2020, 8:38 PM

Change 593309 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/GlobalBlocking@REL1_31] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593309

gerritbot added a comment.Apr 29 2020, 8:40 PM

Change 593307 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@REL1_34] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593307

gerritbot added a comment.Apr 29 2020, 8:43 PM

Change 593311 had a related patch set uploaded (by Jforrester; owner: Reedy):
[mediawiki/extensions/GlobalBlocking@wmf/1.35.0-wmf.30] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593311

gerritbot added a comment.Apr 29 2020, 8:44 PM

Change 593308 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@REL1_33] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593308

gerritbot added a comment.Apr 29 2020, 8:50 PM

Change 593305 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593305

gerritbot added a comment.Apr 29 2020, 8:50 PM

Change 593309 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@REL1_31] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593309

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 29 2020, 9:00 PM
gerritbot added a comment.Apr 29 2020, 9:13 PM

Change 593311 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@wmf/1.35.0-wmf.30] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593311

Reedy closed this task as Resolved.Apr 29 2020, 9:15 PM
Reedy claimed this task.
gerritbot added a comment.Apr 29 2020, 9:17 PM

Change 593322 had a related patch set uploaded (by Jforrester; owner: Reedy):
[mediawiki/extensions/GlobalBlocking@wmf/1.35.0-wmf.28] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593322

Stashbot added a comment.Apr 29 2020, 9:19 PM

Mentioned in SAL (#wikimedia-operations) [2020-04-29T21:19:01Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.30/extensions/GlobalBlocking/includes/api/ApiQueryGlobalBlocks.php: T251430 Unconditionally select gb_timestamp (duration: 01m 05s)

Jdforrester-WMF added a comment.Apr 29 2020, 9:19 PM
In T251430#6095200, @Reedy wrote:

I don't know if we want to bother to backport to prod branches... It's not a recent regression, just no one has hit the specific parameters recently...

Screenshot 2020-04-29 at 21.36.47.png (374×1 px, 43 KB)

Yes, but they're hitting it an awful lot.

gerritbot added a comment.Apr 29 2020, 9:19 PM

Change 593322 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@wmf/1.35.0-wmf.28] Unconditionally select gb_timestamp

https://gerrit.wikimedia.org/r/593322

Stashbot added a comment.Apr 29 2020, 9:22 PM

Mentioned in SAL (#wikimedia-operations) [2020-04-29T21:22:18Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.28/extensions/GlobalBlocking/includes/api/ApiQueryGlobalBlocks.php: T251430 Unconditionally select gb_timestamp (duration: 01m 06s)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.28; 2020-04-14); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 29 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 29 2020, 10:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits