Page MenuHomePhabricator

Users do not get additional warning on Special:UploadWizard when required fields are not in their viewport
Open, MediumPublic

Description

The issue was found when testing T224890 - see this comment[[ https://phabricator.wikimedia.org/T224890#6095517 | comment ]].

Steps to reproduce:

  1. With multiple files upload on Special:UploadWizard, a user skips a required field(s) (or fills out only the field that is the closest to the bottom of the page) - and scrolls to the bottom of the page (so the not-filled required field is out of the view)
  2. A user clicks on the 'Publish files' - there will be no warning that some required fields need to be filled out and no action.

    Adding an additional warning message e.g. "Some required fields are missing" or scrolling to the place(s) where required fields are not filled would improve user experience.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2020, 11:28 PM
Aklapper renamed this task from Users do not get additonal warning on Special:UploadWizard when required fields are not in their viewport to Users do not get additional warning on Special:UploadWizard when required fields are not in their viewport.May 1 2020, 9:27 AM
Aklapper added a project: UploadWizard.

According to T146932 there was once a summary error given next to the button, but I no longer see it. This is very annoying when uploading many files: I thought the UploadWizard had broken and lost all my work on descriptions and categories since the button did nothing, until I scrolled through the whole page and spotted the one empty description field.

MarkTraceur triaged this task as Low priority.Jun 22 2020, 4:27 PM
MarkTraceur added a subscriber: MarkTraceur.

I don't believe any of the fields in the Structured Data step are required, hence there are no warnings or errors. We could detect if people have visited each file in the sequence, perhaps, and warn them if they try to publish before having done so? Or maybe change the publish button to cycle to the next file? Anyway, given these aren't required fields, and we know there are people who don't want to fill out this data in UploadWizard, I have trouble seeing a pressing need for a fix, hence low priority.

Pcoombe added a comment.EditedJun 22 2020, 6:17 PM

The issue is not primarily on the Structured Data step, but on earlier steps where fields (e.g. description) are required.

MarkTraceur raised the priority of this task from Low to Medium.Jun 22 2020, 6:36 PM

Aha - the screenshot attached made this confusing. Yeah, this strikes me as a regression, then. Bumping to medium with the warning that there may still not be a rush to handle the issue given the de-prioritization of UploadWizard tasks lately.