mediawiki-config is full of "\\Foo\\Bar\\Baz"... We should tidy them up with \Foo\Bar\Baz::class
Description
Description
Details
Details
Customize query in gerrit
Event Timeline
Comment Actions
Change 593654 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Replace stringified class names with ::class
Comment Actions
Change 593654 merged by jenkins-bot:
[operations/mediawiki-config@master] Replace stringified class names with ::class
Comment Actions
I am not sure what is the benefit of using ::class when we have a fully qualified class name.
::class causes a class name resolution to resolve the namespaces ( https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class ). I would assume that it might add a little bit of overhead. If the intent is primarily to drop the double backslashes, maybe we can use a single quoted string: '\Foo\Bar\Baz'?
Then if there is a typo, I would guess Phan will catch it when we are using ::class so that is an advantage.
Comment Actions
It also helps with Codesearch and IDEs as it will match the standard name of the class, whereas we generally do not attempt to search for slash-escaped strings that mention a class.
A few more remaining to be converted:
https://codesearch.wmcloud.org/operations/?q=%5B%27%22%5D(%5BA-Za-z%5D%2B)%3F%5C%5C%5C%5C&i=nope&files=php%24&excludeFiles=&repos=Wikimedia%20MediaWiki%20config
Comment Actions
Claiming for our on-boarding. This will be a good one to get familiar with our deployment process (Logstash, mwdebug staging, etc.) without (yet) involving MediaWiki specifics beyond PHP itself.
Comment Actions
I suspect there's probably a few non namespaced ones hanging around in there too, which makes them harder to find (and part of the reason for this task in the first place).
Comment Actions
Change 990711 had a related patch set uploaded (by Reedy; author: Reedy):
[operations/mediawiki-config@master] CommonSettings: Swap stringified class names in ConfirmEdit usages
Comment Actions
Change 990766 had a related patch set uploaded (by Reedy; author: Reedy):
[operations/mediawiki-config@master] wmf-config: Replace numerous stringified classes with use statements
Comment Actions
Change 990711 merged by jenkins-bot:
[operations/mediawiki-config@master] CommonSettings: Swap stringified class names in ConfirmEdit usages
Comment Actions
Change 990766 merged by jenkins-bot:
[operations/mediawiki-config@master] wmf-config: Replace numerous stringified classes with use statements