Page MenuHomePhabricator

Inject tables into LanguageConverter in advance and avoid using loadTables function.
Open, MediumPublic5 Estimated Story Points

Description

Story

When working on LanguageConverter I want to inject conversion tables in advance so that I can avoid LanguageConverter from using Language::ucfirst and NamespaceNameLocalizer::getNamespaceIndex.

Context

LanguageConveter::loadTables (and related) are quite separate

Expected result
  • ConverterTable should be introduced as service
  • Two options are possible:
    • This service should be injected into LanguageConverter via constructor
    • The table should be pre-loaded using the ConverterTable and injected as a whole.

Event Timeline

Helga_sf triaged this task as Medium priority.May 28 2020, 12:03 PM
Peter.ovchyn set the point value for this task to 5.May 28 2020, 12:04 PM
Peter.ovchyn updated the task description. (Show Details)
Peter.ovchyn updated the task description. (Show Details)
Peter.ovchyn updated the task description. (Show Details)