Allow passing arguments into container
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	May 28 2020, 8:54 PM

Description

It would be nice to be able to run fresh {whatever args I want} and have those arguments run as a command in the container.

Sometimes I end up with lengthy commands in my history like ./node_modules/.bin/stylelint --fix modules/homepage/ext.growthExperiments.StartModule.less and on my host terminal, where I have access to tools like fzf, it's trivial to recall them. But in fresh cmd+R is not quite as nice, if functional enough.
For text editors / IDEs, you could configure those to run fresh npm run test from some keystroke in your editor, or automatically via e.g. a pre-commit hook

Imported from https://github.com/wikimedia/fresh/issues/22.

Details

Subject	Repo	Branch	Lines +/-
Replace welcome message with a shorter version	fresh	master	+37 -43
Take command to execute as a positional argument	fresh	master	+72 -30
fresh-node: Mention FRESH_INTERNAL_RUNCMD in usage documentation	fresh	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T282246: `npm ci` fails when using Fresh in MinervaNeue

Event Timeline

kostajh created this task.May 28 2020, 8:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2020, 8:54 PM

Krinkle updated the task description. (Show Details)May 29 2020, 2:10 AM

In github:wikimedia/fresh#22, @Krinkle wrote:
Sounds good to me.

A few quick notes:

I added something like this unofficially for the test suite ("FRESH_INTERNAL_RUNCMD"). So I suggest we replace that with what we come up with here.

Note that grunt or stylelint would not be available here. I think it would be good practice to maintain those commands in package.json instead and invoke npm run … instead. That keeps the code central, avoids hardcoding for node_modules in Fresh, and makes it easier for users to run those same things by other means if they don't want or can't use pre-commit hooks.

Slight nitpick - "Entrypoint" might be too easily confused with the docker internals. Perhaps even simpler would be to consider all arguments after -- as the command to execute?

For example
fresh -- npm run lint
fresh -- npm run fix:less