Page MenuHomePhabricator

Change to admission controller readme.md failed to pass gate-and-submit jobs
Closed, ResolvedPublic

Description

I'm looking to understand why the gate-and-submit and thus the merge failed for https://gerrit.wikimedia.org/r/c/cloud/toolforge/ingress-admission-controller/+/601485 Obviously, I just forced it because I wanted that documentation in the repo.

The test passed. It was just a change to the README.md. Is there something I need to alter in the config, or was something broken on the pipeline?

Event Timeline

The path to the actual error is a bit circuitous, but it looks like the step that failed was:

Step 12/20 : RUN sh "-c" "go mod download && go mod verify && go get -u golang.org/x/lint/golint"

 ---> Running in 58f6e4bcb897

go: k8s.io/api@v0.0.0-20190602205700-9b8cae951d65 requires

	k8s.io/apimachinery@v0.0.0-20190602113612-63a6072eb563: invalid pseudo-version: does not match version-control timestamp (2019-06-02T18:36:12Z)



script returned exit code 1

I also get this locally:

ingress-admission-controller (master u=)
(/^ヮ^)/*:・゚✧ go mod download && go mod verify && go get -u golang.org/x/lint/golint
go: k8s.io/api@v0.0.0-20190602205700-9b8cae951d65 requires
        k8s.io/apimachinery@v0.0.0-20190602113612-63a6072eb563: invalid pseudo-version: does not match version-control timestamp (2019-06-02T18:36:12Z

Yeah, the modules got updated, and I believe freezing it isn't an option on the version of golang in our docker images. I'll kick it around eventually.

Change 663331 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[cloud/toolforge/ingress-admission-controller@master] Attempt to fix the go module dependencies

https://gerrit.wikimedia.org/r/663331

Bstorm moved this task from Watching to Doing on the cloud-services-team (Kanban) board.

Finally fixing this because we are updating things.

Change 663331 merged by jenkins-bot:
[cloud/toolforge/ingress-admission-controller@master] Attempt to fix the go module dependencies

https://gerrit.wikimedia.org/r/663331