Page MenuHomePhabricator

Remove array cast workaround from Parsoid
Open, MediumPublic


We added a workaround for a PHP 7.2 GC bug, which has since been fixed upstream in PHP. We should remove the workaround at some point.

Workaround patch was: T228346: PHP 7.2 garbage collector segfault, 34fcb4241aa0f3a010e39d0857b5a6d2569204de.

We could either wait until our min PHP version is bumped to 7.3, or else just ban the affected minor versions of PHP 7.2, the way that T246594: Prevent use of known buggy versions of PHP (that are greater than the minimum supported PHP version) (7.4.0 – 7.4.8, and 7.3.0 - 7.3.18) is handled.

Event Timeline

Change 602489 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Add a reference to T254519 to aid later cleanup

Change 602489 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add a reference to T254519 to aid later cleanup

ssastry triaged this task as Medium priority.Jun 9 2020, 10:33 PM
ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.