Page MenuHomePhabricator

Remove array cast workaround from Parsoid
Open, MediumPublic

Description

We added a workaround for a PHP 7.2 GC bug, which has since been fixed upstream in PHP. We should remove the workaround at some point.

Workaround patch was: T228346: PHP 7.2 garbage collector segfault, 34fcb4241aa0f3a010e39d0857b5a6d2569204de.

https://codesearch.wmflabs.org/search/?q=T228346&i=nope&files=&repos=

We could either wait until our min PHP version is bumped to 7.3, or else just ban the affected minor versions of PHP 7.2, the way that T246594: Blacklist of newer PHP versions is handled.

Event Timeline

cscott created this task.Jun 4 2020, 8:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 4 2020, 8:27 PM

Change 602489 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Add a reference to T254519 to aid later cleanup

https://gerrit.wikimedia.org/r/602489

cscott updated the task description. (Show Details)Jun 4 2020, 8:39 PM

Change 602489 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add a reference to T254519 to aid later cleanup

https://gerrit.wikimedia.org/r/602489

ssastry triaged this task as Medium priority.Jun 9 2020, 10:33 PM
ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.