FileImporter should not percent encode URLs in log entries
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Base
	Jun 13 2020, 1:58 PM

Description

In ukwiki deletion log, I see entries like

11:17, 13 червня 2020 AlexKozur обговорення внесок заблокувати вилучив сторінку Файл:Берлін 2011-2.JPG (Цей файл зараз на сайті Wikimedia Commons як https://commons.wikimedia.org/wiki/File:%D0%91%D0%B5%D1%80%D0%BB%D1%96%D0%BD_2011-2.JPG (переміщено за допомогою FileImporter).) (переглянути/відновити) (подякувати)

Instead of https://commons.wikimedia.org/wiki/File:%D0%91%D0%B5%D1%80%D0%BB%D1%96%D0%BD_2011-2.JPG the links should go as https://commons.wikimedia.org/wiki/File:Берлін_2011-2.JPG (better still would be if the extension could detect intewiki map entry and use the shortest form possible)

It seems to be fileimporter-delete-summary and the link is passed in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/FileImporter/+/c05610aa4cb974e863ff3741d9520425be7f68c4/src/Data/ImportPlan.php but I see that there is also a similar message fileimporter-cleanup-summary, so it is good to look into this more broadly.

Details

	Subject	Repo	Branch	Lines +/-
	Use wfExpandIRI() for compact, readable URLs in summaries	mediawiki/extensions/FileImporter	master	+5 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T255346 FileImporter should not percent encode URLs in log entries
Resolved	Andrew-WMDE	T227358 Add a link to the imported file in the delete and edit summary
Resolved	awight	T228851 Source wiki editing and deletion always fails

Event Timeline

Base created this task.Jun 13 2020, 1:58 PM

The FileImporter extension doesn't do anything special here. This is standard MediaWiki core behavior. All we do is use Title::getFullURL(), which returns the URL like this. All URLs are encoded like this.

Undoing this encoding is probably not a good idea, as it might result in a broken URL. After all, core does this encoding for a reason.

One possible solution is already mentioned above: Format the link as [[commons:…]] with the correct interwiki prefix. We work with interwiki links like this in other places in the codebase already. However, most of these are the other way around, from Commons back to the source wiki. We need to request the source wiki's interwiki map (example). Look at the existing InterwikiTablePrefixLookup, which does something very similar already. Note that just card-coding commons: is not sustainable, even if it might work in >99% of the cases.

thiemowmde added a subtask: T227358: Add a link to the imported file in the delete and edit summary.Aug 11 2020, 10:12 AM

Change 620944 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Use wfExpandIRI() for compact, readable URLs in summaries

https://gerrit.wikimedia.org/r/620944

gerritbot added a project: Patch-For-Review.Aug 18 2020, 2:01 PM

thiemowmde claimed this task.Aug 18 2020, 2:01 PM

Change 620944 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Use wfExpandIRI() for compact, readable URLs in summaries

https://gerrit.wikimedia.org/r/620944

thiemowmde mentioned this in rEFLI254104e995bf: Use wfExpandIRI() for compact, readable URLs in summaries.Sep 18 2020, 8:46 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 18 2020, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 18 2020, 9:10 AM

thiemowmde removed thiemowmde as the assignee of this task.Nov 3 2021, 9:12 AM