Add a link to the imported file in the delete and edit summary
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Current

"fileimporter-delete-summary": "This file is now on {{SITENAME}} (moved with FileImporter)."

Desired

"fileimporter-delete-summary": "This file is now on {{SITENAME}} as $file (moved with FileImporter)."

where $file would be a link to the imported file, e.g. ~~[[:c:File:Example.png]]~~ https://commons.wikimedia.org/wiki/Example.png for the WMF cluster.

Note:
Apply the above also for the edit summary, so it's easier to find the file when the original will be deleted

The previous discussion started at T226532#5302656.

Details

Subject	Repo	Branch	Lines +/-
Typo in edit summaries	mediawiki/extensions/FileImporter	master	+2 -2
Add a link to the imported file in the delete/edit summary	mediawiki/extensions/FileImporter	wmf/1.34.0-wmf.13	+10 -8
Add a link to the imported file in the delete/edit summary	mediawiki/extensions/FileImporter	master	+10 -8

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T255346 FileImporter should not percent encode URLs in log entries
Resolved	Andrew-WMDE	T227358 Add a link to the imported file in the delete and edit summary
Resolved	awight	T228851 Source wiki editing and deletion always fails

Event Timeline

JJMC89 created this task.Jul 5 2019, 7:05 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJul 5 2019, 7:05 PM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald Transcript

JJMC89 mentioned this in T226532: If rights exist, suggest automatic deletion of the source wiki file.Jul 5 2019, 7:06 PM

WMDE-Fisch renamed this task from Add a link to the imported file in the delete summary to Add a link to the imported file in the delete and edit summary.Jul 9 2019, 11:42 AM

WMDE-Fisch added a project: WMDE-QWERTY-Spike-2019-07-09.

WMDE-Fisch updated the task description. (Show Details)

WMDE-Fisch set the point value for this task to 1.

WMDE-Fisch moved this task from Backlog to Tickets in sprint on the Move-Files-To-Commons board.

Andrew-WMDE claimed this task.Jul 11 2019, 8:40 AM

Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Spike-2019-07-09 board.

Change 522083 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@master] Add a link to the imported file in the delete/edit summary

https://gerrit.wikimedia.org/r/522083

gerritbot added a project: Patch-For-Review.Jul 11 2019, 1:32 PM

I noticed that if we would like to use Interwiki links in the summaries instead of plain URLs, and continue to support third-party wikis, we would need to make use of the Interwiki API endpoint on the source wiki. This would allow us to determine which prefix should be used to represent the destination wiki and then use that prefix when building the edit summary. An example where this API endpoint was used is https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FileImporter/+/520197/.

Change 522083 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add a link to the imported file in the delete/edit summary

https://gerrit.wikimedia.org/r/522083

Andrew-WMDE mentioned this in rEFLI5f6fc8811731: Add a link to the imported file in the delete/edit summary.Jul 12 2019, 7:36 AM

awight moved this task from Doing to Demo on the WMDE-QWERTY-Spike-2019-07-09 board.Jul 12 2019, 7:47 AM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 12 2019, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2019, 8:10 AM

Change 523617 had a related patch set uploaded (by Awight; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@wmf/1.34.0-wmf.13] Add a link to the imported file in the delete/edit summary

https://gerrit.wikimedia.org/r/523617

gerritbot added a project: Patch-For-Review.Jul 16 2019, 7:53 AM

Change 523617 abandoned by Awight:
Add a link to the imported file in the delete/edit summary

https://gerrit.wikimedia.org/r/523617

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2019, 9:10 AM

It looks to me as if the message now says "at" instead of "as"?

In T227358#5357632, @Lea_WMDE wrote:

It looks to me as if the message now says "at" instead of "as"?

Yes, it's at now. I trusted the natural language skills of @Andrew-WMDE there, but @awight should at least approve I guess. And we should definitely reflect that here then. Thanks for pointing it out. - Any thoughts you two?