Deprecate Skin::addToBodyAttributes in favor of OutputPageBodyAttributes hook
Closed, ResolvedPublic
Actions

Description

OutputPage::headElement adds attributes to the body element via 2 methods - a hook and skin.

I'd like to settle on the hook here to make it more obvious where these attributes are coming from and deprecate the addToBodyAttributes method.

https://codesearch.wmflabs.org/search/?q=addToBodyAttributes&i=nope&files=&repos=

AC

Vector updated to use hook (with check against skin)
Minerva updated to use hook (with check against skin)
Remove the Skin::addToBodyAttributes method but call it with a deprecation notice if the method exists. (Note: nothing seems to use parent:: so this should be fine)

Details

Subject	Repo	Branch	Lines +/-
Deprecate using Skin method to add body attributes.	mediawiki/core	master	+10 -12
Minerva: Use OutputPageBodyAttributes hook to add body attributes	mediawiki/skins/MinervaNeue	master	+40 -30
Vector: Use OutputPageBodyAttributes hook to add body attributes	mediawiki/skins/Vector	master	+21 -13

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	dbarratt	T256421 Deprecated: Use of Skin::addToBodyAttributes method to add body attributes was deprecated in MediaWiki 1.35
		Resolved		Ammarpad	T255698 Deprecate Skin::addToBodyAttributes in favor of OutputPageBodyAttributes hook

Event Timeline

Jdlrobson created this task.Jun 17 2020, 6:04 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJun 17 2020, 6:04 PM

Jdlrobson renamed this task from Deprecate Skin::addToBodyAttributes in favor of OutputPageBodyAttributes to Deprecate Skin::addToBodyAttributes in favor of OutputPageBodyAttributes hook.Jun 17 2020, 6:04 PM

Jdlrobson moved this task from Phase 3 - standardise template data to Phase 1 - simplify hook contracts on the MediaWiki-Core-Skin-Architecture board.

Jdlrobson added a subscriber: Ammarpad.

Ammarpad claimed this task.Jun 18 2020, 11:00 AM

Change 606431 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Vector@master] Vector: Use OutputPageBodyAttributes hook to add body attributes

https://gerrit.wikimedia.org/r/606431

gerritbot added a project: Patch-For-Review.Jun 18 2020, 1:21 PM

Change 606431 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Vector: Use OutputPageBodyAttributes hook to add body attributes

https://gerrit.wikimedia.org/r/606431

Maintenance_bot removed a project: Patch-For-Review.Jun 18 2020, 5:10 PM

Jdlrobson removed a project: Vector (legacy skin).Jun 18 2020, 5:56 PM

Jdlrobson updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 18 2020, 6:00 PM

Change 606546 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MinervaNeue@master] Minerva: Use OutputPageBodyAttributes hook to add body attributes

https://gerrit.wikimedia.org/r/606546

gerritbot added a project: Patch-For-Review.Jun 19 2020, 1:02 AM

Change 606653 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate using Skin method to add body attributes.

https://gerrit.wikimedia.org/r/606653

Change 606546 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Minerva: Use OutputPageBodyAttributes hook to add body attributes

https://gerrit.wikimedia.org/r/606546

Jdlrobson updated the task description. (Show Details)Jun 22 2020, 3:13 PM

Change 606653 merged by jenkins-bot:
[mediawiki/core@master] Deprecate using Skin method to add body attributes.

https://gerrit.wikimedia.org/r/606653

Jdlrobson closed this task as Resolved.Jun 22 2020, 9:31 PM

Jdlrobson updated the task description. (Show Details)

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2020, 10:10 PM

dbarratt added a parent task: T256421: Deprecated: Use of Skin::addToBodyAttributes method to add body attributes was deprecated in MediaWiki 1.35.Jun 25 2020, 8:10 PM

• Demian mentioned this in T266734: [cleanup] Replace deprecated addToBodyAttributes() with onOutputPageBodyAttributes() hook (tracking).Oct 29 2020, 2:50 AM